Repository navigation
Have a BUG in scroll.js #1127
Description
Bug Report
Steps to reproduce
have a BUG in scroll.js
this BUG cause:
if path and id include chinese character, it can't find some result from the nav[].
What is current behaviour
export function scrollIntoView(path, id) {
if (!id) {
return;
}
const topMargin = config().topMargin;
const section = dom.find('#' + id);
section && scrollTo(section, topMargin);
const li = nav[getNavKey(path, id)];
What is the expected behaviour
last line shoule changed to:
const li = nav[getNavKey(decodeURIComponent(path), decodeURIComponent(id))];
Other relevant information
-
Bug does still occur when all/other plugins are disabled?
-
Your OS:
-
Node.js version:
-
npm/yarn version:
-
Browser version:
-
Docsify version:
-
Docsify plugins:
Activity
vagra commentedon Apr 22, 2020
when the .md file name include chinese character:
result:
result:
vagra commentedon Apr 22, 2020
this problem cause:
if .md file include chinese characters, when click at the heading in main content, the sidebar links can't highlight and sync scroll.
because
const li = nav[getNavKey(path, id)]have not result.anikethsaha commentedon Apr 22, 2020
we need to check whether this change will cause side effects or not.
feel free to investigate and submit a fix.
Just a note that we don't have a strong test so we should check manually whether other things are breaking cause of this or not.
fix the bug docsifyjs#1127 and docsifyjs#1136.
Merge pull request #1146 from vagra/bugfix
anikethsaha commentedon May 16, 2020
fixed at #1146