click left sidebar, then refresh the page, lost the sync scroll. #1136

Activity

1. vagra commented on Apr 24, 2020

   

   vagra

   on Apr 24, 2020

   ContributorAuthor

   More actions

   if I don't click the left sidebar item, when refresh the page using F5, I always sync scroll.
2. vagra commented on Apr 24, 2020

   

   vagra

   on Apr 24, 2020

   ContributorAuthor

   More actions

   see this code in scroll.js

   export function scrollActiveSidebar(router) {
   
     const path = router.getCurrentPath();
     console.log(path);  // log info for test
     dom.off('scroll', () => highlight(path));
     dom.on('scroll', () => highlight(path));
   
   }
   

   if I don't click the links at main content or side bar, the path is :

   /docs/pagename
   

   if I clicked the links at main content or side bar, the path is:

   /docs/pagename?id=anchorid
   

   but in the function highlight(path) , does not handle the id in path.
3. vagra

   added a commit that references this issue on Apr 24, 2020

   fix the bug docsifyjs#1127 and docsifyjs#1136.

   e91d065
4. anikethsaha

   added

   bugconfirmed as a bugconfirmed as a bug

   on May 3, 2020
5. anikethsaha

   closed this as completedin #1146on May 3, 2020
6. anikethsaha

   added a commit that references this issue on May 3, 2020

   Merge pull request #1146 from vagra/bugfix

   ...

   This issue will close once commit b2dd708 is merged into the 'develop' branch.

   b2dd708