Repository navigation
[QUIC] Revisit exceptions in Quic #82262
Description
We have several exception issues cropping up for 8.0:
-
QuicConnection.ConnectAsyncraisesSocketExceptionwhen host not found #78751 - [API Proposal] QuicError.AcceptConnectionFailed #75184
- [QUIC] Surface transport error code in QuicException #72666
- QuicListener AcceptConnectionAsync and OperationCanceledException #78096
- Partially fixed in [QUIC] Improved logic of listener AcceptConnection #82261
Activity
antonfirsov commentedon Feb 16, 2023
It would be also nice to distinguish name resolution errors and define
QuicError.HostNotFoundso we can have a unified name resolution error case in #76644.wfurt commentedon Jun 1, 2023
We agreed that we should:
SocketExceptionfor transport problem e.g. for cases like MsQuic AddressInUse, HostUnreachable and InvalidAddress. That generally comes either as user error, host limitation and network conditions. That also covers cases when target name cannot be resolved to address.AuthenticationExceptionfor TLS and certificate related issues - preferably matchingSslStreambehavior.QuicExceptionfor reasons related to Quic protocol or processing specific to Quic.ArgumentExceptionwhen supplied parameters or options provided by callback are not valid.OperationCanceledExceptionfor cases when processing fail because of cancellation.ObjectDisposedExceptionfor cases caused by disposing underlying object(s)We shall document this in some way. Either reach consensus when dotnet/dotnet-api-docs#7840 is resolved, via remarks section or via examples.
karelz commentedon Jul 18, 2023
@wfurt is there anything left here?
wfurt commentedon Jul 18, 2023
While some work related to exceptions remains it is tracked by other issues. We reached agreement on strategy and that fulfills spirit to this issue IMHO