Skip to content

[HttpStress] [SslStress] Windows stress builds are broken #95750

New issue
New issue
Closed
#100145
Closed
[HttpStress] [SslStress] Windows stress builds are broken#95750
#100145
Assignees
antonfirsovrzikm
Labels
area-System.Netin-prThere is an active PR which will close this issue when it is merged
Milestone
8.0.x

Description

@antonfirsov
antonfirsov
opened on Dec 7, 2023
2023-12-07T13:23:15.1583259Z   D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): error C3611: 'System::Numerics::INumberBase::System::IUtf8SpanFormattable.TryFormat': a sealed function cannot have a pure-specifier

The failures started on the 17th of November, across all branches, which indicates an image change might have triggered this, we should do a comparison similar to #82528 (comment).

Edit: links to the pipelines

The failing build that runs outside of docker:

runtime/eng/docker/build-docker-sdk.ps1

Line 24 in 8b04e76

& "$REPO_ROOT_DIR/build.cmd" clr+libs -ci -rc release -c $configuration

Activity

  1. antonfirsov
    added
    area-System.Net
    on Dec 7, 2023
  2. antonfirsov
    added this to the 9.0.0 milestone on Dec 7, 2023
  3. antonfirsov
    self-assigned this
    on Dec 7, 2023

  5. rzikm commented on Dec 8, 2023

    @rzikm
    rzikm
    on Dec 8, 2023
    Member

    I encountered this on my dev machine. The VS installation needs to be updated, see #94998 (comment)

  6. antonfirsov commented on Dec 8, 2023

    @antonfirsov
    antonfirsov
    on Dec 8, 2023
    ContributorAuthor

    This is weird, the Initialize job phase logs that

    Image: windows-2022
Version: 20231126.1.0
Included Software: https://github.com/actions/runner-images/blob/win22/20231126.1/images/windows/Windows2022-Readme.md

    and according to the linked image spec the Visual Studio version is 17.8.34316.72, which should contain the fixed 14.38 C++ runtime tools according to #94998 (comment).

    @dotnet/dnceng can you please assist diagnosing this?

  7. rzikm
    self-assigned this
    on Mar 19, 2024

  8. rzikm commented on Mar 19, 2024

    @rzikm
    rzikm
    on Mar 19, 2024
    Member

    The image seems to contain the right msvc version, but the build script for some reason does not choose the latest toolchain

    Dumping present MSVC versions


    Directory: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC


Mode                 LastWriteTime         Length Name                                                                 
----                 -------------         ------ ----                                                                 
d-----          2/4/2024  10:26 PM                14.16.27023                                                          
d-----          2/4/2024  10:27 PM                14.29.30133                                                          
d-----          2/4/2024  10:31 PM                14.37.32822                                                          
d-----          2/4/2024  10:09 PM                14.38.33130                        

     -- The CXX compiler identification is MSVC 19.37.32826.1

  9. antonfirsov commented on Mar 19, 2024

    @antonfirsov
    antonfirsov
    on Mar 19, 2024
    ContributorAuthor

    I wonder what will happen if you manually delete the <=14.37.32822 directories?

  10. rzikm commented on Mar 19, 2024

    @rzikm
    rzikm
    on Mar 19, 2024
    Member

    I wonder what will happen if you manually delete the <=14.37.32822 directories?

    then it tries to use GCC 🤦

    https://dev.azure.com/dnceng-public/public/_build/results?buildId=608756&view=logs&j=0bc77094-9fcd-5c38-f6e4-27d2ae131589&t=4fd93899-d50b-5dc1-f9eb-66ab1b883c22&l=704

  11. rzikm commented on Mar 19, 2024

    @rzikm
    rzikm
    on Mar 19, 2024
    Member

    Okay, I think I have spent enough time on this and am just trying at random, I think we need help from @dotnet/dnceng to debug this. Can you please take a look?

  12. markwilkie commented on Mar 19, 2024

    @markwilkie
    markwilkie
    on Mar 19, 2024
    Contributor

    @rzikm - what are you hoping dnceng can help with more specifically?

  13. rzikm commented on Mar 20, 2024

    @rzikm
    rzikm
    on Mar 20, 2024
    Member

    we are running the sslstress pipeline on 1es-windows-2022-open images, as such, we need first to build the .NET runtime and then build the stress application against it and run it in docker.

    Since November, the build has been failing due to #94998, the fix for that was supposed to be updating Visual Studio installation.

    According to the list of included software of the image, the new toolchain is installed and seems to shows up in the relevant directories

        Directory: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC


Mode                 LastWriteTime         Length Name                                                                 
----                 -------------         ------ ----                                                                 
d-----          2/4/2024  10:26 PM                14.16.27023                                                          
d-----          2/4/2024  10:27 PM                14.29.30133                                                          
d-----          2/4/2024  10:31 PM                14.37.32822                                                          
d-----          2/4/2024  10:09 PM                14.38.33130

    However, the build still ends up using the older toolchain, and thus failing to build

     -- The CXX compiler identification is MSVC 19.37.32826.1

    The failing step is simply building the SDK docker image via the build-docker-sdk.ps1 -w ....

    @rzikm - what are you hoping dnceng can help with more specifically?

    We are hoping that dnceng would help us get the build to work, since we are using the "official" script to build the image.

    (note that the .net runtime is being built on the host, not inside docker image due to #700)

  14. markwilkie commented on Mar 20, 2024

    @markwilkie
    markwilkie
    on Mar 20, 2024
    Contributor

    You had a chance to check out https://github.com/dotnet/arcade/blob/main/Documentation/ArcadeSdk.md ? It might shed more light on why your build is picking up the wrong toolchain.

  15. antonfirsov commented on Mar 20, 2024

    @antonfirsov
    antonfirsov
    on Mar 20, 2024
    ContributorAuthor

    @markwilkie this seems to be a bug in the build infra that can be reproduced with a very simple yaml, opened #100046.

  16. dotnet-policy-service
    added
    in-prThere is an active PR which will close this issue when it is merged
    on Mar 22, 2024
  17. antonfirsov
    closed this as completedin #100145on Mar 24, 2024
  18. github-actions
    locked and limited conversation to collaborators on Apr 24, 2024

  19. karelz commented on Jun 24, 2024

    @karelz
    karelz
    on Jun 24, 2024
    Member

    Fixed in main (9.0) in PR #100145 and in 8.0.x in PR #100303.

  20. karelz
    modified the milestones: 9.0.0, 8.0.x on Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-System.Netin-prThere is an active PR which will close this issue when it is merged

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions