Repository navigation
Upgrading to Typescript 5.x #1313
Description
Should we update to version 5 (or newer) of TypeScript? We have noticed this in test-things due to discrepancy in the versions (not a huge deal) and I wasn't sure if there is a blocker.
I could not find an exact issue and asked @danielpeintner and we both remember something but not an issue it seems.
Activity
danielpeintner commentedon Aug 8, 2024
Some questions/aspects
"typescript": "4.7.4"in the first place?typescript@5.5.4andnpm run buildfails with errors (e.g., node_modules/@types/node/globals.d.ts:73:13 - error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of typ)relu91 commentedon Aug 21, 2024
I think it might have some consequences with #1267 too.
erossignon commentedon Nov 29, 2024
upgradeing to the latest version of node-opcua uses nodejs16 package definition convention and thefore requires a bump of typescript.
I have fix, to some extend, the issue that daniel pointed out in PR #1335. (see first commit)
As a general rules, some modern version of nodejs packages are using more and more the Node16 or NodeNext convention and it would be a good thing to switch to this so you can upgrade package version more easily.
danielpeintner commentedon Dec 2, 2024
@relu91 @egekorkan @JKRhb what is your feeling.
I know,
browserifyblocked us from updating. Since it will be replaced soon, shall we make the change?Note: maybe it makes sense to push a node-wot version without the change (also without the proposed changes from @erossignon) and afterward move to node-wot 1.0.0 and update NodeJS version?
relu91 commentedon Dec 2, 2024
if it is possible I would wait to merge #1335 until the new PR about moving from browserify has landed. I can open it later this afternoon but mostly as a draft. Than we can understand additional changes needed to make opcua work as @erossignon did in his PR.
relu91 commentedon Dec 4, 2024
Do we have substantial changes to be published? otherwise, I'd wait for the new re-vamped node-wot.
danielpeintner commentedon Dec 5, 2024
Mhh, probably not really...
v0.8.16...master
Let's wait 👍
chore: upgrade to TypeScript 5.x
Upgrade to TypeScript 5.x (eclipse-thingweb#1343)