Repository navigation
Code Simplifier: raise bar to avoid trivial micro-changes - #177
Conversation
Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
There was a problem hiding this comment.
Requesting changes: this introduces an unintended behavior regression where issue-triggered /ai runs will create draft PRs by default because the draft-prs: "false" override was removed.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #177
| @@ -15,7 +15,5 @@ jobs: | |||
| github.event.issue.pull_request == null && | |||
| startsWith(github.event.comment.body, '/ai') | |||
| uses: ./.github/workflows/gh-aw-mention-in-issue.lock.yml | |||
There was a problem hiding this comment.
🟡 MEDIUM: draft-prs override was dropped, changing PR creation behavior
Removing the with.draft-prs: "false" input means this caller now inherits the reusable workflow default (draft-prs: "true" in .github/workflows/gh-aw-mention-in-issue.lock.yml), so /ai issue flows will start creating draft PRs instead of ready-for-review PRs.
This is a behavior change from the previous trigger configuration and can slow triage/automation that expects non-draft PRs.
|
The failed check in run From the job log, the step fails on a dirty worktree after compile and prints modifications across generated workflow outputs (including Recommended remediation for any follow-up branch: run Checks/commands reviewed:
What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
The Code Simplifier was opening PRs for micro-changes (e.g. replacing a two-line map lookup + nil check with a single direct access) that provide negligible value and cost more reviewer time than they save.
Changes
New "Bar for merit" section — a simplification must clear at least one of:
Explicit "Do not submit" rule for idiom swaps — renaming variables, reordering equivalent expressions, or collapsing a two-line pattern into one should result in
noopExpanded candidate search criteria in Step 1 to steer the agent toward style outliers and inline logic that reimplements an existing helper, rather than micro-optimisations
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/ruby/setup-ruby/git/ref/tags/v1/usr/bin/gh gh api /repos/ruby/setup-ruby/git/ref/tags/v1 --jq .object.sha -c=4 -nolocalimports -importcfg /tmp/go-build4059744779/b329/importcfg -pack /home/REDACTED/go/pkg/mod/github.com/sourcegraph/conc@v0.3.0/pool/context_pool.go /home/REDACTED/go/pkg/mod/github.com/sourcegraph/conc@v0.3.0/pool/error_pool.go(http block)/usr/bin/gh gh api /repos/ruby/setup-ruby/git/ref/tags/v1 --jq .object.sha -c=4 -nolocalimports -importcfg /tmp/go-build4059744779/b334/importcfg -pack /home/REDACTED/go/pkg/mod/github.com/spf13/pflag@v1.0.10/bool.go /home/REDACTED/go/pkg/mod/github.com/spf13/pflag@v1.0.10/bool_func.go(http block)/usr/bin/gh gh api /repos/ruby/setup-ruby/git/ref/tags/v1 --jq .object.sha /tmp/go-build4059744779/b338/symabis -c=4 -nolocalimports -importcfg /tmp/go-build4059744779/b338/importcfg -pack -asmhdr(http block)https://api.github.com/user/usr/bin/gh gh api user --jq .login -c=4 -nolocalimports -importcfg /tmp/go-build4059744779/b315/importcfg -pack /home/REDACTED/go/pkg/mod/golang.org/x/text@v0.34.0/message/catalog/catalog.go /home/REDACTED/go/pkg/mod/golang.org/x/text@v0.34.0/message/catalog/dict.go(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.