Skip to content

Let's add workflows for refactor and new features #359

Closed

Description

@strawgate

Let's setup a workflow with a senior architect who thinks we should perform a refactor of the codebase. Force them to partially implement it to ensure it's viable, and then pitch the refactor via a created issue

Let's setup a workflow for an ideas man like we did here elastic/ai-github-actions-playground#30

Let's scope out additional "continuous improvement" flows we might want

Activity

  1. github-actions commented on Feb 22, 2026

    @github-actions
    Contributor
    3 related issues

    What is this? | From workflow: Duplicate Issue Detector

    Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

  2. github-actions commented on Feb 22, 2026

    @github-actions
    Contributor

    The repo already has strong building blocks for this (code-simplifier, code-duplication-detector/fixer, and agent-suggestions), so I recommend adding one new refactor-architect workflow and expanding agent-suggestions for feature-idea generation instead of creating two fully separate net-new systems.

    Recommendation

    1. Add refactor-architect as a scheduled detector workflow (issue output, not PR output) built on scheduled-audit, but require a local proof step (small candidate patch + command results) embedded in the issue report.
    2. Use/extend agent-suggestions for new-feature ideation (it already inventories workflows, checks repo/downstream signals, and files suggestion issues).
    3. Align safe-output lifecycle with ongoing work in Improve defaults for close older issues #357 / PR Improve close-older-issues defaults for auditor/detector workflows #358: for recurring detectors/audits, default close-older-issues: false so independent findings are not auto-closed.
    Findings
    Verification

    I ran workflow linting to confirm current workflow set/config compiles cleanly before proposing additions:

    $ make lint-workflows
    ...
    Checking .github/workflows/trigger-code-simplifier.yml...
    Checking .github/workflows/trigger-code-duplication-detector.yml...
    ...
    (exited with exit code 0)

    This verifies the current baseline is healthy and ready for incremental workflow additions.

    Detailed Action Plan
    1. Create new workflow source

      • Add .github/workflows/gh-aw-refactor-architect.md using the same structure as .github/workflows/gh-aw-code-duplication-detector.md (imports, engine, permissions, tools, safe outputs).
      • Base it on scheduled-audit (.github/workflows/gh-aw-scheduled-audit.md:3-5) and set report format to include:
        • target refactor candidate,
        • minimal proposed patch summary,
        • commands run + outputs,
        • rollback/risk notes.
    2. Set safe output behavior for recurring reports

    3. Add installable trigger and docs

      • Add gh-agent-workflows/refactor-architect/example.yml (weekday schedule + workflow_dispatch, calling new .lock.yml).
      • Add gh-agent-workflows/refactor-architect/README.md following current per-workflow README pattern.
    4. Extend feature ideation path

      • Update .github/workflows/gh-aw-agent-suggestions.md:88-123 to explicitly include “new feature workflow proposals” (not only generic workflow suggestions).
      • Update gh-agent-workflows/agent-suggestions/README.md:3-8 to reflect feature ideation scope.
    5. Expose in catalogs + setup

      • Update gh-agent-workflows/README.md and docs/workflows/gh-agent-workflows.md tables to include refactor-architect and the expanded agent-suggestions description.
      • Add refactor-architect to scripts/quick-setup.sh:128-140 continuous improvement list.
    6. Compile and validate

      • Run make compile (regenerate lock files/triggers), then make lint (or at minimum make lint-workflows).
      • Confirm new trigger appears as .github/workflows/trigger-refactor-architect.yml and lockfile exists.
    Related Items
    Type Link Relevance
    Issue #359 Current request
    Issue #275 Prior “identify additional workflows” request
    Issue #75 Added Code Simplifier concept
    Issue #172 Refined simplifier quality bar
    Issue #357 Detector/auditor issue lifecycle defaults
    PR #81 Added code-simplifier workflow
    PR #177 Raised simplifier threshold (avoid micro-refactors)
    PR #180 Expanded quick-setup continuous-improvement bundle
    PR #358 In-flight close-older-issues default improvements
    File .github/workflows/gh-aw-scheduled-audit.md Best base for report-first architect workflow
    File .github/workflows/gh-aw-agent-suggestions.md Best place to extend feature-idea generation
    File scripts/quick-setup.sh Installs workflow bundles
    Web elastic/ai-github-actions-playground#30 Referenced ideation pattern

    What is this? | From workflow: Issue Triage

    Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

  3. strawgate commented on Feb 22, 2026

    @strawgate
    ContributorAuthor

    no the Ideas Guy should be its own workflow not combined with agent suggestions, agent suggestions is for suggesting new agents, ideas guy is a workflow our downstream consumers will use

  4. github-actions commented on Jul 17, 2026

    @github-actions
    Contributor

    This issue was labeled stale on 2026-02-22 and has had no further activity for 30 days. Closing automatically. If this issue is still relevant, please reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions