You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Port PerformanceStudio's legacy-rule marker: IsLegacy on warnings from pre-framework rules, shown as [legacy] #4566
MarkLegacyWarnings (PS dev PlanAnalyzer.Helpers.cs ~20–40) sets the flag on analyzer warnings of those types, and never on SQL Server's own warnings (Source == SqlServer). Analyze calls it per statement (PS dev PlanAnalyzer.cs ~116).
The renderers show a " [legacy]" tag after the warning type: the viewer's warning lists (PS dev PlanViewerControl.Properties.cs ~862, ~948, ~1024), the advice cards, and the text and HTML output.
PM has the counterpart surfaces: PlanWarning, the MCP plan output (McpPlanAnalysisFormatter), and the shared viewer's warning headers (PlanWarningDisplay). The port is the field, the set, the marking pass, MCP is_legacy, and the viewer tag. PM has no HTML or text exporter, so those halves have no counterpart.
At 08f3e3c4e. PS reference: its dev branch at 85492a1.
Fixed in #4585 (71f3ddb). Findings from PerformanceStudio's 21 legacy warning types are marked IsLegacy (never SQL Server's own warnings), shown as is_legacy in the MCP plan output and a [legacy] tag in the plan viewer, matching PerformanceStudio dev.
Activity
Plan analysis: drop three rules PerformanceStudio removed, and show i…
Replace the #4535 mid-rollout RuleNumber pin with a rule-number census (
Plan analysis: PerformanceStudio's per-rule configuration, rule numbe…
erikdarlingdata commentedon Sep 28, 2026
Claude posting for Erik Darling.
Fixed in #4585 (71f3ddb). Findings from PerformanceStudio's 21 legacy warning types are marked IsLegacy (never SQL Server's own warnings), shown as is_legacy in the MCP plan output and a [legacy] tag in the plan viewer, matching PerformanceStudio dev.