Repository navigation
Measure the DuckDB memory trim by the memory it releases - #4398
Merged
Merged
Conversation
erikdarlingdata
marked this pull request as ready for review
September 26, 2026 07:31
erikdarlingdata
added a commit
that referenced
this pull request
Sep 26, 2026
…4438) Adds the missing [Unreleased] CHANGELOG entries for nine merged PRs. Two more need none. - Fixed: #3588, #3886, #3889, #3900, #3911, #4016, #4032 and #4042. - Changed: #4157. llms.txt and CITATION.cff now match the shipped product. - None: - #4332 adds RawChunkIntervalPlanner without wiring it in; the later PR that wires it carries its own entry. - #4398 changes tests only. - Each entry was written from its PR's diff, with a [#N] label linking the pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only.
RunMemoryTrimCycle_AfterWideRead_ReducesProcessMemoryasserted that the whole-processWorkingSet64strictly decreased. In the nightly run it grew by one 4 KB page, so the test failed. Process working set is noisy, and it isn't what the trim acts on.RunMemoryTrimCyclelowers DuckDB'smemory_limiton the sentinel connection and restores it. The product already reads DuckDB's own usage throughduckdb_memory(). The test now asserts the trim's own contract on that metric: usage is above the trim target (TrimTargetMemoryLimit, 64 MB) before the trim, and at or below it after. How far below the target DuckDB lands varies by platform. Windows CI measured about 106 MB before and 64 MB after; macOS measured about 98 MB before and 0.75 MB after.The seed data changes from a repeated literal, which DuckDB compresses to about 0.5 MB, to an md5-chained payload. The wide read then leaves a real buffer to release.
No CHANGELOG entry: test-only.