Repository navigation
Plan viewer: the Wait Stats header's tooltip matches PerformanceStudio - #4591
Merged
Merged
Conversation
Ports erikdarlingdata/PerformanceStudio@9b8252e to the shared WPF plan viewer (PerformanceMonitor.Ui/PlanViewerControl.xaml, hosted by both the Darling Viewer and Lite). The Wait Stats card gets its own nested Expander, closed by default, instead of always showing alongside Runtime Summary and Missing Index Suggestions inside the outer Insights expander. The header text moves to a pure helper, PlanDisplayText.WaitStatsHeader, matching PS's format: "Wait Stats" alone when there's nothing to show, or "Wait Stats N ms" with the total wait time when there is.
…#4571) The collapsible Wait Stats card's header now reads "Wait Stats" when empty, or "Wait Stats — N ms total" when there is a total wait time, matching PlanViewerControl.WaitStats.cs in the desktop viewer.
…der tooltip Matches PerformanceStudio desktop's Wait Stats header tooltip, shown only when there are waits to describe.
erikdarlingdata
changed the title
erikdarlingdata
marked this pull request as ready for review
September 28, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4511
Why
PerformanceStudio's desktop plan viewer keeps Wait Stats inside the plan's one collapsible panel, with no separate expander per card. It also shows a tooltip on the Wait Stats header giving the total wait time and wait-type count. This PR brings the tooltip over and drops an earlier attempt at a per-card collapsible expander, which was a web-viewer-only feature that doesn't belong on the desktop-parity surface.
What changes
PlanViewerControl.Properties.cs: the Wait Stats header'sToolTipis now set toPlanDisplayText.WaitStatsHeaderTooltip(waitCount, totalWaitMs)wherever the header text itself is set — null (no tooltip) when there are no waits, otherwise the total wait time in milliseconds and the wait-type count.PlanViewerControl.xaml: reverted to its prior structure (oneScrollViewer/StackPanel, noExpanderaround the Wait Stats card).PlanDisplayText.cs: removed theWaitStatsHeaderhelper and its doc comment, since nothing calls it any more; the header text is set directly in the code-behind as it was ondev.Viewer4571Tests.cs: kept only the tooltip pins (null when no waits; total + count string when there are), removed the header-text pins that pointed at the now-removed helper.Test plan
dotnet build Darling/Darling.Tests/Darling.Tests.csproj -c Release -p:EnableWindowsTargeting=true— 0 warnings, 0 errors.dotnet build PerformanceMonitor.Ui/PerformanceMonitor.Ui.csproj -c Release -p:EnableWindowsTargeting=true— 0 warnings, 0 errors.Microsoft.WindowsDesktop.Appframework entry stripped from the runtimeconfig):Darling.Tests.Viewer4571Tests— 2/2 passed.CommentFilterAdoptionTests(4/4),DocCommentHygieneTests(77/77),McpPayloadContractCensusTests(68/68) — all passed. The remaining*Census*classes are unaffected by this diff (no new source files, no MCP payload or migration changes) and were not run.CHANGELOG entry
SECTION: Changed
ENTRY: - The plan viewer's Wait Stats header shows the total wait time and wait-type count on hover ([#4591]) - Matches the desktop viewer's tooltip behavior; no visible layout change otherwise.
REF: [#4591]: #4591