Repository navigation
Web: the event grids' data-start note uses the earliest event shown (part of #4966) - #5197
Merged
Merged
Conversation
Move ViewerEventDataStart to the Storage project so the web note and the desktop viewer share one rule. The web note follows it for blocked process reports, long query completions, memory pressure events and the Default Trace, and its capped rule is now table-driven.
…re grid draws the note on data (#4966)
… plainly, and skip a ranked page's event when it is cut (#4966)
…s live tests call
# Conflicts: # Darling/PerformanceMonitor.Darling.Service/WebDataStartNote.cs
This was referenced Oct 5, 2026
erikdarlingdata
marked this pull request as ready for review
October 5, 2026 09:18
erikdarlingdata
added a commit
that referenced
this pull request
Oct 5, 2026
…ls say where their data starts (part of #4966) (#5222) The Darling web server page's partial-window note now covers fourteen more event reads, on data and empty answers alike: the nine get_health_parser_* reads (System Events), get_blocking, get_deadlocks and get_deadlock_detail, and PostgreSQL's get_pg_deadlocks and get_pg_log_events. An empty System Events panel over a window the store never covered used to show nothing, because the tool's own keys sat under hints, which the page does not read. These are event lists, so the note follows the event-time rule from #5197: the earlier of the store's coverage start and the earliest event shown (the desktop viewer's ViewerEventDataStart.Of). A page cut by its row cap names its oldest row shown without asking the store (RowStatusByRead and the per-read oldest field). get_blocking is fed by the blocked process reports and the DMV blocking snapshots, so its probe asks both and the earlier start wins (CompositeSourcesByRead), as the MCP tool and the desktop viewer do. empty, no_deadlocks and no_events are admitted as "looked and found nothing"; unavailable with source_observed false is not. Tests: a theory over the nine system-health reads (capped, uncapped, empty, unavailable), a capped page for each of the other five, the capped set pinned at twenty reads, source scans tying each listed read to its tool, and live cases with event times stamped apart from collection_time, including get_blocking with rows in only one of its two tables. Part of #4966
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What users see change
Changes
ViewerEventDataStartmoved from the desktop viewer toPerformanceMonitor.Darling.Storage(the web service does not reference the viewer), so the web and the viewer share one rule. Its code is unchanged; only its namespace and theusinglines that name it moved.CappedByRead); collection log and PostgreSQL config changes behave as before.memory_pressure_eventsgets its own probe source.Test plan
truncated:truestill goes to the coverage probe.CappedByRead), a test pins that set, a truncated Long Query Completions page reads the coverage start only, and a capped Blocked Process Reports page names its oldest event without asking the store.ViewerEventDataStart, plusWebDataStartNoteEventReadsTestsandWebDataStartNoteTests: 152 tests, 0 failed (49 skipped there: live cases that need a PostgreSQL store, run on the Mac).CHANGELOG
SECTION: Fixed
ENTRY: - The web page's event grids say where their data starts ([#5197]) - Blocked Process Reports, Long Query Completions, Memory Pressure Events and Default Trace now show a partial-window note when the data starts after the window starts, naming the earlier of the collector's coverage and the earliest event shown, as the desktop viewer does. A capped page names its oldest event shown.
REF: [#5197]: #5197
Part of #4966