Skip to content

Merge train 4843-18 (CI only; not for merge) - #5215

Closed
erikdarlingdata wants to merge 5 commits into
devfrom
train/4843-18
Closed

erikdarlingdata wants to merge 5 commits into
devfrom
train/4843-18

Conversation

@erikdarlingdata

Copy link
Copy Markdown
Owner

Merge train, not for merge. CI runs once on dev plus the squash of each PR below, in this order. When it is green, each is squash-merged by itself in the same order, dev's tree is checked against this branch's, and this PR is closed unmerged.

Part of #4966, #5097, #5098 and #5208. Carries migration rung V163.

PRs in this train, in order

Train head 0b92d8248, tree 7f7f2b1e5, base dev 1acb3d710.

The first member goes first on purpose, ahead of the rung. It fixes a live-store hygiene guard that dev itself trips: two window-notice test files were added as partial class parts of existing live classes, while the serialising attribute sits only on the other part, so the guard's per-file scan flags them. Until that is fixed, every train carries a standing red, and a standing red is how a real failure gets waved through. A Windows VM confirmed the guard RUNS and passes on that fix (11 tests, 0 failed) and runs and fails on plain dev (11 tests, 1 failed), and that the offender list is identical on dev and on dev plus another member here, so the fix covers the whole set rather than tonight's symptom.

The rung member is second; nothing in this train depends on its schema, so that ordering is free.

Local merged-tree checks: 1,800 tests, 0 build warnings. Two classes fail, both matching dev at this commit: the store-upgrade class at 9, and the hygiene class, which on macOS cannot load a Windows presentation assembly and so cannot speak to the fix at all — that is what the VM run above is for. The repository-source scan over 400 classes reports no new failure.

…eir own live-postgres classes (part of #4966) (#5214)

Train train/4843-18: squash of 207b0cf.
…nts deltas (V163, part of #5097) (#5203)

Train train/4843-18: squash of 2c2587d.
…ools say where their data starts (part of #4966) (#5205)

Train train/4843-18: squash of b194128.
@erikdarlingdata

Copy link
Copy Markdown
Owner Author

Superseded by train 18b. One member introduces a new offender to the live-store hygiene guard that this train's first member fixes, and is the prime suspect for a second, unrelated live-test failure that dev does not have. The other four members ride 18b. Closing unmerged.

@erikdarlingdata
erikdarlingdata deleted the train/4843-18 branch October 5, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant