Repository navigation
Ignore VLC for Android CVEs on non-Android VLC - #55058
juan-fdz-hawa merged 5 commits into
Conversation
CVE-2026-26227 and CVE-2026-26228 affect only VLC for Android. NVD deferred them and the VulnCheck CPE data uses target_sw=*, so desktop VLC below 3.7.0 matched. Add a CPE matching rule that only keeps them for target_sw=android. Resolves fleetdm#55057
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe change maps Android applications to Android-targeted CPEs and excludes the Android OS package from NVD CPE matching. It adds Android CPE coverage for VLC and Chrome. It restricts CVE-2026-26227 and CVE-2026-26228 matches to Android and adds tests for desktop and unspecified targets. Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description check | The description identifies issue #55057, explains the root cause and fix, and records automated test coverage. Manual QA remains unchecked, but the description is mostly complete. |
|
| Linked Issues check | The description links issue #55057, and the stated implementation directly addresses that issue's requested VLC Android CPE matching behavior. |
|
| Title check | The title clearly and concisely describes the primary change: preventing non-Android VLC from matching Android-only CVEs. | |
| Linked Issues check | Issue #55057 requires CVE-2026-26227 and CVE-2026-26228 to match VLC only when target_sw is android. GetKnownNVDBugRules adds one rule for both CVEs and ignores every CPE whose TargetSW is not android… |
Full details: Linked Issues check
-
Explanation
Issue
#55057requires CVE-2026-26227 and CVE-2026-26228 to match VLC only when target_sw is android. GetKnownNVDBugRules adds one rule for both CVEs and ignores every CPE whose TargetSW is not android. Tests verify Android VLC matches and macOS, Windows, and unspecified target software do not match. The android_apps mapping produces target_sw=android for Android VLC inventory.
Full details: Out of Scope Changes check
-
Explanation
The PR includes broader Android CPE mapping changes for Chrome and Android OS attribution in addition to the two requested VLC CVE rules. The stated objective says broader Android handling is separate and not required.
Resolution
Remove the unrelated Android CPE mapping changes, or update the PR objectives and linked issue to explain why those changes are required and in scope.
Full details: Out of Scope Changes check
-
Explanation
The PR also changes CPEFromSoftware to suppress all Android OS package CPEs when ApplicationID is android. Issue
#55057concerns VLC CVE matching and does not require a general Android OS vulnerability change. The added Android OS and Chrome integration cases and the second changelog entry document this additional behavior.Resolution
Remove the unrelated Android OS suppression and its tests and changelog claim, or link that behavior to a separate active issue. Keep the android_apps target_sw mapping and VLC-specific tests because they support the
#55057requirement.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 5 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55058 +/- ##
==========================================
+ Coverage 77.30% 77.42% +0.12%
==========================================
Files 4305 4331 +26
Lines 267777 270548 +2771
Branches 15897 15891 -6
==========================================
+ Hits 207014 209481 +2467
- Misses 60574 60878 +304
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Update from the data side: VulnCheck (the CNA for both CVEs) confirmed the CPE was wrong. They removed it from the CVE records and added The VulnCheck NVD data this feed is built from still has |
| "CVE-2026-26228": {}, | ||
| }, | ||
| IgnoreIf: func(cpeMeta *wfn.Attributes) bool { | ||
| return cpeMeta.TargetSW != "android" |
There was a problem hiding this comment.
For Android apps this is always "*", this rule will be applied always regardless of platform. So this introduce false negatives
juan-fdz-hawa
left a comment
There was a problem hiding this comment.
Thanks for the contrib.
See comment, as part of this solution you should set the targetSW to android, that way the rule won't introduce false negatives.
The VLC for Android rule ignores CVE-2026-26227 and CVE-2026-26228 unless target_sw is "android", but Android apps were generated with target_sw=*, so the rule also removed the CVEs from VLC for Android. Generate android_apps CPEs with target_sw=android. This keeps the VLC CVEs on Android and drops CVEs that NVD scopes to other platforms (e.g. GlobalProtect for macOS, Citrix Workspace for Windows, Firefox for iOS). It also matches CVEs that NVD lists only for Android (e.g. Firefox for Android), and maps Chrome to google:chrome instead of 360:chrome, so Chrome for Android now reports its CVEs. Skip CPE generation for the Android OS package ("android"). With target_sw=android it would match every unversioned Android OS CVE in NVD (~1,800). Android OS vulnerabilities already come from the OSV artifacts by security patch level.
**Related issue:** NA Adds Fleet's November 2026 newsletter (`articles/newsletter-2026-11.md`), which covers October 2026. It publishes at `fleetdm.com/newsletters/newsletter-2026-11`. - **Email subject line:** `Fleet news: November 2026` - **Category:** `newsletter`, singular, which the website build accepts (#52120). No website changes are needed. - **Author:** Aube Paul (`robinedev`), matching the September and October issues. ## Open questions for reviewers - **New "📺 Fleet Virtual Summit" section** for the November 10 LinkedIn Live event, placed before workshops. Keep it or fold it into the workshops section. If it stays, it's a new entry in the newsletter's section emoji table. - **The roadmap preview is linked even though November isn't a quarter's first month.** The October preview published October 13, after the October issue went out, so readers haven't seen it in the newsletter yet. - **Article and guide picks are editorial**, not based on traffic numbers. Reorder them if you have analytics. There were no case studies in October. - **The community section has one post, and it's personal.** Henry Stamerjohann's MacSysAdmin talk. Fleet's company-page post about the "Apple in the enterprise" research is another option, but it repeats the research article in "Worth reading." No engagement numbers were available. - **Community contributors with five or more merged PRs in October:** Prajwal Janbandhu (8, in the thank-you line), Michael Alt (6, highlighted), Dhvanit (6, returning, not named), and Shreyash Agare (5, returning, not named). Confirm none of them is a contractor whose account isn't in the org. - **Several first-time contributors only edited the handbook.** None appear in Fleet's Slack, so they stay in the thank-you line. ## How each section was sourced - **Shipped:** the Fleet 4.93.0 and 4.94.0 release articles, cross-checked against tagged releases. The three highlights are macOS patch notifications (Premium), Android zero-touch enrollment (Premium), and self-service configuration profiles (not Premium), so the section isn't all Premium. Patch releases 4.93.1 and 4.93.2 are covered by the "See every release" link. - **Planned:** the release planning board (view 10, filtered to milestone 4.95.0), not the milestone fallback. There are 22 stories, all assigned. 5.0.0 is due December 4, so November holds one release. - **Workshops:** fleetdm.com/workshops, with the next five after the send date. - **Community contributions:** PRs merged in public `fleetdm` repos in October by authors outside the `fleetdm` org, minus bots. ## Left out on purpose - **"Windows: force standard account"** was in the planned section in both September and October and hasn't shipped. It's not on the 4.95.0 board, so it isn't mentioned a third time. - **Multiple versions of the same App Store app** is named in the 4.94.0 release article's title, but the article marks it as moved to 4.95. It's listed under "Also on deck" instead of "shipped." - **Amsterdam workshop (November 3):** past by the time this sends. - **Fleet staff or contractors whose accounts aren't in the org:** @TraiLynne and @thomcrowe. Both are confirmed in Fleet's Slack. - **Other October content:** the warehouse inventory article and Retriever guide, the PHP2Shell and eMudhra pieces, and every `industry news` article. The routine doesn't feature that category. <details> <summary>Suggested <code>~/fleet-newsletters/contributors.tsv</code> lines (append once confirmed)</summary> ``` TraiLynne fleet Trai Lynne Compton, Fleet staff (Slack); not an org member thomcrowe fleet Thom Crowe, Fleet contractor (website); not an org member ``` </details> <details> <summary>Ledger append block: run only after this issue is sent</summary> `~/fleet-newsletters/ledger.jsonl` didn't exist before this issue. Repeats were checked against the September and October issues in the repo instead. This block creates the ledger and records every item in this issue. ```bash mkdir -p ~/fleet-newsletters && cat >> ~/fleet-newsletters/ledger.jsonl <<'EOF' {"issue":"2026-11","section":"shipped","id":"4.93.0"} {"issue":"2026-11","section":"shipped","id":"4.94.0"} {"issue":"2026-11","section":"planned","id":"51599"} {"issue":"2026-11","section":"planned","id":"39176"} {"issue":"2026-11","section":"planned","id":"51979"} {"issue":"2026-11","section":"planned","id":"53284"} {"issue":"2026-11","section":"planned","id":"33062"} {"issue":"2026-11","section":"planned","id":"52534"} {"issue":"2026-11","section":"planned","id":"47904"} {"issue":"2026-11","section":"events","id":"fleet-virtual-summit-2026"} {"issue":"2026-11","section":"events","id":"2003719976388"} {"issue":"2026-11","section":"events","id":"2003716644422"} {"issue":"2026-11","section":"events","id":"2002266719658"} {"issue":"2026-11","section":"events","id":"2002266872114"} {"issue":"2026-11","section":"events","id":"2002267524064"} {"issue":"2026-11","section":"articles","id":"apple-in-the-enterprise-2026"} {"issue":"2026-11","section":"articles","id":"nvidia-gtc-2026"} {"issue":"2026-11","section":"articles","id":"tailworm-what-to-do-about-tailscale-ssh-before-the-fix-ships"} {"issue":"2026-11","section":"articles","id":"revert-a-bad-change-in-gitops"} {"issue":"2026-11","section":"articles","id":"block-chrome-extensions"} {"issue":"2026-11","section":"articles","id":"block-edge-extensions"} {"issue":"2026-11","section":"articles","id":"block-firefox-extensions"} {"issue":"2026-11","section":"articles","id":"block-safari-extensions"} {"issue":"2026-11","section":"articles","id":"use-claude-code-with-fleet"} {"issue":"2026-11","section":"articles","id":"roadmap-preview-october-2026"} {"issue":"2026-11","section":"social","id":"7513481631123394560"} {"issue":"2026-11","section":"community","id":"#50836"} {"issue":"2026-11","section":"community","id":"#53407"} {"issue":"2026-11","section":"community","id":"#53670"} {"issue":"2026-11","section":"community","id":"#53768"} {"issue":"2026-11","section":"community","id":"#53810"} {"issue":"2026-11","section":"community","id":"#53824"} {"issue":"2026-11","section":"community","id":"#54019"} {"issue":"2026-11","section":"community","id":"#54181"} {"issue":"2026-11","section":"community","id":"#54296"} {"issue":"2026-11","section":"community","id":"#54411"} {"issue":"2026-11","section":"community","id":"#54502"} {"issue":"2026-11","section":"community","id":"#54509"} {"issue":"2026-11","section":"community","id":"#54592"} {"issue":"2026-11","section":"community","id":"#54685"} {"issue":"2026-11","section":"community","id":"#54708"} {"issue":"2026-11","section":"community","id":"#54726"} {"issue":"2026-11","section":"community","id":"#54785"} {"issue":"2026-11","section":"community","id":"#55056"} {"issue":"2026-11","section":"community","id":"#55058"} {"issue":"2026-11","section":"community","id":"#55072"} {"issue":"2026-11","section":"community","id":"#55089"} {"issue":"2026-11","section":"community","id":"#55097"} {"issue":"2026-11","section":"community","id":"#55127"} {"issue":"2026-11","section":"community","id":"#55249"} {"issue":"2026-11","section":"community","id":"#55266"} {"issue":"2026-11","section":"community","id":"#55353"} {"issue":"2026-11","section":"community","id":"#55471"} {"issue":"2026-11","section":"community","id":"#55492"} {"issue":"2026-11","section":"community","id":"#55547"} {"issue":"2026-11","section":"community","id":"#55841"} {"issue":"2026-11","section":"community","id":"#55900"} {"issue":"2026-11","section":"community","id":"#55903"} {"issue":"2026-11","section":"community","id":"#55946"} {"issue":"2026-11","section":"community","id":"#56072"} {"issue":"2026-11","section":"community","id":"#56085"} {"issue":"2026-11","section":"community","id":"#56148"} {"issue":"2026-11","section":"community","id":"#56214"} {"issue":"2026-11","section":"community","id":"#56266"} {"issue":"2026-11","section":"community","id":"#56287"} {"issue":"2026-11","section":"community","id":"#56376"} {"issue":"2026-11","section":"community","id":"#56403"} {"issue":"2026-11","section":"community","id":"#56486"} {"issue":"2026-11","section":"community","id":"#56498"} {"issue":"2026-11","section":"community","id":"#56575"} {"issue":"2026-11","section":"community","id":"#56596"} {"issue":"2026-11","section":"community","id":"#56609"} {"issue":"2026-11","section":"community","id":"#56657"} {"issue":"2026-11","section":"community","id":"#56708"} {"issue":"2026-11","section":"community","id":"#56719"} {"issue":"2026-11","section":"community","id":"#56983"} {"issue":"2026-11","section":"community","id":"#56984"} {"issue":"2026-11","section":"community","id":"#56985"} EOF ``` </details> ## Testing - [x] Confirmed the markdown passes the website build's metadata checks: required meta tags, ISO `publishedOn`, description at 139 of 150 characters, `category` set to `newsletter`, H1 matching `articleTitle`, and no Vue-template braces. - [x] Verified all 54 fleetdm.com, GitHub, and Eventbrite links return 200. LinkedIn returns 999 to automated requests, so the profile links come from the handbook and the post link was opened in a browser. - [x] Checked the copy against Fleet's content style: no em dashes, sentence-case headings, Oxford commas, and Fleet Premium labels carried through from the release articles. - [ ] QA'd all new/changed functionality manually ## AI **AI:** Claude Code (claude-opus-5-5) --------- Co-authored-by: robinedev <aubedev@outlook.com>
Related issue: Resolves #55057
CVE-2026-26227 and CVE-2026-26228 affect only VLC for Android, but the VulnCheck CPE data uses
cpe:2.3:a:videolan:vlc:*:*:*:*:*:*:*:*withversionEndExcluding: 3.7.0, so desktop VLC 3.0.x matched. This adds aCPEMatchingRulethat ignores both CVEs unlesstarget_swisandroid, following the existing CVE-2024-3219 rule.Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
TestGetKnownNVDBugRulesnow checks that both CVEs match VLC withtarget_sw=androidand don't match VLC 3.0.23 on macOS, Windows ortarget_sw=*.go test -tags fts5 -run TestGetKnownNVDBugRules ./server/vulnerabilities/nvd/passes.Summary by CodeRabbit