Skip to content

fix(test): repair the Flutter tests listed as known failures - #282

Merged
PapyElGringo merged 2 commits into
mainfrom
fix/failing-flutter-tests
Nov 16, 2026
Merged

PapyElGringo merged 2 commits into
mainfrom
fix/failing-flutter-tests

Conversation

@PapyElGringo

Copy link
Copy Markdown
Contributor

Problem

Seven Flutter tests were listed in extra/probe/known_failures.txt, some marked intermittent. They failed for three reasons:

  • Hotkeys provider not overridden (6 tests): ephemeral_window_focus, gaming_overlay_frost and both window_tile_resize tests. Since fix(keyboard): keybinding capture focus and Ctrl+Super+Arrow #190, SurfaceFocus watches hotkeysActivatorProvider. The real provider reads the default settings through VESHELL_DEFAULT_CONFIG_DIR, which is unset under flutter test, so it throws. The tests passed only in a shell that had the variable set, which is why some looked intermittent.
  • Tile resize timing (2 tests): since fix: native-size cursors and an animated tile resize #237, a tile-count change animates the tile size, starting a frame later. The tests advanced with two zero-length pumps, so the tile never reached its new size and no geometry was requested.
  • Fixed temp path: veshell_language_test created its settings directory under /tmp/opencode, which only exists if another tool created it.

Changes

  • Override hotkeysActivatorProvider with no hotkeys in the four affected test files, as window_sizing_ownership_test already does.
  • In window_tile_resize_test, pumpAndSettle after each tile-count change. The test still checks the size finally requested.
  • Create the language test's directory with Directory.systemTemp.createTempSync.
  • Empty known_failures.txt.

Verification

  • flutter test: 1046 passed, 0 failed.
  • cargo test: 349 passed.

- Override the hotkeys provider in the ephemeral window focus, gaming
  overlay frost and tile resize tests: `SurfaceFocus` watches it, and the
  real one reads settings files the tests do not have.
- Wait for the animated tile resize to finish in the tile resize tests
  before checking the requested geometry.
- Create the language test's settings directory under the system temp
  directory instead of a fixed path that may not exist.
- Empty the known failures list.
@PapyElGringo
PapyElGringo merged commit 67458ca into main Nov 16, 2026
1 of 2 checks passed
@PapyElGringo
PapyElGringo deleted the fix/failing-flutter-tests branch November 16, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant