Repository navigation
fix(test): repair the Flutter tests listed as known failures - #282
Merged
Merged
Conversation
- Override the hotkeys provider in the ephemeral window focus, gaming overlay frost and tile resize tests: `SurfaceFocus` watches it, and the real one reads settings files the tests do not have. - Wait for the animated tile resize to finish in the tile resize tests before checking the requested geometry. - Create the language test's settings directory under the system temp directory instead of a fixed path that may not exist. - Empty the known failures list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Seven Flutter tests were listed in
extra/probe/known_failures.txt, some marked intermittent. They failed for three reasons:ephemeral_window_focus,gaming_overlay_frostand bothwindow_tile_resizetests. Since fix(keyboard): keybinding capture focus and Ctrl+Super+Arrow #190,SurfaceFocuswatcheshotkeysActivatorProvider. The real provider reads the default settings throughVESHELL_DEFAULT_CONFIG_DIR, which is unset underflutter test, so it throws. The tests passed only in a shell that had the variable set, which is why some looked intermittent.veshell_language_testcreated its settings directory under/tmp/opencode, which only exists if another tool created it.Changes
hotkeysActivatorProviderwith no hotkeys in the four affected test files, aswindow_sizing_ownership_testalready does.window_tile_resize_test,pumpAndSettleafter each tile-count change. The test still checks the size finally requested.Directory.systemTemp.createTempSync.known_failures.txt.Verification
flutter test: 1046 passed, 0 failed.cargo test: 349 passed.