Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions extra/probe/known_failures.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
# Flutter tests failing on main, one per line (file under test/: test name).
# `veshell-probe verify` fails on any other failure, and reports a listed test
# that passes again, so it can be removed.
ephemeral_window_focus_test.dart: clicking the window hands it the keyboard
ephemeral_window_focus_test.dart: selecting the displayed window tab hands it the keyboard
ephemeral_window_focus_test.dart: the surface takes the keyboard once the window is matched
gaming_overlay_frost_test.dart: the paused game is frosted instead of dimmed
# Intermittent: passes alone and in some full runs.
veshell_language_test.dart: picker lists only shipped catalogs and persists immediately
window_tile_resize_test.dart: every tile-count change re-asserts the size, not just the first one
window_tile_resize_test.dart: restoring the displayed tile count resizes the window back to full
5 changes: 5 additions & 0 deletions src/shell/test/ephemeral_window_focus_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import 'package:shell/platform/model/request/platform_request.dart';
import 'package:shell/platform/provider/platform_manager.dart';
import 'package:shell/screen/model/screen.serializable.dart';
import 'package:shell/screen/widget/current_screen_id.dart';
import 'package:shell/shortcut_manager/provider/hotkeys_activator.dart';
import 'package:shell/wayland/model/wl_surface.dart';
import 'package:shell/wayland/provider/wl_surface_state.dart';
import 'package:shell/window/model/ephemeral_window.dart';
Expand Down Expand Up @@ -135,6 +136,8 @@ void main() {
ProviderScope(
overrides: [
platformManagerProvider.overrideWith(_FakePlatformManager.new),
// The real hotkeys read the settings files, which tests do not have.
hotkeysActivatorProvider.overrideWithValue(const {}),
ephemeralWindowStateProvider(_windowId).overrideWith(windowState),
if (displayed) ...[
metaWindowStateProvider(
Expand Down Expand Up @@ -250,6 +253,8 @@ void main() {
ProviderScope(
overrides: [
platformManagerProvider.overrideWith(_FakePlatformManager.new),
// The real hotkeys read the settings files, which tests do not have.
hotkeysActivatorProvider.overrideWithValue(const {}),
overviewStateProvider(
_screenId,
).overrideWith(_SelectedWindowOverviewState.new),
Expand Down
3 changes: 3 additions & 0 deletions src/shell/test/gaming_overlay_frost_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import 'package:shell/platform/model/event/meta_window_patches/meta_window_patch
import 'package:shell/platform/model/event/platform_event.serializable.dart';
import 'package:shell/platform/provider/platform_manager.dart';
import 'package:shell/shared/widget/frosted_surface.dart';
import 'package:shell/shortcut_manager/provider/hotkeys_activator.dart';
import 'package:shell/wayland/model/wl_surface.dart';
import 'package:shell/wayland/provider/wl_surface_state.dart';

Expand Down Expand Up @@ -62,6 +63,8 @@ void main() {
platformManagerProvider.overrideWithValue(
const Stream<PlatformEvent>.empty(),
),
// The real hotkeys read the settings files, which tests do not have.
hotkeysActivatorProvider.overrideWithValue(const {}),
metaWindowStateProvider(
_windowId,
).overrideWith(_FixedMetaWindowState.new),
Expand Down
4 changes: 1 addition & 3 deletions src/shell/test/veshell_language_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,7 @@ void main() {
final dispatcher = TestWidgetsFlutterBinding.instance.platformDispatcher
..localesTestValue = const [Locale('zz')];
addTearDown(dispatcher.clearLocalesTestValue);
final directory = Directory(
'/tmp/opencode',
).createTempSync('veshell-language-');
final directory = Directory.systemTemp.createTempSync('veshell-language-');
addTearDown(() => directory.deleteSync(recursive: true));
final file = File('${directory.path}/settings.json')
..writeAsStringSync(jsonEncode({'unrelated': true}));
Expand Down
14 changes: 11 additions & 3 deletions src/shell/test/window_tile_resize_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import 'package:shell/platform/model/event/meta_window_patches/meta_window_patch
import 'package:shell/platform/model/event/platform_event.serializable.dart';
import 'package:shell/platform/provider/platform_manager.dart';
import 'package:shell/shared/widget/sliding_container.dart';
import 'package:shell/shortcut_manager/provider/hotkeys_activator.dart';
import 'package:shell/wayland/model/wl_surface.dart';
import 'package:shell/wayland/provider/wl_surface_state.dart';
import 'package:shell/window/widget/window.dart';
Expand Down Expand Up @@ -108,6 +109,8 @@ void main() {
ProviderScope(
overrides: [
platformManagerProvider.overrideWithValue(events.stream),
// The real hotkeys read the settings files, which tests do not have.
hotkeysActivatorProvider.overrideWithValue(const {}),
metaWindowStateProvider(
_windowId,
).overrideWith(_FakeMetaWindowState.new),
Expand Down Expand Up @@ -161,7 +164,8 @@ void main() {
_patches.clear();
visible.value = 1;
await tester.pump();
await tester.pump();
// Tile-count changes animate the tile size; let it reach the new one.
await tester.pumpAndSettle();

expect(
_patches.whereType<UpdateGeometry>().map((patch) => patch.value?.width),
Expand Down Expand Up @@ -190,6 +194,8 @@ void main() {
ProviderScope(
overrides: [
platformManagerProvider.overrideWithValue(events.stream),
// The real hotkeys read the settings files, which tests do not have.
hotkeysActivatorProvider.overrideWithValue(const {}),
metaWindowStateProvider(
_windowId,
).overrideWith(_FakeMetaWindowState.new),
Expand Down Expand Up @@ -234,7 +240,8 @@ void main() {
_surfaceState!.setBuffer(_fullSize);
visible.value = 2;
await tester.pump();
await tester.pump();
// Tile-count changes animate the tile size; let it reach the new one.
await tester.pumpAndSettle();
expect(
_patches.whereType<UpdateGeometry>().map(
(patch) => patch.value?.width,
Expand All @@ -247,7 +254,8 @@ void main() {
_surfaceState!.setBuffer(_halfSize);
visible.value = 1;
await tester.pump();
await tester.pump();
// Tile-count changes animate the tile size; let it reach the new one.
await tester.pumpAndSettle();
expect(
_patches.whereType<UpdateGeometry>().map(
(patch) => patch.value?.width,
Expand Down
Loading