Skip to content

chore: mark .fullsend/config.yaml as managed by the fleet manifest - #62

Merged
ggallen merged 1 commit into
mainfrom
fullsend-managed-config-marker
Oct 23, 2026
Merged

ggallen merged 1 commit into
mainfrom
fullsend-managed-config-marker

Conversation

@waynesun09

@waynesun09 waynesun09 commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Adoption step for fullsend-ai/.fullsend#187 (ADR 0122). The two marker lines are the only change.

Without the marker, fullsend repos install skips this repository and reports adoption required (fullsend-ai/fullsend#8511). With it, the next fleet sync can propose the manifest-rendered configuration in an ordinary pull request.

Effective configuration change after adoption: gains the six fleet agents and status reactions (this repository ran code defaults). The broken QualityFlow source was removed from this repository by #63 and from the fleet manifest by fullsend-ai/.fullsend#189 before this branch was rebased.

The repository's settings now live in its entry in fullsend-ai/.fullsend/repos.yaml; change them there, not in this file.

@waynesun09
waynesun09 requested a review from a team October 16, 2026 20:22
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Mark Fullsend configuration as fleet-managed

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Adds the management marker so fleet sync can adopt .fullsend/config.yaml instead of stopping.
• Directs future configuration changes to the fleet manifest; this PR does not change effective
 settings.
High-Level Assessment

Adding the required marker is the smallest adoption step. It lets the scheduled fleet sync render the manifest configuration in a subsequent PR without changing settings in this one.

Files changed (1) +2 / -0

Other (1) +2 / -0
config.yamlDeclare the configuration fleet-managed +2/-0

Declare the configuration fleet-managed

• Adds the 'repos-config-v1' management marker and a warning against direct edits. The existing configuration remains unchanged; the marker allows fleet sync to adopt the file.

.fullsend/config.yaml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can pick a display mode instead of tweaking every Display option by hand

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:24 PM UTC · Completed 8:30 PM UTC

Commit: 4f55320 · View workflow run →

Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $2.00

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Oct 16, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: low (1/5)

Details

Minimal config-only change (1 file, 2 lines) with no protected paths, no CI or dependency changes, and a clean regression history; three distinct authors over 90 days and ~55-day file age modestly elevate Tier 2 but the composite (0.62×1.1 + 0.38×1.6 = 1.29) rounds to 1.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 16, 2026
@waynesun09

Copy link
Copy Markdown
Member Author

The failed dispatch / Harness dispatch job on this PR is pre-existing and unrelated to the marker: the QualityFlow source pinned in this repository's .fullsend/config.yaml (qualityflow-fullsend @ b26c947e) points at a base agent file that no longer exists at that commit, so the harness fails with no agents could be loaded ... got 404. fullsend-ai/fullsend and fullsend-ai/agents pin 572ba470, which loads. The fleet manifest entry for this repository copies the b26c947e source as-is to keep adoption a no-op; bumping it to 572ba470 in fullsend-ai/.fullsend/repos.yaml is a one-line change for whoever owns this repository's QualityFlow setup.

@waynesun09

Copy link
Copy Markdown
Member Author

Follow-up: #63 removes the QualityFlow harness entirely (the pinned source 404s), with the matching manifest change in fullsend-ai/.fullsend#189. This PR stays marker-only; the two apply in either order.

@ggallen
ggallen force-pushed the fullsend-managed-config-marker branch from 4f55320 to 02c2273 Compare October 23, 2026 16:44
Adopts this file into fullsend-ai/.fullsend/repos.yaml management (ADR 0122):
the marker is the only change here, so the next fleet sync can rewrite the
file to the manifest's rendering instead of stopping on "adoption required".
Effective configuration change after adoption: gains the six fleet agents and status reactions (this repository ran code defaults). The broken QualityFlow source was removed separately in #63.

Assisted-by: Claude
Signed-off-by: Wayne Sun <1912684+waynesun09@users.noreply.github.com>
Signed-off-by: Greg Allen <gallen@redhat.com>
Signed-off-by: Codex <codex@openai.com>
@ggallen
ggallen force-pushed the fullsend-managed-config-marker branch from 02c2273 to 519802b Compare October 23, 2026 16:45
@fullsend-ai-review

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Ended 4:45 PM UTC

Commit: 02c2273 · View workflow run →

This review was superseded by a newer commit. Check the current pull request HEAD's review status before merging.

@ggallen
ggallen enabled auto-merge October 23, 2026 16:46
@ggallen
ggallen added this pull request to the merge queue Oct 23, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 4:47 PM UTC · Completed 4:55 PM UTC

Commit: 519802b · View workflow run →

Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $2.82

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Oct 23, 2026
Merged via the queue into main with commit 151b860 Oct 23, 2026
32 checks passed
@ggallen
ggallen deleted the fullsend-managed-config-marker branch October 23, 2026 16:47
@fullsend-ai-retro

fullsend-ai-retro Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 4:49 PM UTC · Completed 4:56 PM UTC

Commit: 519802b · View workflow run →

Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $2.54

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open PRs/MRs.

Posted by fullsend post-review check

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #62 (fleet-manifest adoption marker)

Outcome: A human authored this 2-line change, which adds a comment-only marker to .fullsend/config.yaml. It merged cleanly. The review agent (run 38961820290; agents from fullsend-ai/agents@65c52d7) correctly approved it with no findings and rated the risk low (1/5). A human maintainer later approved the same patch. The review agent and the human reached the same verdict. The review raised no false positives and needed no rework. No new proposals are filed. Every improvement this retro found is already tracked, so the new evidence is listed below.

Timeline

  • Oct 16: PR opened at 4f55320. The review ran for about 6 minutes and cost $2.00: Opus orchestrator at high effort, Opus correctness and security sub-agents, Sonnet style and risk-assessment sub-agents. Most of the cost was about 1.3M cache-read tokens from loading the full pr-review skill and sub-agent prompts. The correctness, security and style sub-agents ran under the trivial scope (5 or fewer tool calls). The risk sub-agent still ran a full git-history analysis.
  • Oct 16: The bot's own approve and label events started 3 more dispatch runs. Each failed in Harness dispatch because the repo pinned a QualityFlow agent source that returned 404. A human diagnosed this in a PR comment, and chore: remove the QualityFlow harness from the fullsend config #63 removed the source. This was a config problem in the repo itself, now resolved.
  • Oct 23: The PR was rebased onto chore: remove the QualityFlow harness from the fullsend config #63 (02c2273), and then only the commit message was amended (519802b). The patch is byte-identical across all three heads. The first re-review was cancelled by the concurrency group. The second (run 39989393439) started a full re-review. The prior review had no findings, so re-review narrowing did not apply. The PR merged 17s after that review started, and the review kept running after the merge.

Evidence for existing issues (no new issues filed)

Not filed (low confidence)

  • The review run log reported Turns: 23 and then Turns: 2, and metrics.json reported num_turns: 2. This may be a turn-accounting mismatch, but one run is not enough evidence to file it. Worth watching in future retros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/low PR risk: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants