Skip to content

chore: remove the QualityFlow harness from the fullsend config - #63

Merged
waynesun09 merged 1 commit into
mainfrom
remove-qualityflow
Oct 17, 2026
Merged

waynesun09 merged 1 commit into
mainfrom
remove-qualityflow

Conversation

@waynesun09

Copy link
Copy Markdown
Member

The pinned QualityFlow source (qualityflow-fullsend@b26c947e) no longer resolves: harness/qualityflow.yaml points at qualityflow/agents/qualityflow.md, which 404s at that commit, so the harness fails to load agents on every fullsend event here (see the Harness dispatch failure on #62).

This removes the remote agent source and its allowed_remote_resources prefix. The repository falls back to the fleet default agents.

The experiments entry in the fleet manifest (fullsend-ai/.fullsend repos.yaml) loses the same two keys in a companion PR, so the next sync does not re-add them. Independent of #62, which only adds the managed-file marker; the two apply cleanly in either order.

The pinned QualityFlow source (qualityflow-fullsend@b26c947e) no longer
resolves: harness/qualityflow.yaml references qualityflow/agents/qualityflow.md,
which returns 404 at that commit, so the harness fails to load agents on
every fullsend event in this repository. Drop the remote agent source and
its allowed_remote_resources prefix; the repository falls back to the
fleet default agents. The matching entry is removed from the fleet
manifest in fullsend-ai/.fullsend so a sync does not re-add it.

Assisted-by: Claude
Signed-off-by: Wayne Sun <1912684+waynesun09@users.noreply.github.com>
@waynesun09
waynesun09 requested a review from a team October 16, 2026 23:56
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove broken QualityFlow harness from Fullsend configuration

⚙️ Configuration changes 🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Remove the pinned QualityFlow agent source that fails to load on Fullsend events.
• Remove its remote-resource allowance so this repository uses fleet default agents.
Diagram

graph TD
  Config["Repo config"] -->|configures| Runtime["Fullsend runtime"] -->|uses| Defaults["Fleet default agents"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Repin a working QualityFlow harness
  • ➕ Preserves repository-specific QualityFlow agents.
  • ➖ Retains a remote dependency and its resource allowance.
  • ➖ Requires locating and maintaining a working pinned source.

Recommendation: Removing the broken source is appropriate if fleet default agents meet this repository's needs. Repinning is worthwhile only if its QualityFlow-specific behavior is required.

Files changed (1) +0 / -4

Other (1) +0 / -4
config.yamlRemove the QualityFlow agent source and remote allowance +0/-4

Remove the QualityFlow agent source and remote allowance

• Deletes the pinned remote agent source and its allowed-resource prefix. The remaining repository configuration leaves agent selection to the fleet defaults.

.fullsend/config.yaml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can pick a display mode instead of tweaking every Display option by hand

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:58 PM UTC · Completed 12:05 AM UTC

Commit: d3170ed · View workflow run →

Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $2.63

waynesun09 added a commit to fullsend-ai/.fullsend that referenced this pull request Oct 16, 2026
#189)

fullsend-ai/experiments#63 removes the QualityFlow agent source and its
allowed_remote_resources prefix from the repository config because the
pinned source (qualityflow-fullsend@b26c947e) no longer resolves and the
harness fails to load agents on every event there. Remove the same two
keys from the manifest entry so the next sync converges to the same
state instead of re-adding them. The entry keeps its org-wide
create_issues target.

Assisted-by: Claude

Signed-off-by: Wayne Sun <1912684+waynesun09@users.noreply.github.com>
Co-authored-by: Wayne Sun <1912684+waynesun09@users.noreply.github.com>
@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Oct 17, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: low (1/5)

Details

Single 4-line config-only deletion with no security sensitivity, no protected paths, and no CI impact; minor multi-author contention and moderate file age raise Tier 2 slightly but the composite (1.13×0.62 + 1.57×0.38 ≈ 1.30) rounds to 1.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 17, 2026
@waynesun09
waynesun09 added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit 09c2dbc Oct 17, 2026
38 of 42 checks passed
@waynesun09
waynesun09 deleted the remove-qualityflow branch October 17, 2026 12:38
@fullsend-ai-retro

fullsend-ai-retro Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 12:40 PM UTC · Completed 12:52 PM UTC

Commit: d3170ed · View workflow run →

Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $3.55

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #63 (remove QualityFlow harness)

Outcome: went well. A human opened this 4-line config deletion. The fullsend review agent approved it (risk 1/5, no findings) in about 9 min, and the maintainer merged it about 12h later. No rework, and the review made the right call. Agents repo, from the review run log: fullsend-ai/agents@65c52d7.

Root cause of the broken harness (found during this retro):

  • The QualityFlow pin b26c947e never worked. At that commit, qualityflow/ is a git submodule, and raw.githubusercontent.com doesn't serve submodule contents, so qualityflow/agents/qualityflow.md always returned 404.
  • Until fullsend PR #7351 (Sept 17) this was a silent skip. That PR made zero loaded agents fatal.
  • Events from read-only users are rejected before any agents load, so the failure stayed hidden until the first event from a user with write access (Oct 15).
  • pull_request_target reads config from the base branch, so this PR's own runs still showed a red Harness dispatch check.

Evidence for existing issues (no new proposal filed for these):

  • agents#1533, #301, fullsend#8135: the review ran 6 sub-agents plus the challenger, with about 60k characters of sub-agent prompts, for a 4-line YAML deletion ($2.63; PR chore: mark .fullsend/config.yaml as managed by the fleet manifest #62's 2-line change cost $2.00). agents#1533's risk-score narrowing would have cut this.
  • fullsend#3726, #4766: harness dispatch failed on every run triggered by a user with write access from Oct 15, with no alert. A human diagnosed it by hand on chore: mark .fullsend/config.yaml as managed by the fleet manifest #62.
  • agents#895, fullsend#2380: the review didn't check the companion PR in fullsend-ai/.fullsend or the 404 claim. It said it "couldn't confirm" both, though the failing job in the same run showed the 404.
  • fullsend#6933: the cache write was denied again, so the CLI was rebuilt from source in every job (about 36s).
  • agents#1322, fullsend#7565: the log says agents were fetched at a pinned SHA but resolved from @main.

Housekeeping: experiments#55 and PR #56 (filed Aug 22 for this same 404) are still open. This PR resolves them, so they can probably be closed.

One new proposal: check remote agent sources on PRs that change .fullsend/config.yaml. Fleet dispatch never runs a config PR's own config, so the broken pin went unnoticed for 2 months.

Proposals filed

ggallen pushed a commit that referenced this pull request Oct 23, 2026
Adopts this file into fullsend-ai/.fullsend/repos.yaml management (ADR 0122):
the marker is the only change here, so the next fleet sync can rewrite the
file to the manifest's rendering instead of stopping on "adoption required".
Effective configuration change after adoption: gains the six fleet agents and status reactions (this repository ran code defaults). The broken QualityFlow source was removed separately in #63.

Assisted-by: Claude
Signed-off-by: Wayne Sun <1912684+waynesun09@users.noreply.github.com>
Signed-off-by: Greg Allen <gallen@redhat.com>
Signed-off-by: Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/low PR risk: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant