Repository navigation
chore(skills): add user forum What's New recap skill - #6314
Conversation
|
🤖 Finished Review · ✅ Success · Started 11:10 AM UTC · Completed 11:27 AM UTC Commit: |
PR Summary by QodoAdd user forum What's New recap skill
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsHigh
Low
Next steps:
Previous runReviewFindingsHigh
Medium
Low
Next steps:
Previous run (2)ReviewFindingsHigh
Low
Next steps:
Previous run (3)ReviewFindingsHigh
Low
Next steps:
Previous run (4)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (5)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (6)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (7)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (8)ReviewFindingsMedium
Low
Previous run (9)ReviewFindingsHigh
Low
Next steps:
Previous run (10)ReviewFindingsHigh
Low
Next steps:
Previous run (11)ReviewFindingsHigh
Low
Next steps:
Previous run (12)ReviewFindingsHigh
Low
Labels: PR adds a new contributor skill under skills/ Next steps:
|
|
Re: protected-path finding — this PR intentionally adds a new contributor skill under |
|
🤖 Review · ❌ Terminated · Started 11:38 AM UTC · Ended 11:53 AM UTC Commit: |
|
This sounds as reease notes to me, should we generalize this to "from X date to Y date", "from X commit to Y commit"? |
|
🤖 Finished Review · ✅ Success · Started 11:38 AM UTC · Completed 11:53 AM UTC Commit: |
|
🤖 Finished Review · ✅ Success · Started 12:56 PM UTC · Completed 1:11 PM UTC Commit: |
waynesun09
left a comment
There was a problem hiding this comment.
Review-only sweep: 7 inline findings (1 high, 6 medium) on the gather script and SKILL.md. No approval or change request implied.
|
@rh-hemartin Keeping this skill scoped to the user-forum What's New talk track on purpose — it is deliberately not release notes (ranking, talkable filters, clickable examples, Released vs On main for a 4–6 minute verbal pass).
|
|
🤖 Finished Review · ✅ Success · Started 11:01 PM UTC · Completed 11:18 PM UTC Commit: |
waynesun09
left a comment
There was a problem hiding this comment.
Review-only sweep: 3 inline findings (3 medium) on gather.py and SKILL.md frontmatter. No approval or change request implied.
436dd1f to
6a0cfb0
Compare
|
🤖 Finished Review · ✅ Success · Started 7:21 PM UTC · Completed 7:39 PM UTC Commit: |
Superseded by updated review
waynesun09
left a comment
There was a problem hiding this comment.
Review-only sweep: 1 high finding in the PR description (below) plus 2 medium inline findings on SKILL.md. No approval or change request implied.
[HIGH] Fixes #6353 links an unrelated open issue and will auto-close it on merge
The PR body still reads Fixes #6353 at head 6a0cfb07 (re-verified against the PR body via the API). That issue is "Resolve skill definition inconsistency between released version and main branch" — an open, scribe-generated issue about drift between the released (deployed) agent skill definition and its main-branch counterpart, with acceptance criteria "Identify the specific skill definition that has diverged", "Reconcile the released version and main branch version", and adding a CI drift check.
This PR adds a brand-new forum-host recap skill and addresses none of those criteria, so merging would silently close unrelated tracked work.
Context that makes this look like a mis-fill rather than a deliberate link: the review bot raised a protected-path finding about the missing linked issue, the reply was "No linked issue because it is net-new host documentation + a gather helper... Happy to link a tracking issue if maintainers want one", and an unrelated issue number appeared in the body afterwards. I also searched open and closed issues for a forum-recap / user-forum-skill tracker (gh search issues --repo fullsend-ai/fullsend "forum What's New recap" and "user forum skill") and found none, so there is no correct issue to swap in.
Suggested fix: Drop the Fixes #6353 line, or downgrade it to a non-closing reference (Refs #6353) only if there is a real relationship. Then either file a tracking issue for the forum recap skill and link that, or state in the body that the work is intentionally untracked (matching the earlier reply to the protected-path finding).
Require UTF-8 list JSON from fetch outputs (non-zero exit on corrupt payloads), filter gh search to --base main, and treat #forum-fullsend-ai as host-supplied input. Signed-off-by: Adam Scerra <ascerra@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…e claim Emit second-precision Z timestamps for gh search --merged-at, and require running gather from a fullsend checkout so allowed-tools path grants match. Signed-off-by: Adam Scerra <ascerra@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Chai claimed these fixes without pushing. Add --slurp (+ flatten) for paginated releases, emit until_clamped for future --until clamps, and drop the non-existent timezone-data package name. Signed-off-by: Adam Scerra <ascerra@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Reject ISO week-dates, add gh subprocess timeouts, and use a half-open lower bound so consecutive Tuesday windows do not overlap. Signed-off-by: Adam Scerra <ascerra@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Hosts rotate and run gather fresh locally — do not chain window_end_utc. Correct the half-open overclaim and reword to_z docstring to describe our emit choice rather than unverified GitHub rejection of fractional seconds. Signed-off-by: Adam Scerra <ascerra@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the public auth-walled Google Doc URL, monkeypatch fetch_into subprocess argv, and error clearly when the window has not started. Signed-off-by: Adam Scerra <ascerra@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Adam Scerra <ascerra@redhat.com>
8feb5bb to
dd41a9f
Compare
Signed-off-by: Adam Scerra <ascerra@redhat.com>
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 3:03 PM UTC · Completed 3:18 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.90 |
waynesun09
left a comment
There was a problem hiding this comment.
Re-review at 0ed98435. I re-checked every finding I raised across the earlier rounds against the code at head rather than relying on the resolved marks, and ran the skill for real. All of them hold up. No medium-or-higher findings this round; one non-blocking low inline.
Verified at head:
| Earlier finding | State at 0ed98435 |
|---|---|
gh search prs had no --base filter |
fixed — gather.py:278-279 |
gh api --paginate without --slurp produced concatenated arrays |
fixed — --slurp at gather.py:260 plus flatten_gh_slurp() (134) which also handles the flat and empty-page shapes |
no timeout on gh subprocesses |
fixed — GH_TIMEOUT_SEC (43) applied to both calls (265, 291), mapped to exit 1 in main (386) |
| one cross-repo release cutoff | fixed — per-repo cutoffs (209-210), surfaced as the release_cutoff_utc map |
| prereleases could set the cutoff | fixed — prereleases stay as candidates but never enter times (191-196) |
| inclusive window boundary double-counted the shared 08:00 ET instant | fixed — half-open in in_window (131); the residual late-run band is documented in window_bounds (101-104) and SKILL.md, with host dedupe as the mitigation |
| clamp-to-now inverted the window with a misleading two-identical-dates error | fixed — separate "window has not started yet" (113) and "until before since" (117) paths |
| search-truncation warning was stderr-only | fixed — search_truncated is now in the JSON (321, 326) as well as stderr |
| Step 6 assembled HTML from untrusted PR titles with no escaping requirement | fixed — explicit escaping constraint at SKILL.md:255-257 |
opener grants carried a dead :* suffix |
fixed. Re-checked against the current permissions doc: * "stands in for whatever text is in its place", and the space-before-* rule that broke the old form does not apply here because the * is attached to the prefix (the doc's own Bash(ls*) matches lsof case). Bash(xdg-open /tmp/fullsend-whats-new-*) does match xdg-open /tmp/fullsend-whats-new-2026-09-09.html. |
| ~130 lines of Python in a heredoc escaped every lint and test gate | fixed, and the gate is real, not nominal: ruff.toml selects E,F,I,W,UP,B,SIM over ., Makefile:201 runs gather_test.py under script-test, and .github/workflows/lint.yml:58 runs make script-test. The # noqa: UP036 on the version guard (19) is consistent with target-version = "py312". |
fetch_into was "tested" by grepping its own source |
fixed — test_fetch_into_argv_and_timeout patches gather.subprocess.run and asserts argv and timeout for real |
Executed checks:
python3 skills/user-forum-whats-new/scripts/gather_test.py— 34 tests, OK.- Live end-to-end run:
bash skills/user-forum-whats-new/scripts/gather.sh --since 2026-09-02 --until 2026-09-09— exit 0, clean stderr. Window resolved to2026-09-02T12:00:00Z .. 2026-09-09T15:30:47Zwithuntil_clamped: true, which is the correct 08:00 EDT to now mapping. Per-repo cutoffs came back distinct (fullsend20:39:34Z,agents20:39:54Z), and the split was 54 released / 48 on main, with the boundary landing where the v0.42.0 publish times say it should. - Sanity-checked the classification heuristic against real data: the last 25
fullsendreleases and last 10agentsreleases are alltarget_commitish=main, non-draft and non-prerelease. So the max-in-window-publish-time cutoff is sound for this repo's actual cadence, and the draft/prerelease branches are defensive rather than load-bearing. Worth knowing that the one scenario that would mislabel — a patch release cut from a non-main branch mid-window — has no precedent in either repo's history, so I am not raising it.
The two open threads are both bot lows. The draft-release one is accurate: classify() skips draft releases at line 186 and no test covers that branch — it is the only untested branch in the function, and defensive-only given the data above.
waynesun09
left a comment
There was a problem hiding this comment.
Approving at 0ed98435.
Every finding I raised across the earlier rounds is verified fixed at this head — details and the executed checks are in my re-review comment on this commit (34/34 unit tests, a clean live end-to-end gather.sh run, and confirmation that make script-test actually runs gather_test.py in CI).
The one inline item I left is an explicitly non-blocking low about scoping the Write grant; take it or soften the prose, either is fine by me. Thanks for the patience across the rounds — the permission scoping and the window math both ended up in good shape.
|
🤖 Finished Retro · ✅ Success · Started 8:04 AM UTC · Completed 8:22 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $3.08 |
|
PR #6314 (user-forum-whats-new skill) took ~22 days and 13 review-agent rounds to merge, but the delay was almost entirely human-availability silence (two gaps of 7 and 6.6 days), not agent turnaround (every review/fix run completed in 11-20 minutes). The review agent ( Evidence found for several already-open issues in fullsend-ai/agents / fullsend-ai/fullsend (no new issues filed for these - see linked issues):
Overall the human review (waynesun09's 8 sweeps plus a live tool execution before approving) was substantially more rigorous than the agent review for this PR's domain (timezone/API/pagination-heavy scripting) - this isn't a criticism of any individual approval, just a signal that this class of change currently needs a human safety net the agent can't yet provide. Proposals filed |
Summary
Adds a contributor skill for the weekly Fullsend user-forum What's New recap: gather shipped work, rank it, and produce a short talk track with clickable examples. Audience already has GitHub release notes; this is the 4–6 minute verbal pass, not a changelog dump.
Related Issue
None — intentionally untracked forum-host tooling. Do not auto-close unrelated issues on merge.
Changes
skills/user-forum-whats-new/SKILL.md— workflow, ranking bands, newness / experience / talkable filters, Released vs On main output, HTML-escaping requirements, and anti-patternsskills/user-forum-whats-new/scripts/gather.py— timezone-aware release/PR gathering, per-repo release cutoffs, strict date/window validation, truncation reporting, fail-closed JSON parsing, and boundedghcallsskills/user-forum-whats-new/scripts/gather.sh— repo-root wrapperskills/user-forum-whats-new/scripts/gather_test.py— offline unit tests for windows, classification, fetch argv/timeouts, parsing, truncation, and error pathsMakefile— runs the new gather tests throughscript-testThis is intentionally org forum-host tooling, not a sandbox agent skill, so it is not cross-linked from BYOA/customizing-with-skills guides. The skill runs from a fullsend checkout;
.cursor/skillsand.claude/skillssymlinks make it discoverable.Testing
pre-commit runon staged files (ruff, ty, bandit, shellcheck, markdown links, secrets)python3 skills/user-forum-whats-new/scripts/gather_test.py(34 tests)git diff --checkChecklist