Repository navigation
feat(adr-corner): add ADR pull request inventory - #7877
Conversation
PR Summary by QodoAdd /adr-corner inventory for open ADR pull requests
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
|
🤖 Finished Review · ✅ Success · Started 7:32 PM UTC · Completed 7:57 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $5.90 |
Code Review by Qodo
1.
|
Site previewPreview: https://690f39a9-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: elevated (3/5) DetailsLarge diff touching protected skill paths and Makefile, combined with high regression history and multi-author contention on touched files, produces an elevated risk score. Previous runRisk Assessment: elevated (3/5) DetailsElevated risk driven by a large diff (1,081 lines) touching protected skill paths and the shared Makefile, which exhibits high churn, regression history, and file coupling, offset by the largely additive nature of the new skill tooling and absence of dependency changes. Previous run (2)Risk Assessment: elevated (3/5) DetailsElevated risk driven by a large diff (1,037 lines) touching protected skill paths and the shared Makefile, which exhibits high churn, regression history, and file coupling, offset by the largely additive nature of the new skill tooling and absence of dependency changes. Previous run (3)Risk Assessment: elevated (3/5) DetailsElevated risk driven by a large diff (1,031 lines) touching protected skill paths and the shared Makefile, which exhibits high churn, regression history, and file coupling, offset by the largely additive nature of the new skill tooling and absence of dependency changes. Previous run (4)Risk Assessment: elevated (3/5) DetailsElevated risk driven by a large diff (836 lines) touching protected skill paths and the shared Makefile, which shows high recent churn/regression history in this repo, offset by the fully additive, read-only, well-tested nature of the new skill tooling and no CI/dependency changes of its own. |
ReviewFindingsHigh
Medium
Low
Labels: The PR introduces a new user-facing skill and slash command, matching the skills component and feature labels. Next steps:
Previous runReviewFindingsHigh
Low
Dimensions that completed cleanly
Not observed in current diff (independently re-verified by the docs-currency sub-agent only; correctness could not re-verify its own prior low-severity findings this round — see above): the SKILL.md slash-command link and author-evidence-source scoping issues from earlier rounds both appear addressed in the current head. Next steps:
Previous run (2)ReviewFindingsHigh
Low
Not observed in current diff: the previously flagged Next steps:
Previous run (3)ReviewFindingsHigh
Low
Next steps:
Previous run (4)ReviewFindingsHigh
Medium
Low
Next steps:
|
af8c5cd to
235295d
Compare
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 8:02 PM UTC · Completed 8:17 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $3.74 |
|
Protected-path review gate: this PR was created at Barak Korren's explicit request in the task conversation, which is the authorization trail available here. No GitHub issue was supplied or created. The repository's required human maintainer approval remains necessary before merge; this gate is intentionally left for that approval. |
|
🤖 Finished Review · ✅ Success · Started 8:54 PM UTC · Completed 9:11 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $3.93 |
Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (gpt-5.6-sol)
Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (gpt-5.6-sol)
Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (gpt-5.6-sol)
Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (gpt-5.6-sol)
Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (gpt-5.6-sol)
a2fe279 to
57ba9c6
Compare
|
🤖 Finished Review · ✅ Success · Started 6:08 AM UTC · Completed 6:46 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.17 |
Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (gpt-5.6-sol)
|
🤖 Finished Review · ✅ Success · Started 8:07 AM UTC · Completed 8:23 AM UTC Commit: Runtime: pi · Model: openai/gpt-6.1-sol → gpt-6.1-sol · Effort: high · Cost: $2.10 |
| text = re.sub(r"<!--.*?-->", " ", text, flags=re.DOTALL) | ||
| text = re.sub(r"```.*?```", " ", text, flags=re.DOTALL) | ||
| text = MARKDOWN_LINK_RE.sub(r"\1", text) | ||
| text = re.sub(r"[#>*`_]", " ", text) |
There was a problem hiding this comment.
[medium] logic-error
Markdown normalization removes literal technical characters everywhere, including inside inline code, corrupting both ADR summaries and discussion excerpts. For example, created_at > watermark becomes created at watermark, and retries >= 3 becomes retries = 3. This changes the meaning of reported conditions rather than merely removing formatting.
Suggested fix: Remove Markdown delimiters contextually while preserving inline-code contents, comparison operators, and identifier underscores. Restrict blockquote/header stripping to their structural positions and add regression tests covering technical expressions in summaries and discussions.
| for line in lines: | ||
| heading = re.match(r"^#{1,6}\s+(.+?)\s*$", line) | ||
| if heading: | ||
| current = normalize_text(heading.group(1)).lower() |
There was a problem hiding this comment.
[medium] logic-error
Every heading changes the active section, including subsections of Decision. An ADR containing ## Decision followed immediately by ### Backend therefore has an empty Decision section, causing the helper to fall back to Context. If Context says “Keep the old backend” and the Decision subsection says “Replace it with the new backend”, the summary reports the opposite decision.
Suggested fix: Track heading levels and include nested subsection content in its enclosing Decision section until an equal-or-higher-level heading appears. Add a regression test with an immediately nested Decision subsection and conflicting Context text.
|
|
||
| def escape_markdown_cell(value: str) -> str: | ||
| """Escape Markdown table syntax without allowing backslashes to escape pipes.""" | ||
| return value.replace("\\", "\\\\").replace("|", "\\|").replace("\n", " ") |
There was a problem hiding this comment.
[medium] injection-vuln
The Markdown encoder escapes pipes, backslashes, and newlines but leaves active Markdown and HTML in contributor-controlled ADR paths. A path such as docs/ADRs/<img src=https://attacker.example/pixel>.md passes ADR-path classification and is emitted without literal-text encoding. In a renderer that permits HTML images, displaying the inventory could trigger an unsolicited external request. The filename-derived summary prefix is also emitted without literal-text encoding; actual rendering and network behavior were not verified.
Suggested fix: Encode untrusted cell content as literal text, including filenames and summary prefixes. Build the intentional PR link and discussion separators separately from escaped data, and add tests for HTML tags, Markdown images, and entity-encoded URLs in ADR paths.
Summary
/adr-cornercommand for open PRs that change ADRsValidation
Generated with Codex.