fix(#7118): mark admin install as deprecated in cobra by gklein · Pull Request #8451 · fullsend-ai/fullsend

gklein · 2026-10-15T10:11:55Z

Summary

fullsend admin install is documented as deprecated, but the command had no
Cobra deprecation marker, so users never saw a warning. This adds one that
points to the recommended single-repo setup command for each forge, and
updates the docs that still described admin install as a current entry point.

Related Issue

Closes #7118

Changes

internal/cli/admin.go: set Deprecated on the install command and mark
Short as "(deprecated)". Behavior, flags, and exit codes are unchanged.
internal/cli/admin_test.go: test that the message names the replacement
commands (inference provision, github setup, mint add-role,
repos install --forge gitlab), and that running the command prints the warning.
docs/guides/dev/cli-internals.md: mark install as deprecated in the
command tree (and fix its argument to <owner/repo>); add the GitLab
replacement to the deprecation note.
Docs and skill updates from review feedback (see below).

The warning, printed on stderr before the command runs:

Command "install" is deprecated, use 'fullsend inference provision' + 'fullsend github setup <owner/repo>' (GitHub; create apps with 'fullsend mint add-role') or 'fullsend repos install <group/project> --forge gitlab' (GitLab) instead

Note on the issue comment: the suggested fullsend gitlab setup doesn't
exist. GitLab installs use fullsend repos install --forge gitlab (see
configuring-gitlab.md and repo-management.md), and the GitLab flow doesn't
use fullsend inference provision. For GitHub, the message names the split
flow the comment asked for: fullsend inference provision + fullsend github setup.

Per-org scope (ADR 0044): the <org|owner/repo> → <owner/repo> edit in
the command tree only reflects the per-org removal already done under
ADR 0044 / #8064.
This PR doesn't change org-target handling; admin install already rejected
bare org targets.

GitHub App creation: admin install still creates the apps for all roles
in one run (--public, --app-set). The supported per-role alternative is
fullsend mint add-role <role> --project <gcp-project> --org <org> on a deployed mint, which uses the
same app-setup code and also supports --public and --app-set. The runtime
warning points to fullsend mint add-role for app creation.

User-visible effects:

A one-line warning on stderr; stdout is unchanged.
install no longer appears in fullsend admin --help (standard Cobra
behavior for deprecated commands, same as post-comment). It still runs.

Addresses review feedback

Source	Finding	Resolution
fullsend review (Medium)	`mint-administration.md` step 4 conflicts with the warning	Added note: `admin install` warns but still creates every role's app in one run; `mint add-role --project … --org …` is the per-role alternative
fullsend review	`advanced-setup.md:40` lacks a deprecation caveat	Linked to the "Deprecated: all-in-one admin install" section
fullsend review	`contributing/documentation.md:63` calls it supported	Now "deprecated but still works (it still creates every role's GitHub App in one run)"
fullsend review	`e2e-testing.md:72,104` cite nonexistent `fullsend admin --mint-url`	Now `fullsend github setup --mint-url`
fullsend review	`mint-enroll` skill lines 233, 241	Now `github setup` (it sets `FULLSEND_MINT_URL`)
fullsend review	`mint-enroll` skill lines 100, 105, 225 (app creation)	Lines 100 and 226 now list `mint add-role --project … --org …` alongside the deprecated `admin install`; line 105 (installing existing apps) unchanged
fullsend review	`architecture.md:56` lists it as current	Marked "(deprecated)"
fullsend review (2nd run)	`incorrect-doc`: docs overstated that `admin install` is required to create GitHub Apps	Corrected in `mint-administration.md`, `advanced-setup.md:196`, `mint-enroll` skill and `documentation.md`: `mint add-role` uses the same `runAppSetup` and supports `--public`/`--app-set`, one role per run (`5945edf`)
fullsend review (3rd run)	`contributing/go-code.md:567` cites nonexistent `fullsend admin --mint-url`	Now `fullsend github setup --mint-url` (`a2b33d5`)
Review (waynesun09)	GitHub part of the warning names only `github setup`, skipping inference provisioning and app creation	Warning now names `inference provision` + `github setup` and `mint add-role` for apps; test asserts both; `cli-internals.md` tree comment updated (`9c0e47d`)
fullsend review (2nd run)	`protected-path`: `skills/mint-enroll/SKILL.md` changed	No code change; needs human approval as usual
Qodo #2	`advanced-setup.md:196` omits GitLab	Added `repos install --forge gitlab` pointer and the `mint add-role` / `admin install` app-creation options
Qodo #3	ADR 0044 context missing	Added the per-org scope note above
Qodo #4	`Short` names only GitHub	`Short` now just says "(deprecated)"; replacements live only in `Deprecated`
Qodo #1	No `make e2e-test` evidence	Not applicable — `make e2e-test` and the admin e2e suite no longer exist

Testing

make lint passes (stage changes first, then run)
Tests added/updated for new or modified logic

go test ./internal/cli/ -run 'Admin|Install' passes; patch coverage on
newInstallCmd is 96.5%. I also ran admin install acme/x --dry-run to
confirm the warning goes to stderr only.

🤖 Generated with Claude Code

The CLI internals guide documents `fullsend admin install` as deprecated, but the command had no Cobra deprecation marker, so users never saw a warning. Point users to the docs' single-repo setup command per forge: `fullsend github setup` for GitHub and `fullsend repos install --forge gitlab` for GitLab (there is no `fullsend gitlab setup`). Closes fullsend-ai#7118 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gil Klein <13672+gklein@users.noreply.github.com>

github-actions · 2026-10-15T10:12:07Z

E2E tests did not run

E2E tests run automatically for pull requests authored by users with write access or higher.

For other contributors, a maintainer with write access must add the ok-to-test label after the latest push.

See E2E testing guide for details.

qodo-code-review · 2026-10-15T10:12:35Z

PR Summary by Qodo

Deprecate admin install with forge-specific replacement guidance

🐞 Bug fix 🧪 Tests 📝 Documentation 🕐 Less than 10 minutes

AI Description

• Mark fullsend admin install as deprecated so Cobra warns users before execution.
• Direct GitHub and GitLab users to their respective single-repository installation commands.
• Test the warning and align the CLI internals guide with the command's deprecated status.

Diagram

graph TD
  A["Admin install invocation"] --> B["Cobra command"] --> C["Stderr warning"] --> D["Existing install flow"]
  C -.-> E["GitHub setup"]
  C -.-> F["GitLab repos install"]

High-Level Assessment

Use Cobra's native deprecation marker, consistent with the existing deprecated post-comment command. A custom warning would duplicate framework behavior without improving this change.

Files changed (3) +25 / -4

Bug fix (1) +3 / -2

admin.goAdd Cobra deprecation warning to admin install +3/-2

Add Cobra deprecation warning to admin install

• Sets 'Deprecated' with GitHub and GitLab replacement commands and notes deprecation in the short help text. The command's installation logic and flags are unchanged.

internal/cli/admin.go

Tests (1) +19 / -0

admin_test.goTest admin install deprecation guidance and warning +19/-0

Test admin install deprecation guidance and warning
• Checks that the deprecation message names both forge-specific replacements and that executing the command emits Cobra's warning.
internal/cli/admin_test.go

Documentation (1) +3 / -2

cli-internals.mdClarify admin install deprecation and GitLab replacement +3/-2

Clarify admin install deprecation and GitLab replacement
• Marks install as deprecated in the command tree, corrects its argument to '<owner/repo>', and names the GitLab replacement in the deprecation note.
docs/guides/dev/cli-internals.md

fullsend-ai-review · 2026-10-15T10:14:01Z

🤖 Finished Review · ✅ Success · Started 10:14 AM UTC · Completed 10:23 AM UTC

Commit: 76598c4 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.77

qodo-code-review · 2026-10-15T10:14:30Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. ~~Admin installs lack end-to-end coverage~~ ✗ Dismissed

Description

newInstallCmd changes the behavior of an internal/cli command, but the PR provides no evidence
that its required end-to-end suite was run and passed. The repository defines only behaviour-test,
while the CI workflow invokes that target rather than make e2e-test, so this change lacks the
mandated pre-merge end-to-end gate.

Code

internal/cli/admin.go[R243-245]

+		Use:        "install <owner/repo>",
+		Short:      "Install fullsend in a repository (deprecated: use 'fullsend github setup')",
+		Deprecated: "use 'fullsend github setup <owner/repo>' (GitHub) or 'fullsend repos install <group/project> --forge gitlab' (GitLab) instead",

Evidence
The changed command is under internal/cli, which activates the end-to-end testing requirement. The
repository has no make e2e-test invocation, while .github/workflows/e2e.yml runs `make
behaviour-test and the Makefile defines behaviour-test` as the available target.
Rule 1062051: Run end-to-end tests for critical internal modules before merge
internal/cli/admin.go[243-245]
.github/workflows/e2e.yml[194-194]
Makefile[241-245]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR modifies an `internal/cli` command but does not provide evidence that `make e2e-test` was run and passed, and the repository's current CI workflow invokes `make behaviour-test` instead.

## Fix Focus Areas
- internal/cli/admin.go[243-245]
- .github/workflows/e2e.yml[194-194]
- Makefile[241-245]

## Recommended Fix
Run the repository's supported end-to-end target for this command and record the successful result in the PR checks or description. If `behaviour-test` intentionally replaces the obsolete `make e2e-test` target, update the compliance gate and CI documentation so the required `behaviour-test` job is explicitly recognized and enforced for `internal/cli` changes.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. ~~GitLab users get incomplete migration guidance~~ ✓ Resolved

Description

The command's Short text names only fullsend github setup even though the deprecation metadata
directs GitLab users to fullsend repos install --forge gitlab. Users who inspect the command
directly or generated help therefore miss the supported GitLab replacement.

Code

internal/cli/admin.go[244]

+		Short:      "Install fullsend in a repository (deprecated: use 'fullsend github setup')",

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

Issue description
The deprecated command's `Short` text mentions only the GitHub replacement, while GitLab users must use `fullsend repos install --forge gitlab`. Direct command help can therefore provide incomplete migration guidance.

Fix Focus Areas
- internal/cli/admin.go[244-244]

Recommended Fix
Update the `Short` text to mention both replacement flows, matching the GitHub and GitLab guidance already present in `Deprecated`. Keep the wording concise enough for Cobra help output and preserve the existing command behavior.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. ~~Deprecated org changes omit required context~~ ✓ Resolved

Description

newInstallCmd now rejects bare organization targets, and the command-tree documentation changes
the install argument from <org|owner/repo> to <owner/repo>. These edits touch deprecated
per-organization installation content, but the PR description does not identify that scope or
reference ADR 0044 as required for changes affecting that mode.

Code

internal/cli/admin.go[R243-245]

+		Use:        "install <owner/repo>",
+		Short:      "Install fullsend in a repository (deprecated: use 'fullsend github setup')",
+		Deprecated: "use 'fullsend github setup <owner/repo>' (GitHub) or 'fullsend repos install <group/project> --forge gitlab' (GitLab) instead",

Evidence
The changed command retains only the <owner/repo> form and the changed command tree removes
<org|owner/repo>, directly touching the former per-organization installation surface. ADR 0044
identifies per-organization installation as deprecated, and the checklist requires such changes to
explicitly reference ADR 0044 in the PR description.
Rule 2795055: Flag and avoid changes to deprecated per-org installation mode content (ADR 0044)
internal/cli/admin.go[243-245]
docs/guides/dev/cli-internals.md[10-10]
docs/ADRs/0044-deprecate-per-org-installation-mode.md[39-44]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The change removes the per-organization form of the admin install target and updates its documentation, but the PR description does not explicitly call out deprecated per-organization installation or ADR 0044.

## Fix Focus Areas
- internal/cli/admin.go[243-245]
- docs/guides/dev/cli-internals.md[10-10]

## Recommended Fix
Update the PR description or an appropriate code comment to state that the change touches deprecated per-organization installation behavior and references ADR 0044, while clarifying that per-repository installation remains the supported model.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

View medium (1)

4. ~~GitLab users miss the replacement~~ ✓ Resolved

Description

The admin install guidance in advanced-setup.md still recommends only inference provision plus
github setup and omits the GitLab replacement named by the new warning. Users following that guide
do not see the documented repos install --forge gitlab workflow, leaving the changed CLI guidance
inconsistent across the docs.

Code

internal/cli/admin.go[R244-245]

+		Short:      "Install fullsend in a repository (deprecated: use 'fullsend github setup')",
+		Deprecated: "use 'fullsend github setup <owner/repo>' (GitHub) or 'fullsend repos install <group/project> --forge gitlab' (GitLab) instead",

Evidence
The CLI change adds a deprecation message naming both forge-specific replacements, while the
existing infrastructure guide still directs users only to the GitHub replacement. The documentation
checklist requires user-facing CLI behavior and output changes to be reflected in referenced guides.
Rule 2748504: Update docs/ references when changing user-facing behavior
internal/cli/admin.go[244-245]
docs/guides/infrastructure/advanced-setup.md[194-196]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new deprecation message documents separate GitHub and GitLab replacements, but the infrastructure setup guide still documents only the GitHub replacement for `admin install`.

## Fix Focus Areas
- docs/guides/infrastructure/advanced-setup.md[194-196]
- internal/cli/admin.go[244-245]

## Recommended Fix
Update the deprecated admin-install section in `advanced-setup.md` to mention both replacement workflows, including `fullsend repos install <group/project> --forge gitlab`, and keep the examples consistent with the CLI warning.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Context sources

✅ Tickets: 🎫 Add a Cobra deprecation marker to `fullsend admin install`

✅ Compliance rules (platform): 89 rules

✅ Skills: 5 invoked

writing-user-docs

writing-adrs

check-patch-coverage

cutting-releases

adr-corner

✅ Cross-repo context — repo relationships

Review mode: Auto: 🚀 Fast: Localized Cobra deprecation marker with focused tests and no behavioral logic changes.

Tip of the day

💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

github-actions · 2026-10-15T10:16:51Z

Site preview

Preview: https://adf25d20-site.fullsend-ai.workers.dev

Commit: 8f92f9d3339237702d2a9137c0226132c23f0e5e

codecov · 2026-10-15T10:20:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

fullsend-ai-review · 2026-10-15T10:23:11Z

Risk Assessment: moderate (2/5)

Details

Small diff with well-scoped issue alignment, maintained at moderate risk due to a protected skill path edit, high recent churn, and co-commit coupling across touched CLI and documentation files.

Previous run

Risk Assessment: moderate (2/5)

Details

Small diff with well-scoped issue alignment, elevated to moderate risk by a protected skill path edit, high recent churn, and co-commit coupling across touched CLI and documentation files.

Previous run (2)

Risk Assessment: moderate (2/5)

Details

Small diff with well-scoped issue alignment, elevated to moderate risk by a protected skill path edit, high recent churn, and co-commit coupling across touched CLI and documentation files.

Previous run (3)

Risk Assessment: moderate (2/5)

Details

Small diff with well-scoped issue alignment, elevated to moderate risk by high recent churn and co-commit coupling across touched CLI and documentation files alongside a protected skill path edit.

Previous run (4)