Repository navigation
docs(#8452): remove stale admin subcommands from CLI command tree - #8453
Merged
Merged
Conversation
The command tree in docs/guides/dev/cli-internals.md still listed `admin uninstall`, `analyze`, `enable repos`, and `disable repos`, which were removed with the per-org CLI commands (#8064). The admin command now registers only `install` and `foreign`. - Drop the four removed subcommands from the tree. - Add the `foreign` subtree (`allow`, `list`, `revoke`), which was registered but missing from the tree. - Update the `admin` header comment to match its cobra Short text. - Fix the Key Source Files row for admin.go, which named the same removed subcommands and had a stale line count. The `install` line is left unchanged; PR #8451 edits it separately. Verified against `go run ./cmd/fullsend admin --help` and `admin foreign --help`. pre-commit could not fetch remote hook repos in the sandbox, so the applicable hooks (pre-commit-hooks v6.0.0, gitleaks, lint-docs-links, lint-broken-symlinks, lychee) were run directly and passed. Closes #8452 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 10:31 AM UTC · Completed 10:37 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.87 |
Site previewPreview: https://660c6cb9-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsSmall documentation-only fix by a bot with low metadata risk, elevated to moderate risk by high recent churn and multi-author contention on the modified CLI internals guide. |
|
Looks good to me |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the CLI command tree in
docs/guides/dev/cli-internals.mdso theadminsection lists only the subcommands the CLI actually registers. Four of the subcommands it listed were removed with the per-org CLI commands (#8064).Related Issue
#8452
Changes
admin uninstall,admin analyze,admin enable repos, andadmin disable reposfrom the command tree.admin foreignsubtree (allow,list,revoke). It is registered ininternal/cli/foreign.gobut was missing from the tree.adminheader comment to match its cobraShorttext ("Manage fullsend installation for a repository").internal/cli/admin.go. It named the same removed subcommands and had a stale line count (~2415, now ~1400).installline unchanged, since open PR fix(#7118): mark admin install as deprecated in cobra #8451 edits that line.Testing
go run ./cmd/fullsend admin --helpandgo run ./cmd/fullsend admin foreign --help. They match.go test ./internal/cli/ -run 'Admin|Foreign'passes.docs/guidesanddocs/cliforadmin uninstall|analyze|enable|disable: no matches left. ADRs were not touched because they are immutable.pre-commitcould not fetch remote hook repos in the sandbox (TLS error), so I ran the hooks that apply to this file directly: pre-commit-hooks v6.0.0 (end-of-file, trailing whitespace, private key, merge conflict, mixed line endings, large files), gitleaks,lint-docs-links,lint-broken-symlinks, and lychee. All passed.🤖 Generated with Claude Code
Closes #8452
Post-script verification
agent/8452-fix-admin-command-tree)3b5e19f49cb2573fdf95c7cf67d0ffa11674674a..HEAD)