Skip to content

docs(#8452): remove stale admin subcommands from CLI command tree - #8453

Merged
waynesun09 merged 1 commit into
mainfrom
agent/8452-fix-admin-command-tree
Oct 15, 2026
Merged

waynesun09 merged 1 commit into
mainfrom
agent/8452-fix-admin-command-tree

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Updates the CLI command tree in docs/guides/dev/cli-internals.md so the admin section lists only the subcommands the CLI actually registers. Four of the subcommands it listed were removed with the per-org CLI commands (#8064).

Related Issue

#8452

Changes

  • Removed admin uninstall, admin analyze, admin enable repos, and admin disable repos from the command tree.
  • Added the admin foreign subtree (allow, list, revoke). It is registered in internal/cli/foreign.go but was missing from the tree.
  • Updated the admin header comment to match its cobra Short text ("Manage fullsend installation for a repository").
  • Fixed the Key Source Files row for internal/cli/admin.go. It named the same removed subcommands and had a stale line count (~2415, now ~1400).
  • Left the install line unchanged, since open PR fix(#7118): mark admin install as deprecated in cobra #8451 edits that line.

Testing

  • Checked the new tree against go run ./cmd/fullsend admin --help and go run ./cmd/fullsend admin foreign --help. They match.
  • go test ./internal/cli/ -run 'Admin|Foreign' passes.
  • Searched docs/guides and docs/cli for admin uninstall|analyze|enable|disable: no matches left. ADRs were not touched because they are immutable.
  • pre-commit could not fetch remote hook repos in the sandbox (TLS error), so I ran the hooks that apply to this file directly: pre-commit-hooks v6.0.0 (end-of-file, trailing whitespace, private key, merge conflict, mixed line endings, large files), gitleaks, lint-docs-links, lint-broken-symlinks, and lychee. All passed.

🤖 Generated with Claude Code


Closes #8452

Post-script verification

  • Branch is not main/master (agent/8452-fix-admin-command-tree)
  • Secret scan passed (gitleaks — 3b5e19f49cb2573fdf95c7cf67d0ffa11674674a..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

The command tree in docs/guides/dev/cli-internals.md still listed
`admin uninstall`, `analyze`, `enable repos`, and `disable repos`,
which were removed with the per-org CLI commands (#8064). The admin
command now registers only `install` and `foreign`.

- Drop the four removed subcommands from the tree.
- Add the `foreign` subtree (`allow`, `list`, `revoke`), which was
  registered but missing from the tree.
- Update the `admin` header comment to match its cobra Short text.
- Fix the Key Source Files row for admin.go, which named the same
  removed subcommands and had a stale line count.

The `install` line is left unchanged; PR #8451 edits it separately.

Verified against `go run ./cmd/fullsend admin --help` and
`admin foreign --help`. pre-commit could not fetch remote hook repos
in the sandbox, so the applicable hooks (pre-commit-hooks v6.0.0,
gitleaks, lint-docs-links, lint-broken-symlinks, lychee) were run
directly and passed.

Closes #8452

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:31 AM UTC · Completed 10:37 AM UTC

Commit: 9010d30 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.87

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://660c6cb9-site.fullsend-ai.workers.dev

Commit: 9010d3098a636b5f4ce3d5320ec5ac2590593f8f

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 15, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Small documentation-only fix by a bot with low metadata risk, elevated to moderate risk by high recent churn and multi-author contention on the modified CLI internals guide.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 15, 2026

@waynesun09 waynesun09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@waynesun09
waynesun09 added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 3ec97b9 Oct 15, 2026
73 of 74 checks passed
@waynesun09
waynesun09 deleted the agent/8452-fix-admin-command-tree branch October 15, 2026 19:20

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — 9010d309 Deployed Oct 15, 2026 by github-actions[bot]
dev — 9010d309 Deployed Oct 15, 2026 by fullsend-ai-coder[bot] via behaviour #16689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: cli-internals command tree lists removed admin subcommands

2 participants