Skip to content

docs(#8555): align GitLab issue-open triage and ledger guidance - #8557

Merged
ggallen merged 1 commit into
mainfrom
agent/8555-gitlab-issue-open-ledger-gaps
Oct 19, 2026
Merged

ggallen merged 1 commit into
mainfrom
agent/8555-gitlab-issue-open-ledger-gaps

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Closes the four low-severity review gaps that #8548 left open. The PR changes docs and tests only; no production code changes. It keeps the GitLab agent job's Developer-or-higher gate and documents it for issue-open triage. It also adds the missing test coverage and names both new trigger-account ledger keys in the upgrade guidance.

Related Issue

Follow-up to #8548 (child of #8438). The polling backstop for missed webhooks is tracked separately in #8553.

Changes

  • Issue-open triage permission (item 1): keeps the ADR 0054 Developer gate in run-agent-job.sh. Relaxing it would be a security-sensitive change that needs its own decision. These guides now say that automatic GitLab issue-open triage runs only for Developer, Maintainer, or Owner authors, and that Reporter, Guest, or non-member authors get a successful job that does not run triage:

    • docs/agents/triage.md
    • docs/guides/getting-started/configuring-gitlab.md
    • docs/guides/user/customizing-agents.md

    New test TestRunAgentJobScript_IssueOpenTriageRequiresDeveloper runs the real script for an issue_event triage dispatch at access levels 0, 10, 20, 30 and 40.

  • Unsafe-error coverage (item 2): TestGitLabWebhookTriggerOwnerUnsafe now includes errGitLabAccountTriggerUnsafe.

  • Ledger compatibility (item 3): currentLedgerFields now lists publication_pending. New test TestCurrentLedgerFields_MatchStateSchema checks that the list matches the ledger struct's JSON tags, and strict-decodes a ledger that carries both new keys. The breaking-change and upgrade notes name both trigger_token_digest and publication_pending, and say that older strict decoders reject either key before they read the version. Updated pages:

    • configuring-gitlab.md
    • repo-management.md
    • docs/cli/repos.md
    • gitlab-role-credentials.md
    • infrastructure-reference.md
  • Release classification (item 4): feat(#8509)!: route GitLab webhook through trigger account #8548 already shipped with the breaking ! marker, and its merged commit cannot change. The GitLab: route the managed webhook through the trigger-only account and remove the per-user merge grant #8509 upgrade note in configuring-gitlab.md now also describes the new automatic issue-open triage and its Developer-access limit.

Testing

  • go test ./internal/repos/ ./internal/scaffold/ passes
  • go vet passes on the changed packages
  • Tests added/updated for new or modified logic
  • make lint: pre-commit could not fetch remote hook repos in the sandbox (TLS error). The hooks were run directly instead, and all passed: pre-commit-hooks v6.0.0 fixers and checks, gofmt, gitleaks, lint-broken-symlinks, lint-docs-links, and lychee.

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Commits are signed off (DCO): not applicable, autonomous agent commit
  • I wrote this contribution myself and can explain all changes in it: written by an agent

Maintainers may override two decisions taken from the triage analysis: keeping the Developer gate (item 1) and treating issue-open triage as part of the existing #8509 breaking release rather than rewriting history (item 4).

🤖 Generated with Claude Code


Closes #8555

Post-script verification

  • Branch is not main/master (agent/8555-gitlab-issue-open-ledger-gaps)
  • Secret scan passed (gitleaks — 6f70a3e92e9028bd586171964579e27aa2ad0a85..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

Close the four low-severity review gaps left by #8548.

Issue-open triage permission: the GitLab agent job keeps its ADR 0054
Developer-or-higher actor gate. Only retro and prioritize skip it, so
an issue opened by a Reporter, Guest, or non-member is dispatched but
exits without running triage. The gate is kept (relaxing it would be a
security-sensitive change), and the triage agent page, the GitLab
configuration guide, and the dispatch-authorization section of the
customizing-agents guide now state the rule. A new run-agent-job.sh
test covers issue_event triage at access levels 0-40: authors below
30 skip with exit 0, and Developer or higher reach `fullsend run`.

Unsafe-error coverage: TestGitLabWebhookTriggerOwnerUnsafe now
includes errGitLabAccountTriggerUnsafe, the one sentinel it missed.

Ledger compatibility: currentLedgerFields now lists
publication_pending. A new test keeps the list in sync with the
ledger struct's JSON tags and strict-decodes a ledger carrying both
new keys. The upgrade notes in the GitLab guide, repo-management
guide, CLI reference, contributor guide, and infrastructure reference
now name both trigger_token_digest and publication_pending. Either key
makes older strict decoders reject the version 1 ledger.

Release classification: #8548 already shipped with the breaking `!`
marker, and its merged commit cannot change. The GitLab guide's #8509
upgrade note now also covers the new automatic issue-open triage and
its Developer-access limit.

Note: pre-commit could not fetch remote hook repos (TLS error in the
sandbox). The hooks were run directly instead: pre-commit-hooks
v6.0.0 fixers and checks, gofmt, go vet, gitleaks,
lint-broken-symlinks, lint-docs-links, and lychee. All passed.

Closes #8555

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fullsend-ai-review

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Ended 2:17 AM UTC

Commit: 7c333ed · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:19 AM UTC · Completed 2:39 AM UTC

Commit: 7c333ed · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.65

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://82d446e3-site.fullsend-ai.workers.dev

Commit: 7c333ed8d96088f3f3768238f1d21d4125cfaf2a

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 19, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Docs and test-only changes with low metadata risk are elevated to moderate by high recent churn and multi-author contention across the touched GitLab documentation files.

@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJzdGFsZS1kb2MiLCJmaWxlIjoiZG9jcy9hZ2VudHMvcmV2aWV3Lm1kIiwiaWQiOiJmXzFlNGI0NzdlZTY3MDFhNTYiLCJsaW5lIjozOSwiYWN0aW9uYWJsZSI6ZmFsc2V9XX0= -->

Review

Findings

Low

  • [stale-doc] docs/agents/review.md:39 — The Commands section says /fs-review and automatic review need triage-level permission or higher, with no GitLab caveat. On GitLab, the ADR 0054 gate in run-agent-job.sh skips every stage except retro and prioritize when the actor's access level is below 30, so a Reporter's MR or /fs-review comment does not run review. This PR adds a matching GitLab note to triage.md but not to review.md. The gap predates this PR and is outside GitLab: close issue-open and trigger-ledger review gaps after #8548 #8555's scope, so it is not blocking.
    Remediation: Optionally add a GitLab note to review.md that matches the one in docs/agents/triage.md. This can also be a follow-up.

Labels: PR changes GitLab documentation and adds Go tests

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge component/docs User-facing documentation testing labels Oct 19, 2026
@ggallen
ggallen added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 73a57eb Oct 19, 2026
96 of 97 checks passed
@ggallen
ggallen deleted the agent/8555-gitlab-issue-open-ledger-gaps branch October 19, 2026 03:13

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — 7c333ed8 Deployed Oct 19, 2026 by github-actions[bot]
dev — 7c333ed8 Deployed Oct 19, 2026 by fullsend-ai-coder[bot] via behaviour #17100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/docs User-facing documentation ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch risk/moderate PR risk: moderate testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitLab: close issue-open and trigger-ledger review gaps after #8548

1 participant