Repository navigation
docs(#8555): align GitLab issue-open triage and ledger guidance - #8557
Conversation
Close the four low-severity review gaps left by #8548. Issue-open triage permission: the GitLab agent job keeps its ADR 0054 Developer-or-higher actor gate. Only retro and prioritize skip it, so an issue opened by a Reporter, Guest, or non-member is dispatched but exits without running triage. The gate is kept (relaxing it would be a security-sensitive change), and the triage agent page, the GitLab configuration guide, and the dispatch-authorization section of the customizing-agents guide now state the rule. A new run-agent-job.sh test covers issue_event triage at access levels 0-40: authors below 30 skip with exit 0, and Developer or higher reach `fullsend run`. Unsafe-error coverage: TestGitLabWebhookTriggerOwnerUnsafe now includes errGitLabAccountTriggerUnsafe, the one sentinel it missed. Ledger compatibility: currentLedgerFields now lists publication_pending. A new test keeps the list in sync with the ledger struct's JSON tags and strict-decodes a ledger carrying both new keys. The upgrade notes in the GitLab guide, repo-management guide, CLI reference, contributor guide, and infrastructure reference now name both trigger_token_digest and publication_pending. Either key makes older strict decoders reject the version 1 ledger. Release classification: #8548 already shipped with the breaking `!` marker, and its merged commit cannot change. The GitLab guide's #8509 upgrade note now also covers the new automatic issue-open triage and its Developer-access limit. Note: pre-commit could not fetch remote hook repos (TLS error in the sandbox). The hooks were run directly instead: pre-commit-hooks v6.0.0 fixers and checks, gofmt, go vet, gitleaks, lint-broken-symlinks, lint-docs-links, and lychee. All passed. Closes #8555 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 2:19 AM UTC · Completed 2:39 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.65 |
Site previewPreview: https://82d446e3-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
<!-- fullsend:risk-assessment --> DetailsDocs and test-only changes with low metadata risk are elevated to moderate by high recent churn and multi-author contention across the touched GitLab documentation files. |
|
<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJzdGFsZS1kb2MiLCJmaWxlIjoiZG9jcy9hZ2VudHMvcmV2aWV3Lm1kIiwiaWQiOiJmXzFlNGI0NzdlZTY3MDFhNTYiLCJsaW5lIjozOSwiYWN0aW9uYWJsZSI6ZmFsc2V9XX0= --> ReviewFindingsLow
Labels: PR changes GitLab documentation and adds Go tests |
Summary
Closes the four low-severity review gaps that #8548 left open. The PR changes docs and tests only; no production code changes. It keeps the GitLab agent job's Developer-or-higher gate and documents it for issue-open triage. It also adds the missing test coverage and names both new trigger-account ledger keys in the upgrade guidance.
Related Issue
Follow-up to #8548 (child of #8438). The polling backstop for missed webhooks is tracked separately in #8553.
Changes
Issue-open triage permission (item 1): keeps the ADR 0054 Developer gate in
run-agent-job.sh. Relaxing it would be a security-sensitive change that needs its own decision. These guides now say that automatic GitLab issue-open triage runs only for Developer, Maintainer, or Owner authors, and that Reporter, Guest, or non-member authors get a successful job that does not run triage:docs/agents/triage.mddocs/guides/getting-started/configuring-gitlab.mddocs/guides/user/customizing-agents.mdNew test
TestRunAgentJobScript_IssueOpenTriageRequiresDeveloperruns the real script for anissue_eventtriage dispatch at access levels 0, 10, 20, 30 and 40.Unsafe-error coverage (item 2):
TestGitLabWebhookTriggerOwnerUnsafenow includeserrGitLabAccountTriggerUnsafe.Ledger compatibility (item 3):
currentLedgerFieldsnow listspublication_pending. New testTestCurrentLedgerFields_MatchStateSchemachecks that the list matches the ledger struct's JSON tags, and strict-decodes a ledger that carries both new keys. The breaking-change and upgrade notes name bothtrigger_token_digestandpublication_pending, and say that older strict decoders reject either key before they read the version. Updated pages:configuring-gitlab.mdrepo-management.mddocs/cli/repos.mdgitlab-role-credentials.mdinfrastructure-reference.mdRelease classification (item 4): feat(#8509)!: route GitLab webhook through trigger account #8548 already shipped with the breaking
!marker, and its merged commit cannot change. The GitLab: route the managed webhook through the trigger-only account and remove the per-user merge grant #8509 upgrade note inconfiguring-gitlab.mdnow also describes the new automatic issue-open triage and its Developer-access limit.Testing
go test ./internal/repos/ ./internal/scaffold/passesgo vetpasses on the changed packagesmake lint:pre-commitcould not fetch remote hook repos in the sandbox (TLS error). The hooks were run directly instead, and all passed: pre-commit-hooks v6.0.0 fixers and checks, gofmt, gitleaks, lint-broken-symlinks, lint-docs-links, and lychee.Checklist
!for breaking changes)Maintainers may override two decisions taken from the triage analysis: keeping the Developer gate (item 1) and treating issue-open triage as part of the existing #8509 breaking release rather than rewriting history (item 4).
🤖 Generated with Claude Code
Closes #8555
Post-script verification
agent/8555-gitlab-issue-open-ledger-gaps)6f70a3e92e9028bd586171964579e27aa2ad0a85..HEAD)