Repository navigation
feat(#8509)!: route GitLab webhook through trigger account - #8548
Conversation
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 2:32 PM UTC · Completed 2:43 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.06 |
Site previewPreview: https://6af40b84-site.fullsend-ai.workers.dev Commit: |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
<!-- fullsend:risk-assessment --> DetailsLarge diff size, active recent file churn, and breaking ledger format are mitigated by high test coverage, no CI or dependency modifications, bot authorship, and comprehensive acceptance criteria coverage. Previous run<!-- fullsend:risk-assessment --> DetailsLarge diff size, active recent file churn, and breaking ledger format are mitigated by high test coverage, no CI or dependency modifications, bot authorship, and comprehensive acceptance criteria coverage. Previous run (2)<!-- fullsend:risk-assessment --> DetailsLarge diff size, breaking ledger change with no downgrade path, and high recent churn in touched GitLab webhook files are balanced by strong test ratio, bot authorship, no protected or CI file changes, and complete alignment with an active linked issue. Previous run (3)<!-- fullsend:risk-assessment --> DetailsLarge diff size, breaking ledger change with no downgrade path, and high recent churn in touched GitLab webhook files are balanced by strong test ratio, bot authorship, no protected or CI file changes, and complete alignment with an active linked issue. Previous run (4)<!-- fullsend:risk-assessment --> DetailsLarge diff and high recent churn in touched repository files are counterbalanced by a bot author, absence of protected or security-sensitive paths, complete alignment with linked issue #8509, and safe fallback to the Poller route when activation is unrecorded. Previous run (5)<!-- fullsend:risk-assessment --> DetailsLarge diff and high recent churn in touched repository files are counterbalanced by a bot author, absence of protected or security-sensitive paths, complete alignment with linked issue #8509, and safe fallback to the Poller route when activation is unrecorded. Previous run (6)<!-- fullsend:risk-assessment --> DetailsLarge diff and active git churn across GitLab webhook components are balanced by zero protected paths, no CI or dependency changes, bot authorship, and activation-gated rollback safety, resulting in moderate risk. Previous run (7)<!-- fullsend:risk-assessment --> DetailsLarge diff and active git churn across GitLab webhook components are balanced by zero protected paths, no CI or dependency changes, bot authorship, and activation-gated rollback safety, resulting in moderate risk. Previous run (8)<!-- fullsend:risk-assessment --> DetailsLarge diff and active churn across modified GitLab lifecycle files are balanced by bot authorship, zero protected or security-sensitive path modifications, and strict alignment with linked issue acceptance criteria. Previous run (9)<!-- fullsend:risk-assessment --> DetailsModerate risk: the PR modifies existing webhook provisioning behavior across 14 files and touches active GitLab repo management areas with high historical churn, mitigated by an established bot author, comprehensive test coverage, no protected or CI workflow changes, and alignment with linked issue #8509. |
|
<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9kaXNwYXRjaC9yb3V0ZXIuZ28iLCJpZCI6ImZfZGYwMTI3M2U5OTYyOGUzMCIsImxpbmUiOjE5OCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRsYWJfd2ViaG9va190cmlnZ2VyX2FjY291bnRfdGVzdC5nbyIsImlkIjoiZl84OTUxZjhkYjBlZTU2ZmM1IiwibGluZSI6ODQ0LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibWlzc2luZy12ZXJzaW9uLWJ1bXAiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3RyaWdnZXJfYWNjb3VudC5nbyIsImlkIjoiZl8xNTNhODk0MTk4NTBkOTE3IiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJhY2t3YXJkLWluY29tcGF0aWJsZSIsImZpbGUiOiJpbnRlcm5hbC9kaXNwYXRjaC9yb3V0ZXIuZ28iLCJpZCI6ImZfMDAwYmFlZTNjZDVkY2ExOCIsImFjdGlvbmFibGUiOmZhbHNlfV19 --> ReviewFindingsLow
Labels: PR changes the shared dispatch router and updates GitLab docs. Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJmYWlsLW9wZW4iLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3dlYmhvb2suZ28iLCJpZCI6ImZfZGI1YmJkZTJhN2RlZTNiMyIsImxpbmUiOjg1NywiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2dpdGxhYl90cmlnZ2VyX2FjY291bnQuZ28iLCJpZCI6ImZfNjY2M2JjNGZhYWM0ZWVhMCIsImxpbmUiOjEwNjcsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZ2V0dGluZy1zdGFydGVkL3JlcG8tbWFuYWdlbWVudC5tZCIsImlkIjoiZl9mYTk1ODdjNzRmMmNkNzVkIiwibGluZSI6NjQ4LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwYXR0ZXJuLWluY29uc2lzdGVuY3kiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3JlcG9zX2dpdGxhYi5nbyIsImlkIjoiZl9lMjU0ZmU3NjZmYjljNGIzIiwibGluZSI6Mzk2LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwYXR0ZXJuLWluY29uc2lzdGVuY3kiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3dlYmhvb2tfdHJpZ2dlcl9hY2NvdW50LmdvIiwiaWQiOiJmXzA4ZTVhNjViZTM3OGYyNzYiLCJsaW5lIjoxOTQsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRsYWJfdHJpZ2dlcl9kaXNwYXRjaF9nYXRlLmdvIiwiaWQiOiJmX2I4M2E4YWViYWJmM2M2YzEiLCJsaW5lIjoxNDUsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRsYWJfd2ViaG9va190cmlnZ2VyX2FjY291bnQuZ28iLCJpZCI6ImZfNmE2NmQwMDRhNTI4OWYwZCIsImxpbmUiOjM5MiwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2dpdGxhYl93ZWJob29rLmdvIiwiaWQiOiJmXzRlNWYwZmVhZjlhNWZhMDQiLCJsaW5lIjoxNDEsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FnZW50cy90cmlhZ2UubWQiLCJpZCI6ImZfZjA2OWM1OTBmMzc1NDcxMSIsImxpbmUiOjcsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2d1aWRlcy9pbmZyYXN0cnVjdHVyZS9pbmZyYXN0cnVjdHVyZS1yZWZlcmVuY2UubWQiLCJpZCI6ImZfNGJjODAyZDNjZDg3MjE5NyIsImxpbmUiOjM1OSwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvZ2l0bGFiLXJvbGUtY3JlZGVudGlhbHMubWQiLCJpZCI6ImZfNWRjZjg3NjM4OTIyZTJlMSIsImxpbmUiOjE2MiwiYWN0aW9uYWJsZSI6dHJ1ZX1dfQ== --> ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3RyaWdnZXJfYWNjb3VudC5nbyIsImlkIjoiZl82NTg3MTUzNTE4YTFhZDYxIiwibGluZSI6Mjg0LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYmFja3dhcmQtaW5jb21wYXRpYmxlIiwiZmlsZSI6ImludGVybmFsL2Rpc3BhdGNoL3JvdXRlci5nbyIsImlkIjoiZl9mYmI4NTA3NzgzMTZkNDAwIiwibGluZSI6MTk1LCJhY3Rpb25hYmxlIjpmYWxzZX1dfQ== --> ReviewFindingsLow
Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcmVwb3NfZ2l0bGFiX3RyaWdnZXJfYWNjb3VudC5nbyIsImlkIjoiZl9lNjczMmJjNjRlODEyZjJkIiwibGluZSI6MTI3LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1jbGkiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3RyaWdnZXJfYWNjb3VudC5nbyIsImlkIjoiZl81ZDhjODdiYThjNTFlYmI4IiwibGluZSI6MTAzOSwiYWN0aW9uYWJsZSI6dHJ1ZX1dfQ== --> ReviewFindingsMedium
Low
Next steps:
Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcmVwb3NfZ2l0bGFiX3RyaWdnZXJfYWNjb3VudC5nbyIsImlkIjoiZl82OWFlNDgyMzNlYjUxYTg0IiwibGluZSI6NjEsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJwcml2aWxlZ2UtZXNjYWxhdGlvbiIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRsYWJfdHJpZ2dlcl9hY2NvdW50LmdvIiwiaWQiOiJmXzY5NzE2M2U5NzgyM2ZjY2MiLCJsaW5lIjoxMDQ2LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRsYWJfdHJpZ2dlcl9hY2NvdW50LmdvIiwiaWQiOiJmXzY4ZDc0NjEyOGE2MTE2YjIiLCJsaW5lIjoxNzE0LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJmYWlsLW9wZW4iLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3dlYmhvb2tfdHJpZ2dlcl9hY2NvdW50LmdvIiwiaWQiOiJmX2MyYzMzNDU5YzFhZGRkY2YiLCJsaW5lIjoxNjMsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6ImludGVybmFsL2Rpc3BhdGNoL3JvdXRlci5nbyIsImlkIjoiZl9iZGU4MDU1NGE5OGU3ZDE3IiwibGluZSI6MTk0LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3RyaWdnZXJfYWNjb3VudC5nbyIsImlkIjoiZl80NDQzMWMzOTVhNzRlNzYzIiwibGluZSI6MjMxLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3MvY29udHJpYnV0aW5nL2dpdGxhYi1yb2xlLWNyZWRlbnRpYWxzLm1kIiwiaWQiOiJmX2U1YTc2ZWEwNzJiYjIzODMiLCJsaW5lIjo3NzksImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvY2xpL3JlcG9zLm1kIiwiaWQiOiJmX2VhOTMyOTdiMGI3YjY1ZGMiLCJsaW5lIjoxMDkwLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3MvZ3VpZGVzL2dldHRpbmctc3RhcnRlZC9jb25maWd1cmluZy1naXRsYWIubWQiLCJpZCI6ImZfYjA2NDQyYWIzODgyZjA4MCIsImxpbmUiOjI3OSwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2NsaS9yZXBvcy5nbyIsImlkIjoiZl9lNWUyMDAzNDA0MThlYjk4IiwibGluZSI6MTMyNCwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibmFtaW5nLWNvbnZlbnRpb24iLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3dlYmhvb2tfdHJpZ2dlcl9hY2NvdW50LmdvIiwiaWQiOiJmX2ZhZWRjYTJlZTYyOGZmZDMiLCJsaW5lIjoxODMsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcmVwb3NfZ2l0bGFiLmdvIiwiaWQiOiJmXzQxYTgyZjUwODQ3MjQ0ZGMiLCJsaW5lIjozODYsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc2xlYWRpbmctbGFiZWwiLCJmaWxlIjpudWxsLCJpZCI6ImZfZGUxMTdlZTUzZjgxZjhiZSIsImFjdGlvbmFibGUiOmZhbHNlfV19 --> ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (5)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcmVwb3MuZ28iLCJpZCI6ImZfMWJiNjljZTU1MGQ1NTU2NyIsImxpbmUiOjExNzksImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InNlY3JldC1leHBvc3VyZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRsYWJfd2ViaG9va190cmlnZ2VyX2FjY291bnQuZ28iLCJpZCI6ImZfM2NiNWVmZDE4OTJjZjc2YSIsImxpbmUiOjEzOSwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZmFpbC1vcGVuIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2dpdGxhYl93ZWJob29rLmdvIiwiaWQiOiJmX2U4MjM5Nzg3YjNiMWMwM2UiLCJsaW5lIjoxMjA3LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRsYWJfd2ViaG9va190cmlnZ2VyX2FjY291bnQuZ28iLCJpZCI6ImZfOTVjZGQ3OWI4OGU4M2ZjNSIsImxpbmUiOjEzOSwiYWN0aW9uYWJsZSI6dHJ1ZX1dfQ== --> ReviewFindingsMedium
Low
Next steps:
Previous run (6)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJmYWlsLW9wZW4iLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3dlYmhvb2tfdHJpZ2dlcl9hY2NvdW50LmdvIiwiaWQiOiJmXzliMmZlNzgwYTVhM2I1NzciLCJsaW5lIjo3OSwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImhpZ2giLCJjYXRlZ29yeSI6InNlY3JldC1leHBvc3VyZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRsYWJfd2ViaG9vay5nbyIsImlkIjoiZl9hNGEzODYyYjkzZmVhM2M2IiwibGluZSI6ODMzLCJhY3Rpb25hYmxlIjp0cnVlfV19 --> ReviewFindingsHigh
Next steps:
Previous run (7)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJmYWlsLW9wZW4iLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3dlYmhvb2tfdHJpZ2dlcl9hY2NvdW50LmdvIiwiaWQiOiJmXzBjMmNhZmRiOGVjMmM4MTQiLCJsaW5lIjo2NiwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0bGFiX3dlYmhvb2suZ28iLCJpZCI6ImZfNzE3YWVlMzAyNDhhZTZjZCIsImxpbmUiOjI5NywiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5Ijoic2VjcmV0LWV4cG9zdXJlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2dpdGxhYl93ZWJob29rX3RyaWdnZXJfYWNjb3VudC5nbyIsImlkIjoiZl8yOTAzMTNkOTMzOGQ3Mzc0IiwibGluZSI6MTg4LCJhY3Rpb25hYmxlIjp0cnVlfV19 --> ReviewFindingsHigh
Medium
Next steps:
Previous run (8)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (9)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9yZXBvcy5nbyIsImlkIjoiZl9jYzlmMTU2MGNhODU0MmIyIiwibGluZSI6MTI2MywiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZmFpbC1vcGVuIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2dpdGxhYl93ZWJob29rX3RyaWdnZXJfYWNjb3VudC5nbyIsImlkIjoiZl85MzgzN2ZjNTEzOWRjZjQzIiwibGluZSI6MjMwLCJhY3Rpb25hYmxlIjp0cnVlfV19 --> ReviewFindingsMedium
Labels: GitLab webhook provisioning in Go with docs updates Next steps:
|
|
🤖 Finished Fix · ✅ Success · Started 2:45 PM UTC · Completed 3:04 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.50 |
🔧 Fix agent — iteration 1 (bot-triggered)Addressed both findings with one commit. Reinstall now settles the trigger account before the webhook, with a recheck of webhook need afterwards. An owner-verification failure after publication now contains the trigger account instead of leaving its token usable. Tests were added for the new behavior. Related Go tests pass; unrelated internal/cli tests (fetch service sockets and an output-schema env var) fail in this sandbox, also without the change. pre-commit could not fetch hook repos, so applicable hooks were run directly. Fixed (2):
Tests: passed CI inspections (5):
Conflict update: skipped; strategy Decision points
Next steps:
|
…einstall Early containment withdraws the dispatch activation on every install and only the trigger-account lifecycle records it again, so on a reinstall the webhook step judged an account-owned webhook against the Poller route. Run the lifecycle before the webhook when a trigger-account ledger exists, recheck whether the webhook needs work afterwards, and keep the existing webhook-first order for a fresh install. When the webhook step reports that the published trigger's owner is above Developer, below it, or unverifiable, run the ownership-verified trigger-account containment on a detached, bounded context instead of skipping the lifecycle stage, so the account is demoted or its published token and trigger are revoked. Disclosure: pre-commit could not fetch hook repositories in the sandbox, so the applicable hooks (whitespace, line endings, private keys, gofmt, secret scan) were run directly. Unrelated tests in internal/cli that need local sockets or an unset FULLSEND_OUTPUT_SCHEMA fail in this sandbox, also without this change. Addresses #8548 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 3:06 PM UTC · Completed 3:25 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $4.38 |
|
🤖 Finished Fix · ✅ Success · Started 3:27 PM UTC · Completed 3:44 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.22 |
…x stale docs Address review feedback on PR #8548: - contain the trigger account when the post-lifecycle webhook refresh reports an owner-safety failure, as the initial webhook step does - treat an active account route with no managed webhook as stale so a fresh install creates the account-owned webhook - register the account token with the webhook probe and teardown redactors - update stale docs about the webhook move (#8509) and account-route teardown Not changed: revoking the account trigger on webhook safety failures needs lifecycle-level changes and is left for a follow-up. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 2 (bot-triggered)Addressed 12 of the 13 findings: refresh-path trigger-account containment (both High findings, with a test), active-route-without-webhook staleness (with tests), redaction of the account token, and the seven stale or inconsistent docs. Disagreed with the safety-revocation finding, which needs lifecycle-level changes and is better as a follow-up. Tests pass for internal/repos and the GitLab-related internal/cli tests. Some unrelated internal/cli tests fail in this sandbox (fetch service, output-schema env, gateway refresh timing). Pre-commit could not run (hook repositories unreachable) and golangci-lint is not installed, so gofmt, go vet and the tests were run directly. Fixed (12):
Disagreed (1):
Tests: passed CI inspections (10):
Conflict update: skipped; strategy Decision points
Next steps:
|
|
🤖 Finished Review · ✅ Success · Started 11:46 PM UTC · Completed 12:08 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $6.07 |
Superseded by updated review
|
/fs-fix |
|
🤖 Finished Fix · ✅ Success · Started 12:28 AM UTC · Completed 12:46 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.89 |
- Keep the account-containment signal on every safety-check read failure (ledger, trigger inventory, route, hook inventory, project lookup), so a published account bearer is contained when its safety is unverifiable. - Keep the retired trigger the webhook still uses when an empty sink follows a second interrupted retry that cleared PublicationPending. - Correct breaking-change and ledger docs, and fix doc comments, a single-case switch and the deferred-result log level. Pre-commit could not run (hook repositories unreachable: certificate verification failed); gofmt, go vet, repos tests and docs link checks pass. Four internal/cli TestStartFetchService tests fail without these changes too (sandbox environment). Addresses #8548 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 1 (human-triggered)Addressed all 10 findings: the high-severity fail-open containment gap, the cleared-sink retry edge case, and the doc and style items. Added regression tests. gofmt, go vet, the repos, scaffold and gitlablifecycle tests and the docs link checks pass. Pre-commit could not run because hook repositories were unreachable (certificate error in the sandbox). Four internal/cli TestStartFetchService tests fail with or without these changes, in this sandbox only. Project CI checks on the previous head were all passing. Fixed (10):
Tests: passed CI inspections (1):
Conflict update: skipped; strategy Decision points
Next steps:
|
|
🤖 Finished Review · ✅ Success · Started 12:48 AM UTC · Completed 1:06 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $5.65 |
Superseded by updated review
Summary
Route the managed GitLab webhook through the trigger-only account's published pipeline trigger while dispatch activation is recorded. Webhook pipelines then run as that account and dispatch through the child-pipeline route (
source=pipeline). Without activation, the webhook uses the Poller-owned trigger on theapiroute. This closes #8509 and completes the webhook portion of #8438, building on #8482 and #8508.Behavior and release note
New GitLab issues opened by an authorized actor now start one triage dispatch when the managed webhook fast path is active. The shared router restricts automatic issue-open triage to GitLab events; Jira issue-open events retain their prior behavior. Merge-request-open events still start review. The pushed-commit live issue produced one triage child pipeline and one triage result.
Implementation
FULLSEND_GITLAB_TRIGGER_ACCOUNT_TOKENbefore identity pinning.fullsend runalso excludes it from harness expansion and child-process environments.protected-ref-pipelinestatus remain for the Pollerapifallback, including GitLab Free projects where schedules stay installer-owned. Uninstall removes the webhook before account cleanup revokes the account trigger.Breaking change
An existing trigger-account credential is revoked when project-wide webhook trigger safety invariants fail. Restore the reported protected-ref and CI restrictions, then rerun
repos install. Older CLIs do not understand the account-owned webhook route or the token fingerprint added to the strict trigger-account ledger; use the first release or source commit containing #8509 (or newer) for install, status, rotation, and uninstall. There is no in-place downgrade path while an account written by this version remains installed: uninstall it with a compatible CLI before using an older installer. The ledger remains at version 1 so existing installations remain readable by this CLI; older strict decoders may report an unknown ledger field. This is the documented breaking compatibility boundary.Verification
go testsuites pass forinternal/cli,internal/repos,internal/scaffold, andinternal/gitlablifecycle.go test -coverprofilepasses forinternal/dispatchandinternal/pollafter the issue-open fix;routeOpenedhas 100% statement coverage.make lintpasses on the complete staged, squashed PR diff.internal/repos) and 84.1% (internal/cli).9d35b6f, a real newly opened issue started webhook dispatcher pipeline18555469(source=trigger). It completed successfully with1 events, 1 dispatched, starting triage child pipeline18555530(source=pipeline). The triage child pipeline then completed successfully and posted its triage result on issue docs: add agent infrastructure problem document #5. A prior equivalent-tree test also dispatched triage but encountered a transient Tirith hook failure after launch.18555380,18555385). Both schedules were owned by the trigger account.18555799and18555871started withsource=schedule; both jobs were still in progress at the last check, so successful completion remains unchecked.The implementation and review fixes are consolidated into a rebased, signed-off commit. The live webhook run used the preceding
9d35b6ftree; subsequent safety and rotation fixes passed the affected-package suites and focused regression tests. Missed issue-open webhook recovery in the scheduled poller is tracked by child issue #8553 under #8438; it is outside the immediate webhook route in this PR.Closes #8509