Skip to content

chore(#8031)!: remove retired GitLab webhook-dispatch scaffold migrations - #8823

Merged
ggallen merged 1 commit into
mainfrom
agent/8031-remove-retired-scaffold-migration
Oct 26, 2026
Merged

ggallen merged 1 commit into
mainfrom
agent/8031-remove-retired-scaffold-migration

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Removes the converge-time compatibility paths for retired GitLab webhook-dispatch forms (the obsolete merge_request_event workflow rule, the obsolete-stage strip, the leftover .gitlab/ci/fullsend-dispatch.yml deletion, and the legacy version-marker fallback), now that the webhook-dispatch rollout is complete (#8021 dispatcher scaffold, #8548 last active-scaffold change, per the maintainer on the issue). Install, converge, status, and uninstall behavior for current installs is unchanged.

Marked breaking (!) because repos last converged before #7707 no longer get migrated automatically. See the BREAKING CHANGE trailer on the commit.

Related Issue

Parent epic: #7766. Sibling cleanups #8030 (pipeline-variable dispatch migration) and #8032 (poll-state migration) are deliberately untouched.

Changes

  • internal/repos/gitlabci.go: removed StripObsoleteGitLabWorkflowRules, StripObsoleteGitLabStages, the empty obsoleteGitLabStages list, the stage-reference scanner only the stage strip used (stageReferencedByJob, nodeResolvesToStage, collectJobKeys, mergeTargetResolvesToStage), and the wrapper dispatch-include checks (gitlabPipelineWrapperStillIncludesDispatch and friends). Doc comments on the shared helpers that stay (classifyTopLevelKey(s), nonJobTopLevelKeys) are updated.
  • internal/repos/converge.go: convergeGitLabRootCIFiles no longer strips obsolete rules/stages. The CI_DEBUG_TRACE backfill and typed-input root migration stay. Orphan handling no longer deletes fullsend-dispatch.yml, so a leftover is reported as an orphan like any other.
  • internal/repos/uninstall.go: removed gitlabRetiredScaffoldPaths (it was only used by converge). gitlabScaffoldPaths still lists fullsend-dispatch.yml, so uninstall still deletes a leftover copy. removeWorkflowRules still removes the obsolete MR rule from a fullsend-owned workflow block. This keeps uninstall conservative, as the triage comment recommended.
  • internal/repos/ref_ops.go, probe.go, status.go, forge_config.go: readWorkflowMarker now reads only WorkflowPaths (the pipeline wrapper). It no longer falls back to the retired dispatch stub.
  • Tests: removed tests that only exercised the retired forms. Adapted TestConverge_GitLab_ReplacementWrapperPermitsMigration, which still covers root and wrapper typed migration, so it no longer depends on the removed stage strip. Added TestConverge_GitLab_ReportsLeftoverDispatchFileAsOrphan, TestProbeComponents_GitLab_IgnoresLeftoverDispatchMarker, and TestReadWorkflowMarker_GitLabIgnoresLeftoverDispatch.
  • Docs: docs/cli/repos.md, docs/guides/getting-started/operations.md, and repo-management.md no longer describe the removed converge migrations. The uninstall docs are unchanged. The scaffold comment in fullsend-pipeline.yml is updated (comment only).
  • ADR edit (accepted ADR): added a short dated Update (2026-10, #8031) annotation to ADR 0067, following its existing annotation convention. The Context, Decision, and Consequences sections are not rewritten.

Intentionally not changed

  • dropLegacyRunnerTags (manifest_set.go), which triage listed. It backs the still-supported deprecated gitlab.runner_tags manifest alias, and that alias refills an empty agent_runner_tags on load. Removing only the drop would make manifest set gitlab.agent_runner_tags silently pick up the old tags again. Removing the alias itself is a user-config change outside this issue's scope (scaffold names, stages, workflow rules).
  • Typed pipeline-input / legacy variable-dispatch compatibility (Remove legacy pipeline-variable dispatch migration #8030) and poll-state variable migration (Remove legacy poll-state migration from install and converge #8032).

Testing

  • go build ./... and go vet ./...
  • go test ./internal/repos/ ./internal/scaffold/ pass
  • internal/cli has six failures (TestStartFetchService_*, TestPostScriptEnv_NoSchema*). They are pre-existing and environmental: they fail identically on unmodified main in the sandbox.
  • make lint: pre-commit could not fetch its hook repositories in the sandbox (TLS verification failure). I ran the applicable hooks directly and they pass: check-yaml, end-of-file-fixer, trailing-whitespace, detect-private-key, check-merge-conflict, mixed-line-ending, gofmt, go vet, gitleaks, lychee, lint-docs-links, lint-broken-symlinks, and the ADR status/number/frontmatter lints.
  • Tests added/updated for modified logic

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Commits are signed off (DCO) — not applicable: autonomous bot commit
  • I wrote this contribution myself and can explain all changes in it — agent-authored, needs human review

🤖 Generated with Claude Code


Closes #8031

Post-script verification

  • Branch is not main/master (agent/8031-remove-retired-scaffold-migration)
  • Secret scan passed (gitleaks — 3c3ad258352f8bd6bfb85461d4dbe1884f02eb77..HEAD)
  • PR body secret scan passed (gitleaks — no-git)
  • Final PR description secret scan passed (gitleaks — no-git)

…ions

The webhook-dispatch rollout is complete (the dispatcher scaffold
landed in #8021, the last active-scaffold change in #8548), so the
converge-time compatibility paths for retired GitLab forms are no
longer needed.

Removed:
- StripObsoleteGitLabWorkflowRules and StripObsoleteGitLabStages, their
  converge steps, the empty obsoleteGitLabStages list, and the
  stage-reference scanner (stageReferencedByJob, nodeResolvesToStage,
  collectJobKeys, mergeTargetResolvesToStage) only they used.
- Converge deletion of a leftover fullsend-dispatch.yml
  (gitlabRetiredScaffoldPaths) and the wrapper-include checks guarding
  it. A leftover stub is now reported as an ordinary orphan.
- The status/probe/upgrade fallback that read the version marker from
  a leftover fullsend-dispatch.yml.
- Tests and docs that covered only those retired forms.

Preserved: install, the CI_DEBUG_TRACE rule backfill, the typed
pipeline-input root migration, status for current installs, and
uninstall. Uninstall still deletes a leftover fullsend-dispatch.yml
and still removes the obsolete merge_request_event rule from a
fullsend-owned workflow block. User-owned CI configuration is never
rewritten.

Not changed: dropLegacyRunnerTags. It backs the still-supported
gitlab.runner_tags manifest alias, which refills agent_runner_tags on
load. It is not a scaffold/stage/rule migration path, and removing the
alias would be a separate user-config change.

Pre-commit could not fetch its hook repositories in the sandbox (TLS
verification failure); the applicable hooks (check-yaml,
end-of-file-fixer, trailing-whitespace, detect-private-key,
check-merge-conflict, mixed-line-ending, gofmt, go vet, gitleaks,
lychee, docs-link, symlink and ADR lints) were run directly and pass.

BREAKING CHANGE: converge no longer migrates GitLab repos last
converged before #7707: it does not strip the obsolete
merge_request_event workflow rule, does not delete a leftover
.gitlab/ci/fullsend-dispatch.yml (reported as an orphan instead), and
status no longer reads that file's version marker. Converge such repos
with an earlier release first, or remove those leftovers manually (or
via uninstall).

Closes #8031

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 12:03 PM UTC · Completed 12:12 PM UTC

Commit: c23b202 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.61

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://17b69666-site.fullsend-ai.workers.dev

Commit: c23b2029a9d088e1f7f2d7e9c6468458aa5b5c2f

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 26, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Large diff consists primarily of dead-code removal without protected-path or dependency changes, balanced by elevated Tier 2 churn in internal/repos and an unflagged breaking removal of legacy converge migrations.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: PR removes retired GitLab scaffold migration code from repo install/converge and is a chore cleanup

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge type/chore Maintenance and housekeeping tasks component/install CLI install and app setup labels Oct 26, 2026
@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ggallen
ggallen added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit ae63b7a Oct 26, 2026
97 of 98 checks passed
@ggallen
ggallen deleted the agent/8031-remove-retired-scaffold-migration branch October 26, 2026 13:24

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — c23b2029 Deployed Oct 26, 2026 by github-actions[bot]
dev — c23b2029 Deployed Oct 26, 2026 by fullsend-ai-coder[bot] via playback #17956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/install CLI install and app setup ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch risk/moderate PR risk: moderate type/chore Maintenance and housekeeping tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove retired webhook-dispatch scaffold migration paths

1 participant