Repository navigation
chore(#8031)!: remove retired GitLab webhook-dispatch scaffold migrations - #8823
Conversation
…ions The webhook-dispatch rollout is complete (the dispatcher scaffold landed in #8021, the last active-scaffold change in #8548), so the converge-time compatibility paths for retired GitLab forms are no longer needed. Removed: - StripObsoleteGitLabWorkflowRules and StripObsoleteGitLabStages, their converge steps, the empty obsoleteGitLabStages list, and the stage-reference scanner (stageReferencedByJob, nodeResolvesToStage, collectJobKeys, mergeTargetResolvesToStage) only they used. - Converge deletion of a leftover fullsend-dispatch.yml (gitlabRetiredScaffoldPaths) and the wrapper-include checks guarding it. A leftover stub is now reported as an ordinary orphan. - The status/probe/upgrade fallback that read the version marker from a leftover fullsend-dispatch.yml. - Tests and docs that covered only those retired forms. Preserved: install, the CI_DEBUG_TRACE rule backfill, the typed pipeline-input root migration, status for current installs, and uninstall. Uninstall still deletes a leftover fullsend-dispatch.yml and still removes the obsolete merge_request_event rule from a fullsend-owned workflow block. User-owned CI configuration is never rewritten. Not changed: dropLegacyRunnerTags. It backs the still-supported gitlab.runner_tags manifest alias, which refills agent_runner_tags on load. It is not a scaffold/stage/rule migration path, and removing the alias would be a separate user-config change. Pre-commit could not fetch its hook repositories in the sandbox (TLS verification failure); the applicable hooks (check-yaml, end-of-file-fixer, trailing-whitespace, detect-private-key, check-merge-conflict, mixed-line-ending, gofmt, go vet, gitleaks, lychee, docs-link, symlink and ADR lints) were run directly and pass. BREAKING CHANGE: converge no longer migrates GitLab repos last converged before #7707: it does not strip the obsolete merge_request_event workflow rule, does not delete a leftover .gitlab/ci/fullsend-dispatch.yml (reported as an orphan instead), and status no longer reads that file's version marker. Converge such repos with an earlier release first, or remove those leftovers manually (or via uninstall). Closes #8031 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 12:03 PM UTC · Completed 12:12 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.61 |
Site previewPreview: https://17b69666-site.fullsend-ai.workers.dev Commit: |
|
<!-- fullsend:risk-assessment --> DetailsLarge diff consists primarily of dead-code removal without protected-path or dependency changes, balanced by elevated Tier 2 churn in internal/repos and an unflagged breaking removal of legacy converge migrations. |
|
Looks good to me Labels: PR removes retired GitLab scaffold migration code from repo install/converge and is a chore cleanup |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Removes the converge-time compatibility paths for retired GitLab webhook-dispatch forms (the obsolete
merge_request_eventworkflow rule, the obsolete-stage strip, the leftover.gitlab/ci/fullsend-dispatch.ymldeletion, and the legacy version-marker fallback), now that the webhook-dispatch rollout is complete (#8021 dispatcher scaffold, #8548 last active-scaffold change, per the maintainer on the issue). Install, converge, status, and uninstall behavior for current installs is unchanged.Marked breaking (
!) because repos last converged before #7707 no longer get migrated automatically. See theBREAKING CHANGEtrailer on the commit.Related Issue
Parent epic: #7766. Sibling cleanups #8030 (pipeline-variable dispatch migration) and #8032 (poll-state migration) are deliberately untouched.
Changes
internal/repos/gitlabci.go: removedStripObsoleteGitLabWorkflowRules,StripObsoleteGitLabStages, the emptyobsoleteGitLabStageslist, the stage-reference scanner only the stage strip used (stageReferencedByJob,nodeResolvesToStage,collectJobKeys,mergeTargetResolvesToStage), and the wrapper dispatch-include checks (gitlabPipelineWrapperStillIncludesDispatchand friends). Doc comments on the shared helpers that stay (classifyTopLevelKey(s),nonJobTopLevelKeys) are updated.internal/repos/converge.go:convergeGitLabRootCIFilesno longer strips obsolete rules/stages. TheCI_DEBUG_TRACEbackfill and typed-input root migration stay. Orphan handling no longer deletesfullsend-dispatch.yml, so a leftover is reported as an orphan like any other.internal/repos/uninstall.go: removedgitlabRetiredScaffoldPaths(it was only used by converge).gitlabScaffoldPathsstill listsfullsend-dispatch.yml, so uninstall still deletes a leftover copy.removeWorkflowRulesstill removes the obsolete MR rule from a fullsend-owned workflow block. This keeps uninstall conservative, as the triage comment recommended.internal/repos/ref_ops.go,probe.go,status.go,forge_config.go:readWorkflowMarkernow reads onlyWorkflowPaths(the pipeline wrapper). It no longer falls back to the retired dispatch stub.TestConverge_GitLab_ReplacementWrapperPermitsMigration, which still covers root and wrapper typed migration, so it no longer depends on the removed stage strip. AddedTestConverge_GitLab_ReportsLeftoverDispatchFileAsOrphan,TestProbeComponents_GitLab_IgnoresLeftoverDispatchMarker, andTestReadWorkflowMarker_GitLabIgnoresLeftoverDispatch.docs/cli/repos.md,docs/guides/getting-started/operations.md, andrepo-management.mdno longer describe the removed converge migrations. The uninstall docs are unchanged. The scaffold comment infullsend-pipeline.ymlis updated (comment only).Update (2026-10, #8031)annotation to ADR 0067, following its existing annotation convention. The Context, Decision, and Consequences sections are not rewritten.Intentionally not changed
dropLegacyRunnerTags(manifest_set.go), which triage listed. It backs the still-supported deprecatedgitlab.runner_tagsmanifest alias, and that alias refills an emptyagent_runner_tagson load. Removing only the drop would makemanifest set gitlab.agent_runner_tagssilently pick up the old tags again. Removing the alias itself is a user-config change outside this issue's scope (scaffold names, stages, workflow rules).Testing
go build ./...andgo vet ./...go test ./internal/repos/ ./internal/scaffold/passinternal/clihas six failures (TestStartFetchService_*,TestPostScriptEnv_NoSchema*). They are pre-existing and environmental: they fail identically on unmodifiedmainin the sandbox.make lint:pre-commitcould not fetch its hook repositories in the sandbox (TLS verification failure). I ran the applicable hooks directly and they pass: check-yaml, end-of-file-fixer, trailing-whitespace, detect-private-key, check-merge-conflict, mixed-line-ending, gofmt, go vet, gitleaks, lychee, lint-docs-links, lint-broken-symlinks, and the ADR status/number/frontmatter lints.Checklist
!for breaking changes)🤖 Generated with Claude Code
Closes #8031
Post-script verification
agent/8031-remove-retired-scaffold-migration)3c3ad258352f8bd6bfb85461d4dbe1884f02eb77..HEAD)