Repository navigation
ci(e2e): surface rate-limit state in harness-wait timeouts - #8809
Conversation
PR Summary by QodoSurface rate-limit state in harness timeouts and scan e2e evidence
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
|
🤖 Finished Review · ✅ Success · Started 6:07 PM UTC · Completed 6:19 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.63 |
Code Review by Qodo
1.
|
Site previewPreview: https://5af1ba32-site.fullsend-ai.workers.dev Commit: |
|
<!-- fullsend:risk-assessment --> DetailsLarge diff across 8 files touching protected skills paths and CI tooling with high git history churn, offset by extensive test coverage and alignment with linked rate-limit instrumentation issue #6702. Previous run<!-- fullsend:risk-assessment --> DetailsLarge diff across 8 files touching protected skills paths and build tooling with high git history churn, offset by extensive test coverage and alignment with linked rate-limit instrumentation issue #6702. Previous run (2)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (3)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (4)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (5)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (6)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (7)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (8)<!-- fullsend:risk-assessment --> DetailsLarge diff touching protected skill paths and CI build files combined with high churn and change coupling in touched driver and build files warrants an elevated risk rating despite strong test coverage. Previous run (9)<!-- fullsend:risk-assessment --> DetailsLarge diff touching protected skill paths and CI build files combined with high churn and change coupling in touched driver and build files warrants an elevated risk rating despite strong test coverage. Previous run (10)<!-- fullsend:risk-assessment --> DetailsLarge diff touching protected skill paths and high-churn CI behaviour test files yields an elevated risk score despite thorough test additions and additive scanner logic. Previous run (11)<!-- fullsend:risk-assessment --> DetailsLarge diff touching protected skill paths and high-churn CI behaviour test files yields an elevated risk score despite thorough test additions and additive scanner logic. Previous run (12)<!-- fullsend:risk-assessment --> DetailsLarge diff touching protected skill paths and high-churn CI behaviour test files yields an elevated risk score despite thorough test additions and additive scanner logic. Previous run (13)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (14)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (15)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (16)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (17)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (18)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (19)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (20)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (21)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (22)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (23)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (24)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (25)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (26)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (27)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (28)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (29)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics, preserved from prior review as signals remain unchanged. Previous run (30)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (31)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (32)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (33)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (34)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (35)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (36)<!-- fullsend:risk-assessment --> DetailsLarge diff modifying protected skill paths and high-churn CI behaviour test components yields an elevated risk score despite extensive test additions and additive diagnostics. Previous run (37)<!-- fullsend:risk-assessment --> DetailsLarge diff touching protected skill paths and high-churn CI behaviour test files yields an elevated risk score despite thorough test additions. |
ReviewFindingsMedium
Earlier findings
1 finding(s) below the Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InNjb3BlLWV4Y2VlZGVkIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL3NjcmlwdHMvc2Nhbi1yYXRlbGltaXQtZXZpZGVuY2Uuc2giLCJpZCI6ImZfYTUyNTk4YTVjMGY1YjUzYSIsImxpbmUiOjIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL3NjcmlwdHMvc2Nhbi1yYXRlbGltaXQtZXZpZGVuY2Uuc2giLCJpZCI6ImZfMzlmZmNiZDkyYzQ3NzBhNSIsImxpbmUiOjM2MCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifV19 --> ReviewFindingsMedium
Low
Next steps:
Previous run (2)ReviewReason: stale-head The review agent reviewed commit Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZGV2L2JlaGF2aW91ci10ZXN0aW5nLm1kIiwiaWQiOiJmXzhlZmQ0Njk2ODhlYTk1OWYiLCJsaW5lIjozMzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic2NvcGUtY3JlZXAiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9iMTVlMTNlNWI1NzUzOTRmIiwibGluZSI6MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiZGVzaWduLXNtZWxsIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL1NLSUxMLm1kIiwiaWQiOiJmXzQxN2FiZmE5MjEyYmE5Y2MiLCJsaW5lIjo2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfOGVmZDQ2OTY4OGVhOTU5ZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNDE3YWJmYTkyMTJiYTljYyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsMedium
Low
Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZGV2L2JlaGF2aW91ci10ZXN0aW5nLm1kIiwiaWQiOiJmXzhlZmQ0Njk2ODhlYTk1OWYiLCJsaW5lIjozMzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic2NvcGUtY3JlZXAiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9iMTVlMTNlNWI1NzUzOTRmIiwibGluZSI6MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiZGVzaWduLXNtZWxsIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL1NLSUxMLm1kIiwiaWQiOiJmXzQxN2FiZmE5MjEyYmE5Y2MiLCJsaW5lIjo2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfOGVmZDQ2OTY4OGVhOTU5ZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl80MTdhYmZhOTIxMmJhOWNjIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMTNkNWEzZWYzM2QwYTI1YyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9iMTVlMTNlNWI1NzUzOTRmIiwic3RhdHVzIjoib3BlbiJ9XX0= --> ReviewFindingsMedium
Low
Earlier findings
Previous run (5)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZGV2L2JlaGF2aW91ci10ZXN0aW5nLm1kIiwiaWQiOiJmXzhlZmQ0Njk2ODhlYTk1OWYiLCJsaW5lIjozMzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJkZXNpZ24tc21lbGwiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfNDE3YWJmYTkyMTJiYTljYyIsImxpbmUiOjYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL1NLSUxMLm1kIiwiaWQiOiJmXzEzZDVhM2VmMzNkMGEyNWMiLCJsaW5lIjoxMjIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJzY29wZS1jcmVlcCIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJsaW5lIjoyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfOGVmZDQ2OTY4OGVhOTU5ZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl80MTdhYmZhOTIxMmJhOWNjIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfMTNkNWEzZWYzM2QwYTI1YyIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifV19 --> ReviewFindingsMedium
Low
Earlier findings
3 finding(s) below the Previous run (6)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZGV2L2JlaGF2aW91ci10ZXN0aW5nLm1kIiwiaWQiOiJmXzhlZmQ0Njk2ODhlYTk1OWYiLCJsaW5lIjozMzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRlc2lnbi1zbWVsbCIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl80MTdhYmZhOTIxMmJhOWNjIiwibGluZSI6NiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfMTNkNWEzZWYzM2QwYTI1YyIsImxpbmUiOjEyMiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL3NjcmlwdHMvc2Nhbi1yYXRlbGltaXQtZXZpZGVuY2Uuc2giLCJpZCI6ImZfYjE1ZTEzZTViNTc1Mzk0ZiIsImxpbmUiOjIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl84ZWZkNDY5Njg4ZWE5NTlmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzEzZDVhM2VmMzNkMGEyNWMiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl9iMTVlMTNlNWI1NzUzOTRmIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn1dfQ== --> ReviewFindingsMedium
Low
2 finding(s) below the Previous run (7)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZGV2L2JlaGF2aW91ci10ZXN0aW5nLm1kIiwiaWQiOiJmXzhlZmQ0Njk2ODhlYTk1OWYiLCJsaW5lIjozMzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic2NvcGUtY3JlZXAiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9iMTVlMTNlNWI1NzUzOTRmIiwibGluZSI6MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzhlZmQ0Njk2ODhlYTk1OWYiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMTNkNWEzZWYzM2QwYTI1YyIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifV19 --> ReviewFindingsMedium
Low
Earlier findings
2 finding(s) below the Previous run (8)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZGV2L2JlaGF2aW91ci10ZXN0aW5nLm1kIiwiaWQiOiJmXzhlZmQ0Njk2ODhlYTk1OWYiLCJsaW5lIjozMzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic2NvcGUtY3JlZXAiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9iMTVlMTNlNWI1NzUzOTRmIiwibGluZSI6MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzEzZDVhM2VmMzNkMGEyNWMiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl84ZWZkNDY5Njg4ZWE5NTlmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifV19 --> ReviewFindingsMedium
Low
Earlier findings
2 finding(s) below the Previous run (9)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZGV2L2JlaGF2aW91ci10ZXN0aW5nLm1kIiwiaWQiOiJmXzhlZmQ0Njk2ODhlYTk1OWYiLCJsaW5lIjozMzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJzY29wZS1jcmVlcCIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJsaW5lIjoyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfMTNkNWEzZWYzM2QwYTI1YyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl84ZWZkNDY5Njg4ZWE5NTlmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifV19 --> ReviewFindingsMedium
Low
Earlier findings
1 finding(s) below the Previous run (10)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvZ3VpZGVzL2Rldi9iZWhhdmlvdXItdGVzdGluZy5tZCIsImlkIjoiZl84ZWZkNDY5Njg4ZWE5NTlmIiwibGluZSI6MzM0LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL3NjcmlwdHMvc2Nhbi1yYXRlbGltaXQtZXZpZGVuY2Uuc2giLCJpZCI6ImZfYjE1ZTEzZTViNTc1Mzk0ZiIsImxpbmUiOjIsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzEzZDVhM2VmMzNkMGEyNWMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYjE1ZTEzZTViNTc1Mzk0ZiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9XX0= --> ReviewFindingsMedium
Low
Earlier findings
1 finding(s) below the Previous run (11)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL3NjcmlwdHMvc2Nhbi1yYXRlbGltaXQtZXZpZGVuY2Uuc2giLCJpZCI6ImZfYjE1ZTEzZTViNTc1Mzk0ZiIsImxpbmUiOjIsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzEzZDVhM2VmMzNkMGEyNWMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYjE1ZTEzZTViNTc1Mzk0ZiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9XX0= --> ReviewFindingsMedium
Low
1 finding(s) below the Previous run (12)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl8xM2Q1YTNlZjMzZDBhMjVjIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL3NjcmlwdHMvc2Nhbi1yYXRlbGltaXQtZXZpZGVuY2Uuc2giLCJpZCI6ImZfYjE1ZTEzZTViNTc1Mzk0ZiIsImxpbmUiOjIsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifV19 --> ReviewFindingsMedium
Low
Earlier findings
1 finding(s) below the Previous run (13)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJzY29wZS1jcmVlcCIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmX2IxNWUxM2U1YjU3NTM5NGYiLCJsaW5lIjoyLCJhY3Rpb25hYmxlIjpmYWxzZX1dfQ== --> ReviewFindingsMedium
Low
Previous run (14)ReviewFindingsMedium
Low
Earlier findings
3 finding(s) below the Previous run (15)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9jMWI5ZmRhZjc1ZGJhMzcxIiwibGluZSI6MzIzLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZGVzaWduLXNtZWxsIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL1NLSUxMLm1kIiwiaWQiOiJmXzVlODE1NzI4YjI4ZTFlNDIiLCJsaW5lIjo2LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6Im1pc3BsYWNlZC1hYnN0cmFjdGlvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZTc5ZmQzZWM4YTI4ZmJiIiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2IiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJsaW5lIjoxNDIsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJsaW5lIjozMjMsImFjdGlvbmFibGUiOnRydWV9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYzFiOWZkYWY3NWRiYTM3MSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl81ZTgxNTcyOGIyOGUxZTQyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzllNzlmZDNlYzhhMjhmYmIiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfODgxMTZkOTNmMGQyZDdhMiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Low
2 finding(s) below the Previous run (16)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9jMWI5ZmRhZjc1ZGJhMzcxIiwibGluZSI6MzIzLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZGVzaWduLXNtZWxsIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL1NLSUxMLm1kIiwiaWQiOiJmXzVlODE1NzI4YjI4ZTFlNDIiLCJsaW5lIjo2LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6Im1pc3BsYWNlZC1hYnN0cmFjdGlvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZTc5ZmQzZWM4YTI4ZmJiIiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2IiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJsaW5lIjoxNDIsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJsaW5lIjozMjMsImFjdGlvbmFibGUiOnRydWV9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYzFiOWZkYWY3NWRiYTM3MSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl81ZTgxNTcyOGIyOGUxZTQyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzllNzlmZDNlYzhhMjhmYmIiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfODgxMTZkOTNmMGQyZDdhMiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Low
Earlier findings
Previous run (17)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9jMWI5ZmRhZjc1ZGJhMzcxIiwibGluZSI6MzIzLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZGVzaWduLXNtZWxsIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL1NLSUxMLm1kIiwiaWQiOiJmXzVlODE1NzI4YjI4ZTFlNDIiLCJsaW5lIjo2LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6Im1pc3BsYWNlZC1hYnN0cmFjdGlvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZTc5ZmQzZWM4YTI4ZmJiIiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2IiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJsaW5lIjoxNDIsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJsaW5lIjozMjMsImFjdGlvbmFibGUiOnRydWV9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfNWU4MTU3MjhiMjhlMWU0MiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl85ZTc5ZmQzZWM4YTI4ZmJiIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfOWQ5ZDVkMDU5MTU2OGM5NiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9jZGVhZjA0M2I0ZGM2MGExIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> ReviewFindingsMedium
Low
Previous run (18)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkZXNpZ24tc21lbGwiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfNWU4MTU3MjhiMjhlMWU0MiIsImxpbmUiOjYsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoibWlzcGxhY2VkLWFic3RyYWN0aW9uIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL1NLSUxMLm1kIiwiaWQiOiJmXzllNzlmZDNlYzhhMjhmYmIiLCJsaW5lIjo3LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL1NLSUxMLm1kIiwiaWQiOiJmXzlkOWQ1ZDA1OTE1NjhjOTYiLCJsaW5lIjo3LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL3NjcmlwdHMvc2Nhbi1yYXRlbGltaXQtZXZpZGVuY2Uuc2giLCJpZCI6ImZfODgxMTZkOTNmMGQyZDdhMiIsImxpbmUiOjE0MiwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6InNraWxscy9lMmUtaGVhbHRoL3NjcmlwdHMvc2Nhbi1yYXRlbGltaXQtZXZpZGVuY2Uuc2giLCJpZCI6ImZfY2RlYWYwNDNiNGRjNjBhMSIsImxpbmUiOjMyMywiYWN0aW9uYWJsZSI6dHJ1ZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl81ZTgxNTcyOGIyOGUxZTQyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzllNzlmZDNlYzhhMjhmYmIiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfODgxMTZkOTNmMGQyZDdhMiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Low
Earlier findings
Previous run (19)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkZXNpZ24tc21lbGwiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfNWU4MTU3MjhiMjhlMWU0MiIsImxpbmUiOjYsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJtaXNwbGFjZWQtYWJzdHJhY3Rpb24iLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfOWU3OWZkM2VjOGEyOGZiYiIsImxpbmUiOjcsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoicGVybWlzc2lvbi1leHBhbnNpb24iLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfOWQ5ZDVkMDU5MTU2OGM5NiIsImxpbmUiOjcsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl84ODExNmQ5M2YwZDJkN2EyIiwibGluZSI6MTQyLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9jZGVhZjA0M2I0ZGM2MGExIiwibGluZSI6MzIzLCJhY3Rpb25hYmxlIjp0cnVlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzVlODE1NzI4YjI4ZTFlNDIiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfOWU3OWZkM2VjOGEyOGZiYiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfODgxMTZkOTNmMGQyZDdhMiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Low
Earlier findings
Previous run (20)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkZXNpZ24tc21lbGwiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfNWU4MTU3MjhiMjhlMWU0MiIsImxpbmUiOjYsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJtaXNwbGFjZWQtYWJzdHJhY3Rpb24iLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfOWU3OWZkM2VjOGEyOGZiYiIsImxpbmUiOjcsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoicGVybWlzc2lvbi1leHBhbnNpb24iLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfOWQ5ZDVkMDU5MTU2OGM5NiIsImxpbmUiOjcsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl84ODExNmQ5M2YwZDJkN2EyIiwibGluZSI6MTQyLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl9jZGVhZjA0M2I0ZGM2MGExIiwibGluZSI6MzIzLCJhY3Rpb25hYmxlIjp0cnVlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl81ZTgxNTcyOGIyOGUxZTQyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzllNzlmZDNlYzhhMjhmYmIiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfOWQ5ZDVkMDU5MTU2OGM5NiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Low
Earlier findings
Previous run (21)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJsaW5lIjozMjMsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRlc2lnbi1zbWVsbCIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl81ZTgxNTcyOGIyOGUxZTQyIiwibGluZSI6NiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3BsYWNlZC1hYnN0cmFjdGlvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZTc5ZmQzZWM4YTI4ZmJiIiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2IiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJsaW5lIjoxNDIsImFjdGlvbmFibGUiOnRydWV9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfY2RlYWYwNDNiNGRjNjBhMSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfODgxMTZkOTNmMGQyZDdhMiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsMedium
Low
Earlier findings
Next steps:
Previous run (22)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmX2NkZWFmMDQzYjRkYzYwYTEiLCJsaW5lIjozMjMsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9TS0lMTC5tZCIsImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2IiwibGluZSI6NywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJza2lsbHMvZTJlLWhlYWx0aC9zY3JpcHRzL3NjYW4tcmF0ZWxpbWl0LWV2aWRlbmNlLnNoIiwiaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJsaW5lIjoxNDIsImFjdGlvbmFibGUiOnRydWV9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfOWQ5ZDVkMDU5MTU2OGM5NiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Earlier findings
Next steps:
Previous run (23)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoicGVybWlzc2lvbi1leHBhbnNpb24iLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvU0tJTEwubWQiLCJpZCI6ImZfOWQ5ZDVkMDU5MTU2OGM5NiIsImxpbmUiOjcsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoic2tpbGxzL2UyZS1oZWFsdGgvc2NyaXB0cy9zY2FuLXJhdGVsaW1pdC1ldmlkZW5jZS5zaCIsImlkIjoiZl84ODExNmQ5M2YwZDJkN2EyIiwibGluZSI6MTQyLCJhY3Rpb25hYmxlIjp0cnVlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzg4MTE2ZDkzZjBkMmQ3YTIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl85ZDlkNWQwNTkxNTY4Yzk2Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn1dfQ== --> ReviewFindingsMedium
Earlier findings
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2930d96 to
16ed5f2
Compare
|
🤖 Finished Review · ✅ Success · Started 8:01 PM UTC · Completed 8:11 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.95 |
16ed5f2 to
3a7240c
Compare
|
🤖 Finished Review · ✅ Success · Started 10:31 PM UTC · Completed 10:39 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.39 |
3a7240c to
d64fe86
Compare
|
🤖 Finished Review · ✅ Success · Started 9:14 AM UTC · Completed 9:27 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.33 |
|
🤖 Finished Review · ✅ Success · Started 7:36 PM UTC · Completed 7:47 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.26 |
|
🤖 Finished Review · ✅ Success · Started 9:20 AM UTC · Completed 9:37 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.17 |
rh-hemartin
left a comment
There was a problem hiding this comment.
Sounds good to me, next step is to somehow analyze these reports to decide what to do, right?
I think we may need @ifireball to weigh in. I was told he has overlapping work. @ifireball what do you think about this PR? |
|
🤖 Finished Review · ✅ Success · Started 5:17 PM UTC · Completed 5:28 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.62 |
Closes the instrumentation loop for the pool-org token exhausting the GitHub API budget mid-run (fullsend-ai#6702): harness waits that time out no longer fail blind. - githubactions: append the polling client's last-seen GitHub rate-limit state (remaining/reset, observation age, or an explicit unknown) to every harness-wait timeout tail - including timeouts with no poll failures, which previously carried no quota information at all. Non-implementing clients (GitLab, plain fakes) are unchanged; 5 new tests pin the state line and each timeout scenario. - e2e-health: add scan-ratelimit-evidence.sh, which walks completed e2e.yml runs and attempts via the actions API, detects the fullsend-ai#6698 blind-wait markers in behaviour-job logs, and emits a JSON report with verdicts at both signal levels (any occurrence; retry-masked), making fullsend-ai#6702's closure criterion mechanically checkable. Paired 70-assertion hermetic test registered in make script-test. - docs: rate-limit observability section in the behaviour-testing guide and the scan procedure in the e2e-health skill. Assisted-by: glm-5 Generated with AI assistance (glm-5) AI-Assisted: true Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
… timeouts Both harness waits built their timeout errors without the client's last-seen GitHub rate-limit state, contradicting the documented claim that every harness-wait timeout error carries it. Append describeRateLimitState to the CountHarnessDispatches and WaitForHarnessEmptyMatrix timeout paths, and align the count wait with the other waits' injectable clock and timers so its timeout path is deterministically testable. Addresses PR fullsend-ai#8809 review feedback from @fullsend-ai-review[bot] and @qodo-code-review[bot]. AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The scanner counted a same-error-lookups marker the driver can never emit: the timeout diagnostics pass no current lookup error, so the lookup tail always renders the counted-failures shape. Count that real shape instead (failed-lookups), keep the poll near-miss excluded, and rework the fixtures to the producer's verbatim rendering, including the rate-limit state line. The docs now describe the real contract too. Also validate the jobs-page envelope before extracting from it — a 200 error body is not a jobs page and must fail the scan rather than silently excluding the run — die on any scan_run exit status other than the no-behaviour-job sentinel, and use die for main's argument validation so every failure carries the script prefix. Addresses PR fullsend-ai#8809 review feedback from @fullsend-ai-review[bot] and @qodo-code-review[bot]. AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The five standalone grants (gh repo view, gh run list, two gh api path-prefix grants, and blanket jq) widened the skill beyond its documented procedure: the scanner performs those calls itself, gh api path-prefix grants accept any --method, and jq can read arbitrary files via --rawfile. Keep only the path-scoped script grants, and reword the one documented jq step to read the verdict object from the saved report instead. Addresses PR fullsend-ai#8809 review feedback from @fullsend-ai-review[bot]. AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Addresses PR fullsend-ai#8809 review feedback from @fullsend-ai-review[bot]. scan_run runs on the left of || in main, so errexit is suspended inside it: a failing analyze_log was masked, jq emitted [] for a dead awk, no log_error or INCOMPLETE was recorded, and the function returned its last pipeline's status, so the rc check in main could not catch it. A scan could report a clean, marker-free run on an analyzer failure. Handle the analyzer like a failed log fetch: discard partial output, record a per-attempt log_error, set INCOMPLETE, and warn the operator. Add awk to the tool preflight and a hermetic test that overrides analyze_log to die mid-stream. Signed-off-by: Jay Flowers <jay.flowers@gmail.com> AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Addresses PR fullsend-ai#8809 review feedback from @fullsend-ai-review[bot]. The failure-path assignment inside scan_run leaked analyzer_rc into global scope; every other function-scoped variable in the script is declared local. Add it to the existing local declaration. No behavior change; the analyzer-failure test still passes. Signed-off-by: Jay Flowers <jay.flowers@gmail.com> AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
|
🤖 Finished Review · ✅ Success · Started 2:40 AM UTC · Completed 2:52 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.62 |
|
🤖 Finished Review · ✅ Success · Started 1:10 PM UTC · Completed 1:18 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.64 |
…umns The paragraph was edited in this PR to link the Rate-limit observability section but stayed one ~570-character line. Rewrap it per docs/contributing/documentation.md; wording is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 1:20 PM UTC · Completed 1:31 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.17 |
The --runs upper-bound check compared with Bash fixed-width arithmetic after a digits-only regex, so an oversized value such as 18446744073709551616 wrapped to 0, passed validation, and produced a zero-run scan that exited 0. Match ^([1-9]|[1-9][0-9]|100)$ directly and add argument-validation tests, including oversized integers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The frontmatter description drives skill discovery; the (the fullsend-ai#6702 validation) reference goes stale once the issue closes. The body keeps the fullsend-ai#6702 context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
|
🤖 Finished Review · ✅ Success · Started 1:44 PM UTC · Completed 1:53 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.73 |
Summary
Closes the instrumentation loop for #6702: the pool-org installation token
exhausting the GitHub API budget mid-run left behaviour harness waits failing
blind. Every harness-wait timeout error now carries the polling client's
last-seen GitHub rate-limit state, and a mechanical scanner makes #6702's
closure criterion (zero blind-wait markers across recent e2e runs) checkable
on demand.
Related Issue
Refs #6702 — the missing instrumentation delta of the instrument-then-fix
program (#6705, #6698, #6797/#7879, #8578/#8622, #8036). Deliberately not
Closes: #6702 is disposed of by evidence — the post-merge operationalchecklist (run the 20-run scan on main, resolve the two closure-rule
questions, then close-or-escalate) is task group 4 and stays out of this PR
by design.
Changes
describeRateLimitStatein the GitHub Actions CIbehaviour driver type-asserts the existing
forge.RateLimitReporterandappends
github rate limit: <state>, observed <age> ago(orunknown (no observation yet)) as the final section of every harness-waittimeout error — including timeouts with no poll failures, which previously
carried no quota information at all. Non-implementing clients (GitLab,
plain fakes) are unchanged; the read sits outside the lookup-budget
envelope since
RateLimit()is in-memory client state.skills/e2e-health/scripts/scan-ratelimit-evidence.sh:enumerates completed e2e.yml runs on main, walks every attempt via the
actions attempts API, fetches behaviour-job logs, detects the ci(#6697): make harness-wait timeouts report why the wait failed #6698
blind-wait markers, resolves conclusions from run/attempt metadata (never
log parsing), and emits a JSON report plus human table with verdicts at
both signal levels (any occurrence; retry-masked).
scan-ratelimit-evidence_test.sh(70assertions, zero network — passes under
env -iwith gh removed fromPATH), registered in
make script-test.invocation, reading the two signal levels) with path-scoped allowed-tools;
docs/guides/dev/behaviour-testing.mdgains a rate-limit observabilitysection (lease-boundary/teardown quota logging, timeout state line,
poll-failure markers as the scanner contract).
Testing
make lintpasses (stage changes first, then run)Tests added/updated for new or modified logic
go test -race -count=1 ./pkg/behaviourtest/drivers/ci/githubactions/—5 new rate-limit tests (exact state-line tail shape plus the four timeout
scenarios: no-poll-failure, stale-observation age, non-implementing client
unchanged, unknown-marker); package at 83.6% coverage.
bash skills/e2e-health/scripts/scan-ratelimit-evidence_test.sh— 70/70assertions, exit 0, hermetic.
skills/e2e-health/scripts/scan-ratelimit-evidence.sh --runs 2and thedefault 20-run window — well-formed JSON + verdict table (current main:
0 markers at both signal levels).
make lintPASS;openspec validate instrument-github-rate-limitsvalid.Pre-existing main failures (
make go-test: 17;make script-test: macOSBSD
wc -c) reproduced byte-identically in a baseline worktree at thebase SHA (c0695aa) — not branch-caused.
Checklist
!for breaking changes)Known Issues
Review councils approved with non-blocking advisories (spec review: 20 —
9 MEDIUM / 11 LOW; code review: 8 LOW). Themes:
--runslacks validationbounds; hardcoded marker strings (drift mitigated by the paired test);
OpenSpec artifact sections deviating from canonical templates; specs
codifying already-landed behavior as ADDED requirements; broad
Bash(jq:*)-style allowed-tools grants in SKILL.md; awk marker detectionnot looping for multiple same-line occurrences; testify usage vs the
convention pack's stdlib-only rule (matches the pre-existing package
pattern).
Reported enforcement gaps (from the requirements mapping, deliberately not
patched here):
(
quotaSummary's observed branch untested).slotpool.go/composed.go).not asserted within
pkg/behaviourtest.pollErrors.describeshape with nogitlabci test asserting any poll-failure timeout tail — flagged for
review to pick a reading (forge-neutral vs GitHub-scoped requirement).
This PR was generated by /uf.finale (AI-assisted).