Repository navigation
Conversation
Signed-off-by: eshulman2 <ellashulman1@gmail.com>
E2E tests did not runE2E tests run automatically for pull requests authored by users with write access or higher. For other contributors, someone with write access must add the Reason: See E2E testing guide for details. |
PR Summary by QodoDefine authorized multi-target execution in ADR 0167
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo
1.
|
Signed-off-by: eshulman2 <ellashulman1@gmail.com>
ascerra
left a comment
There was a problem hiding this comment.
I think this is the right shape: one tracker per target, then a normal single-target run, with nothing new in the runner.
I tested the single-target half on a GitLab project with Jira trackers (notes). I didn't build the adapter, so I have nothing on that from experience.
Four things came out of it, inline.
| Use tracker-first dispatch to assess each authorized source target through an | ||
| ordinary single-target Fullsend triage run. |
There was a problem hiding this comment.
I read "ordinary triage" as the stock agent, though in the experiment it is really a CVE assess harness registered as triage. Two things from testing:
- Stock triage picked up a vulnerability tracker and tried to close it as not planned, so it has to be kept off these trackers.
- Registering the assess harness as
triagemeans the repo loses regular triage, which adopting teams will still want.
What worked was a separate agent that uses the triage role. Suggest "a single-target assessment harness that uses the triage role", here and at line 101.
I put that up as its own cve agent in a draft ADR, #9309, so it would help if this one didn't assume the triage name, let's discuss this some more.
| The adapter populates the supported single-target intake from trusted mapping | ||
| and advisory data, then schedules triage through an authorized dispatch path. | ||
| A bot comment cannot impersonate a human command or bypass the harness actor | ||
| minimum. If no supported path can authorize triage, the tracker remains | ||
| visibly pending authorization. Each run verifies its actual origin, branch |
There was a problem hiding this comment.
I couldn't find a path either. The Jira poller drops events from its own account, app accounts and automation-looking names (filterBotEvents in internal/jirapoll/poller.go), so a tracker the adapter creates never dispatches.
In my testing a person started every run, and the experiment's trigger also wants a person to comment. That seems fine for a first version.
Could the decision say so plainly: a person starts each run, and the adapter doesn't schedule yet?
| visibly pending authorization. Each run verifies its actual origin, branch | ||
| and source revision against the selected intake; a release target must not | ||
| silently fall back to the default branch. The run owns its checkout, context, |
There was a problem hiding this comment.
Agree with the rule, but nothing gives a run its branch today. The dispatch record has no ref (ExecutionRef in internal/harnessdispatch/ref.go), and Jira-sourced runs use "the pinned default branch".
So the pre-script has to fetch and check out the branch, as the experiment does and I did (code). That swapped out the run's own .fullsend directory and cost me a published verdict on v0.55.0, until I restored the checkout (code).
Could the ADR pick one: a ref on the dispatch (a core change), or the harness does it and must restore the checkout?
| bounds do not silently reset. Domain mapping, Jira rendering and aggregate | ||
| accounting remain in the workflow adapter. This initial route introduces no | ||
| native Fullsend multi-target scheduler or plan/result API. Later platform |
There was a problem hiding this comment.
Keeping the workflow generic is what we want, so I like this. Two things I'd add to the ADR:
- What changes in fullsend or the agents repo. From testing: an assessment harness, a way to start a run on a tracker automation created, and a branch for the run.
- Where the adapter lives and how a second team gets it. Is there a consumer besides CVE yet?
Also, I have nothing for getting from a tracker to its repo and branch. Is the experiment's release-mappings.yaml format the adapter's business, or something fullsend should define?
Summary
When one request maps to several maintained branches, a trusted workflow adapter creates or reuses one investigation ticket per authorized target before applicability is known. It then schedules ordinary single-target Fullsend triage and retains case-wide bounds and accounting. This ADR chooses that initial route instead of requiring a new native multi-target runner interface.
Related Issue
Integration and acceptance are tracked in #9260. Durable recovery remains separate in #9253 / PR #9264, and strict Pi tool selection remains in #9254 / PR #9265. This documentation PR implements none of those capabilities and closes no implementation issue.
Changes
0167-use-tracker-first-dispatch.md; no ADR accepted on main is rewritten.The initial tracker adapter uses Jira for source targets on GitHub, GitLab or Forgejo only where the selected single-target execution path verifies source identity and authorization. Unsupported combinations stay blocked. Domain mapping and Jira rendering stay in the consumer adapter; this decision does not add a generic queue, native multi-target scheduler or plan/result API to Fullsend.
Current-behavior evidence
Inspected source baseline:
ef7c61ec1e703f5032ccac96201f107f6b1ec3f6.harnessdispatch.Dispatchapplies configured authorization and matches harnesses for an event.ProjectExecutionRefmaps the matched harness and work-item event to an individual execution record.jirapoll.Runsupplies Jira work-item routing while documenting the shell scheduling-acknowledgement gap; this proposal does not claim publication or distributed recovery is already complete.Testing
make lint; applicable ADR, Markdown link, secret and Semgrep checks pass.git diff --checkpasses.Checklist
Prepared with coding-agent assistance; the contributor can assess the personal-authorship attestation.