Repository navigation
Conversation
…ode agent Record the decision to add a first-party cve agent that assesses one public vulnerability against one branch without changing anything, and to hand any fix to the existing code agent, which works only from a current verdict. Adds ADR 0169 and the matching lines in architecture.md and the agent-architecture problem document. No implementation is included. A prototype is on the cve-assessment-agent branch of fullsend-ai/agents. Signed-off-by: Adam Scerra <ascerra@redhat.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 3:44 AM UTC · Completed 3:54 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.45 |
Site previewPreview: https://9b668fdd-site.fullsend-ai.workers.dev Commit: |
|
Risk Assessment: moderate (2/5) DetailsDocumentation-only PR adding ADR 0169 with low metadata risk, elevated to moderate by high commit churn, author contention, and co-change coupling on docs/architecture.md. |
ReviewFindingsLow
Labels: ADR-only documentation PR; ADR PRs in this repo carry type/adr and component/docs. |
| vulnerability reaches a verdict before either acts on it. | ||
| - A fix takes two runs with a person between them by default, which is slower | ||
| than one run and keeps a person on the verdict. | ||
| - The check that holds a change to the verdict's plan covers the code agent |
There was a problem hiding this comment.
[low] auth-bypass
Decision item 4 (Handoff) has a host check reject code-agent changes outside the files in the verdict plan. Consequences says the check "covers the code agent only; the fix agent, which acts on review findings, needs the same check." The ADR names this gap but does not decide to close it, so the Decision never says whether the fix agent will be bound to the current verdict and its file list. The ADR already discloses the gap and this PR is docs-only, so nothing is bypassable today. This is advisory; wording the requirement is a design choice for the author.
Suggested fix: Move the fix-agent requirement into Decision item 4 (host enforces the same current-verdict and file-scope checks on fix-agent changes, and a change needing more files requires a new assessment), or state that the workflow must not be enabled until a later decision covers it.
Summary
Records the decision to add a first-party
cveagent that assesses one public vulnerability against one branch without changing anything, and to hand any fix to the existing code agent, which works only from a current verdict. Draft, for discussion alongside #9266, #9264 and #9265.Related Issue
No tracking issue yet. Related: #9266 (dispatch to several targets), #9264 (recovery), #9265 (Pi tool selection), #2513 and #8944 (private tracker content and public repositories).
Changes
docs/architecture.md: one "Decided, not yet implemented" line under Agent Registry.docs/problems/agent-architecture.md: a short role entry that links the ADR and names what stays open.No implementation is in this PR.
What the ADR does not decide
Evidence for claims about current behavior
fullsend at
8ef5d3d954653a7316e2a1af953ca4eac7cdf175, agents at3b40ac718d29c3190b71e68447b9f4e938f19974, the experiment repository at42b1a2eec8ef3b4513f56a576b09e82154483d01.actionfrom a fixed list with no verdict or branch (schema L10–L13)timeout_minutes: 10triage, and keeps a controller in the repositoryconfig.yaml,harness/triage-jira.yaml,scripts/cve_workflow.pyreadonly_repoFULLSEND_PRESCRIPT_OUTPUTandskipped=trueready-to-codeor/fs-codeharness/code.yamltriggerCODE_ALLOWED_TARGET_BRANCHESin the post-scriptExecutionRef); a Jira-sourced GitLab run is "an agent pipeline on the pinned default branch"Prototype
A prototype is on the
cve-assessment-agentbranch of fullsend-ai/agents. It is not part of this PR and is not proposed for merge as it stands.What was run with it (notes):
claudeandpiruntimes: an affected verdict on a release branch, a fixed verdict on the default branch, and the handoff to the code agent, which opened a change against the release branch within the planned files.What it did not show, and what went wrong, is listed in the same notes. The main gaps are that the fix agent is not held to the verdict's plan, that nothing maps a tracker to its repository and branch, and that GitHub was not run hosted.
Testing
make lintpasses (stage changes first, then run)Ran the repository's pre-commit hooks over this change (
pre-commit run --from-ref origin/main --to-ref HEAD), which is whatmake lintruns: all passed, including the three ADR hooks, the docs and Markdown link checks and secret detection.gitlintpasses on the commit. No code changes, so no tests.Checklist
!for breaking changes)🤖 Generated with Claude Code