Repository navigation
docs(#8866): drop forge-specific rationale from top-level fields - #8867
Conversation
The "Fields that stay at top level only" table in harness-fields.md restated in nearly every row that the field is "forge-agnostic", "not forge-specific", or "not a ForgeConfig field". The section heading and intro already say these fields cannot be overridden per forge, so the per-row negatives were redundant. Each row now keeps only its concise semantic description; ADR references and "Planned, not yet implemented" notes are preserved. The plugins row's note that a key under forge:/overlays: is ignored rather than rejected applies to every field in the table (ForgeConfig is decoded non-strictly), so it moves into the table intro once. Note: pre-commit could not fetch remote hook repos in the sandbox (TLS error); the applicable pre-commit-hooks v6.0.0 hooks were run directly and passed, and scan-secrets (gitleaks) passed. Closes #8866 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 3:56 PM UTC · Completed 4:01 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.84 |
Site previewPreview: https://7eed9be5-site.fullsend-ai.workers.dev Commit: |
|
<!-- fullsend:risk-assessment --> DetailsLow-risk documentation cleanup by a bot with clean metadata and matching issue scope, elevated to moderate due to high recent churn, author contention, and regression history on the touched documentation files. Previous run<!-- fullsend:risk-assessment --> DetailsLow-risk documentation cleanup by a bot with clean metadata and matching issue scope, elevated to moderate due to high recent churn (22 commits in 30 days) and regression history on docs/contributing/harness-fields.md. |
|
Looks good to me Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOltdfQ== --> Looks good to me |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
/fs-fix I expanded the scope of the issue, see my comment on the related issue and make more changes. |
|
🤖 Finished Fix · ✅ Success · Started 8:45 AM UTC · Completed 8:48 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.31 |
Per the expanded scope on #8866, remove the "not a ForgeConfig field" and "platform-neutral" rationale outside the top-level-only table: the table intro in harness-fields.md and the plugins and privilege_levels entries in harness-reference.md. The behavioral note that such keys under forge:/overlays: are silently ignored is kept. Note: pre-commit could not fetch remote hook repos in the sandbox (TLS error); git diff --check and lychee --offline passed, and scan-secrets passed. Addresses #8867 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 1 (human-triggered)Following the expanded scope from the #8866 comment, removed the remaining forge-specific rationale ('not a ForgeConfig field', 'platform-neutral') from harness-reference.md (privilege_levels, plugins, merge table) and the table intro in harness-fields.md, keeping the 'silently ignored' behavior notes. ADRs and general architecture prose were left alone. Docs-only change; lychee offline link check, git diff --check and scan-secrets passed. pre-commit could not fetch hook repos in the sandbox (TLS error). Project CI on the PR is passing. Fixed (2):
Tests: passed CI inspections (4):
Conflict update: skipped; strategy Decision points
Next steps:
|
|
🤖 Finished Review · ✅ Success · Started 8:50 AM UTC · Completed 8:58 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.07 |
Superseded by updated review
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that #8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: #8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Summary
Removes the redundant "forge-agnostic" / "not forge-specific" / "not a
ForgeConfigfield" wording from the Fields that stay at top level only table indocs/contributing/harness-fields.md. The section already says these fields cannot be overridden per forge, so repeating it in each row added nothing.Related Issue
Follow-up from the #8833 review comment by @rh-hemartin.
Changes
agent,role,security,effort) now name what the field holds.pluginsrow said that aplugins:key underforge:/overlays:"is ignored, not an error". That is true for every field in this table:ForgeConfigis decoded with plainyaml.Unmarshaland lists only the overridable fields. So the note now appears once, in the table intro.docs/reference/harness-reference.mdstill documents this per field forpluginsandprivilege_levels.Testing
forge-agnostic,not forge-specific,not a `ForgeConfig` field,Top level only. Nothing is left in the rows.lychee --offline --include-fragmentson the changed file found 0 errors.scan-secrets(gitleaks) passed.pre-commit runitself could not fetch remote hook repos in the sandbox (TLS certificate error). I ran the pre-commit-hooks v6.0.0 hooks that apply to Markdown directly (end-of-file-fixer, trailing-whitespace, detect-private-key, check-merge-conflict, mixed-line-ending, check-added-large-files) and they all passed.🤖 Generated with Claude Code
Closes #8866
Post-script verification
agent/8866-harness-fields-drop-forge-rationale)ea70926904469254041f2828ba5ba1fea284e63d..HEAD)