Skip to content

docs(#8866): drop forge-specific rationale from top-level fields - #8867

Merged
rh-hemartin merged 2 commits into
mainfrom
agent/8866-harness-fields-drop-forge-rationale
Oct 28, 2026
Merged

rh-hemartin merged 2 commits into
mainfrom
agent/8866-harness-fields-drop-forge-rationale

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Removes the redundant "forge-agnostic" / "not forge-specific" / "not a ForgeConfig field" wording from the Fields that stay at top level only table in docs/contributing/harness-fields.md. The section already says these fields cannot be overridden per forge, so repeating it in each row added nothing.

Related Issue

Follow-up from the #8833 review comment by @rh-hemartin.

Changes

  • Each row in the top-level-only table now keeps only a short description of what the field is. Rows that were only the negative clause (e.g. agent, role, security, effort) now name what the field holds.
  • Kept all ADR references and the Planned, not yet implemented notes.
  • The plugins row said that a plugins: key under forge:/overlays: "is ignored, not an error". That is true for every field in this table: ForgeConfig is decoded with plain yaml.Unmarshal and lists only the overridable fields. So the note now appears once, in the table intro. docs/reference/harness-reference.md still documents this per field for plugins and privilege_levels.
  • The ForgeConfig-fields table, whose "may need forge-specific ..." text explains why those fields can be overridden, is unchanged.

Testing

  • Grepped the table for forge-agnostic, not forge-specific, not a `ForgeConfig` field, Top level only. Nothing is left in the rows.
  • lychee --offline --include-fragments on the changed file found 0 errors.
  • scan-secrets (gitleaks) passed.
  • pre-commit run itself could not fetch remote hook repos in the sandbox (TLS certificate error). I ran the pre-commit-hooks v6.0.0 hooks that apply to Markdown directly (end-of-file-fixer, trailing-whitespace, detect-private-key, check-merge-conflict, mixed-line-ending, check-added-large-files) and they all passed.
  • No code changes, so no tests were added.

🤖 Generated with Claude Code


Closes #8866

Post-script verification

  • Branch is not main/master (agent/8866-harness-fields-drop-forge-rationale)
  • Secret scan passed (gitleaks — ea70926904469254041f2828ba5ba1fea284e63d..HEAD)
  • PR body secret scan passed (gitleaks — no-git)
  • Final PR description secret scan passed (gitleaks — no-git)

The "Fields that stay at top level only" table in harness-fields.md
restated in nearly every row that the field is "forge-agnostic", "not
forge-specific", or "not a ForgeConfig field". The section heading and
intro already say these fields cannot be overridden per forge, so the
per-row negatives were redundant.

Each row now keeps only its concise semantic description; ADR
references and "Planned, not yet implemented" notes are preserved.
The plugins row's note that a key under forge:/overlays: is ignored
rather than rejected applies to every field in the table (ForgeConfig
is decoded non-strictly), so it moves into the table intro once.

Note: pre-commit could not fetch remote hook repos in the sandbox
(TLS error); the applicable pre-commit-hooks v6.0.0 hooks were run
directly and passed, and scan-secrets (gitleaks) passed.

Closes #8866

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:56 PM UTC · Completed 4:01 PM UTC

Commit: 105943e · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.84

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://7eed9be5-site.fullsend-ai.workers.dev

Commit: 8d2954eb35ca350fcc24e8394e35f17ba143dfa3

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 27, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Low-risk documentation cleanup by a bot with clean metadata and matching issue scope, elevated to moderate due to high recent churn, author contention, and regression history on the touched documentation files.

Previous run

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Low-risk documentation cleanup by a bot with clean metadata and matching issue scope, elevated to moderate due to high recent churn (22 commits in 30 days) and regression history on docs/contributing/harness-fields.md.

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Looks good to me

Previous run

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOltdfQ== -->

Looks good to me

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rh-hemartin

Copy link
Copy Markdown
Member

/fs-fix I expanded the scope of the issue, see my comment on the related issue and make more changes.

@fullsend-ai-coder

fullsend-ai-coder Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 8:45 AM UTC · Completed 8:48 AM UTC

Commit: 105943e · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.31

Per the expanded scope on #8866, remove the "not a ForgeConfig field"
and "platform-neutral" rationale outside the top-level-only table:
the table intro in harness-fields.md and the plugins and
privilege_levels entries in harness-reference.md. The behavioral note
that such keys under forge:/overlays: are silently ignored is kept.

Note: pre-commit could not fetch remote hook repos in the sandbox (TLS
error); git diff --check and lychee --offline passed, and scan-secrets
passed.

Addresses #8867

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 1 (human-triggered)

Following the expanded scope from the #8866 comment, removed the remaining forge-specific rationale ('not a ForgeConfig field', 'platform-neutral') from harness-reference.md (privilege_levels, plugins, merge table) and the table intro in harness-fields.md, keeping the 'silently ignored' behavior notes. ADRs and general architecture prose were left alone. Docs-only change; lychee offline link check, git diff --check and scan-secrets passed. pre-commit could not fetch hook repos in the sandbox (TLS error). Project CI on the PR is passing.

Fixed (2):

  1. Expanded scope on harness-fields.md: remove the "not a forge-specific field" rationale text #8866: remove forge-specific rationale beyond the table (docs/reference/harness-reference.md): Dropped the 'not a ForgeConfig field' rationale from the privilege_levels field description, the plugins paragraph, and the privilege_levels merge-table row. Kept the behavioral note that such keys under forge:/overlays: are silently ignored.
  2. Expanded scope on harness-fields.md: remove the "not a forge-specific field" rationale text #8866: table intro still said 'platform-neutral' (docs/contributing/harness-fields.md): Removed 'platform-neutral' from the top-level-only section intro; it now just states the fields cannot be overridden per-forge or per-overlay.

Tests: passed

CI inspections (4):

  1. build (passing, success): Passed.
  2. commit-lint (passing, success): Passed.
  3. pr-title-lint (passing, success): Passed.
  4. gateway-doc-configs (passing, success): Passed.

Conflict update: skipped; strategy none; forge MERGEABLE; target main

Decision points
  • Left ADR 0045 and docs/architecture.md wording unchanged (alternatives: Edit ADR 0045's copy of the table, Edit architecture.md line 124; rationale: ADRs are point-in-time records (harness-fields.md says so); architecture.md describes the forge: section generally, not a per-field rationale for top-level-only fields.)

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:50 AM UTC · Completed 8:58 AM UTC

Commit: 8d2954e · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.07

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Oct 28, 2026
@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review October 28, 2026 08:58

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 28, 2026
@rh-hemartin
rh-hemartin added this pull request to the merge queue Oct 28, 2026
@rh-hemartin
rh-hemartin deleted the agent/8866-harness-fields-drop-forge-rationale branch October 28, 2026 10:29
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 28, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
waynesun09 pushed a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 28, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 28, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 29, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 29, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 29, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 30, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 30, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 30, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 30, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 31, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 31, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 31, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 31, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Oct 31, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 1, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 2, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 2, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 3, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 3, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 4, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 4, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 4, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 4, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 5, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 5, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
jflowers added a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Nov 5, 2026
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
fullsend-ai-coder Bot pushed a commit that referenced this pull request Nov 6, 2026
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that #8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: #8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — 8d2954eb Deployed Oct 28, 2026 by github-actions[bot]
dev — 8d2954eb Deployed Oct 28, 2026 by fullsend-ai-coder[bot] via playback #18124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

harness-fields.md: remove the "not a forge-specific field" rationale text

2 participants