Repository navigation
feat(#235)!: implement harness schema_version (ADR 0127 Decision 1) - #8877
Conversation
PR Summary by QodoAdd parse-time harness schema versioning and base compatibility checks
AI Description
Diagram
High-Level Assessment
Files changed (13)
|
Code Review by Qodo
1.
|
|
🤖 Finished Review · ✅ Success · Started 9:35 PM UTC · Completed 9:50 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.03 |
Site previewPreview: https://f3471104-site.fullsend-ai.workers.dev Commit: |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsModerate risk: well-scoped schema field change with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness without feature-flag rollback. Previous runRisk Assessment: moderate (2/5) DetailsModerate risk: well-scoped schema field change with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness without feature-flag rollback. Previous run (2)Risk Assessment: moderate (2/5) DetailsModerate risk: well-scoped schema field change with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness without feature-flag rollback. Previous run (3)Risk Assessment: moderate (2/5) DetailsModerate risk: well-scoped schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness with no feature flag for rollback. Previous run (4)Risk Assessment: moderate (2/5) DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (5)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (6)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (7)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (8)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (9)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (10)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (11)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (12)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (13)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (14)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (15)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (16)<!-- fullsend:risk-assessment --> DetailsWell-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (17)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (18)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness. Previous run (19)<!-- fullsend:risk-assessment --> DetailsModerate risk (score 2) is preserved from prior assessment for this well-scoped, backward-compatible schema field change with high test coverage (0.54) and zero protected path modifications, balancing active churn and multi-author history in internal/harness. Previous run (20)<!-- fullsend:risk-assessment --> DetailsModerate risk (score 2) is preserved from prior assessment for this well-scoped, backward-compatible schema field change with high test coverage (0.54) and zero protected path modifications, balancing active churn and multi-author history in internal/harness. Previous run (21)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness. Previous run (22)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness. Previous run (23)<!-- fullsend:risk-assessment --> DetailsModerate risk driven by active churn and change coupling in the harness module alongside a breaking validation change without feature-flag rollback, balanced by strong test coverage (>54% test ratio), zero protected or security-sensitive path changes, and direct alignment with issue #235. Previous run (24)<!-- fullsend:risk-assessment --> DetailsModerate risk driven by active churn and change coupling in the harness module alongside a breaking validation change without feature-flag rollback, balanced by strong test coverage (>54% test ratio), zero protected or security-sensitive path changes, and direct alignment with issue #235. Previous run (25)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness. Previous run (26)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness. Previous run (27)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness. Previous run (28)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness. Previous run (29)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. Previous run (30)<!-- fullsend:risk-assessment --> DetailsModerate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness. |
|
Looks good to me Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzE3NDlhZWExMzMzOWFhZDUiLCJsaW5lIjo4NCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jMzFhNjhiN2Y4YzI3YzViIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfYmU5MDkyM2Y0YTNlZGYwNCIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfODY2YzVkZjAwMzg2M2FlNSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzA0Yjc4NGZkYTJmMjk0YmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImFwaS1zaGFwZSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL2hhcm5lc3MuZ28iLCJpZCI6ImZfYzVmM2RjMzNmYjdmNDM4OCIsImxpbmUiOjM3NiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjJmZjU2MGIxMzU0NDlkMyIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl83OWNlMmYxM2ZjYjBiYjAyIiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzY4ODM5ZTU3NDA0ZWYyNmYiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3MvY29udHJpYnV0aW5nL2hhcm5lc3MtZmllbGRzLm1kIiwiaWQiOiJmXzliYmVkZDRlOTBlOTQyNmIiLCJsaW5lIjoxNTgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3MvcmVmZXJlbmNlL2hhcm5lc3MtcmVmZXJlbmNlLm1kIiwiaWQiOiJmX2M1ZTBkNDVkOWNlYmVjNGYiLCJsaW5lIjo1MzgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwYXR0ZXJuLWluY29uc2lzdGVuY3kiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2IxNDY3ZTc4Mjg0MTA1ODAiLCJsaW5lIjo4OSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2MzMWE2OGI3ZjhjMjdjNWIiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYmU5MDkyM2Y0YTNlZGYwNCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl82ODgzOWU1NzQwNGVmMjZmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl85YmJlZGQ0ZTkwZTk0MjZiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IxNDY3ZTc4Mjg0MTA1ODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsLow
Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2MzMWE2OGI3ZjhjMjdjNWIiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9iZTkwOTIzZjRhM2VkZjA0IiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl84NjZjNWRmMDAzODYzYWU1IiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl82MmZmNTYwYjEzNTQ0OWQzIiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzc5Y2UyZjEzZmNiMGJiMDIiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjg4MzllNTc0MDRlZjI2ZiIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvaGFybmVzcy1maWVsZHMubWQiLCJpZCI6ImZfOWJiZWRkNGU5MGU5NDI2YiIsImxpbmUiOjE1OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9yZWZlcmVuY2UvaGFybmVzcy1yZWZlcmVuY2UubWQiLCJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsImxpbmUiOjUzOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfYjE0NjdlNzgyODQxMDU4MCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYzMxYTY4YjdmOGMyN2M1YiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9iZTkwOTIzZjRhM2VkZjA0Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfODY2YzVkZjAwMzg2M2FlNSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8wNGI3ODRmZGEyZjI5NGJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNjJmZjU2MGIxMzU0NDlkMyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl83OWNlMmYxM2ZjYjBiYjAyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzY4ODM5ZTU3NDA0ZWYyNmYiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzliYmVkZDRlOTBlOTQyNmIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9jNWUwZDQ1ZDljZWJlYzRmIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYjE0NjdlNzgyODQxMDU4MCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsLow
Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2MzMWE2OGI3ZjhjMjdjNWIiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9iZTkwOTIzZjRhM2VkZjA0IiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl84NjZjNWRmMDAzODYzYWU1IiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl82MmZmNTYwYjEzNTQ0OWQzIiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzc5Y2UyZjEzZmNiMGJiMDIiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjg4MzllNTc0MDRlZjI2ZiIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvaGFybmVzcy1maWVsZHMubWQiLCJpZCI6ImZfOWJiZWRkNGU5MGU5NDI2YiIsImxpbmUiOjE1OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9yZWZlcmVuY2UvaGFybmVzcy1yZWZlcmVuY2UubWQiLCJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsImxpbmUiOjUzOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfYjE0NjdlNzgyODQxMDU4MCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYmU5MDkyM2Y0YTNlZGYwNCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl82ODgzOWU1NzQwNGVmMjZmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl85YmJlZGQ0ZTkwZTk0MjZiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IxNDY3ZTc4Mjg0MTA1ODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsLow
Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2JlOTA5MjNmNGEzZWRmMDQiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfZTJkYzkxYTE5YTFiMWMyYSIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8wNGI3ODRmZGEyZjI5NGJhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl82ODgzOWU1NzQwNGVmMjZmIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb3JyZWN0LWRvYyIsImZpbGUiOiJkb2NzL2NvbnRyaWJ1dGluZy9oYXJuZXNzLWZpZWxkcy5tZCIsImlkIjoiZl85YmJlZGQ0ZTkwZTk0MjZiIiwibGluZSI6MTU4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb3JyZWN0LWRvYyIsImZpbGUiOiJkb2NzL3JlZmVyZW5jZS9oYXJuZXNzLXJlZmVyZW5jZS5tZCIsImlkIjoiZl9jNWUwZDQ1ZDljZWJlYzRmIiwibGluZSI6NTM4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoicGF0dGVybi1pbmNvbnNpc3RlbmN5IiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9iMTQ2N2U3ODI4NDEwNTgwIiwibGluZSI6ODksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl85YmJlZGQ0ZTkwZTk0MjZiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IxNDY3ZTc4Mjg0MTA1ODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl82ODgzOWU1NzQwNGVmMjZmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifV19 --> ReviewFindingsLow
Earlier findings
Previous run (5)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvaGFybmVzcy1maWVsZHMubWQiLCJpZCI6ImZfOWJiZWRkNGU5MGU5NDI2YiIsImxpbmUiOjE1OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9yZWZlcmVuY2UvaGFybmVzcy1yZWZlcmVuY2UubWQiLCJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsImxpbmUiOjUzOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfYjE0NjdlNzgyODQxMDU4MCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl84NjZjNWRmMDAzODYzYWU1IiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl82MmZmNTYwYjEzNTQ0OWQzIiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzc5Y2UyZjEzZmNiMGJiMDIiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjg4MzllNTc0MDRlZjI2ZiIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfODY2YzVkZjAwMzg2M2FlNSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8wNGI3ODRmZGEyZjI5NGJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNjJmZjU2MGIxMzU0NDlkMyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl83OWNlMmYxM2ZjYjBiYjAyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNjg4MzllNTc0MDRlZjI2ZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJzdGF0dXMiOiJvcGVuIn1dfQ== --> ReviewFindingsMedium
Low
Next steps:
Previous run (6)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8wNGI3ODRmZGEyZjI5NGJhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzY4ODM5ZTU3NDA0ZWYyNmYiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl82MmZmNTYwYjEzNTQ0OWQzIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl84NjZjNWRmMDAzODYzYWU1Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifV19 --> Looks good to me Earlier findings
No findings at or above Previous run (7)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjJmZjU2MGIxMzU0NDlkMyIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzc5Y2UyZjEzZmNiMGJiMDIiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfODY2YzVkZjAwMzg2M2FlNSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYzVmM2RjMzNmYjdmNDM4OCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoib3BlbiJ9XX0= --> ReviewFindingsLow
Previous run (8)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfZTJkYzkxYTE5YTFiMWMyYSIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfZTJkYzkxYTE5YTFiMWMyYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl84NjZjNWRmMDAzODYzYWU1Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifV19 --> ReviewFindingsLow
Previous run (9)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfZTJkYzkxYTE5YTFiMWMyYSIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoib3BlbiJ9XX0= --> ReviewFindingsLow
1 finding(s) below the Previous run (10)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfYzVmM2RjMzNmYjdmNDM4OCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwic3RhdHVzIjoib3BlbiJ9XX0= --> ReviewFindingsLow
Earlier findings
1 finding(s) below the Previous run (11)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9XX0= --> ReviewFindingsLow
Earlier findings
1 finding(s) below the Previous run (12)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1zaGFwZSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL2hhcm5lc3MuZ28iLCJpZCI6ImZfYzVmM2RjMzNmYjdmNDM4OCIsImxpbmUiOjM3NiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9XX0= --> ReviewFindingsLow
1 finding(s) below the Previous run (13)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsImxpbmUiOjc3LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9XX0= --> ReviewFindingsLow
Earlier findings
1 finding(s) below the Previous run (14)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6NzcsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifV19 --> ReviewFindingsLow
Previous run (15)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM3LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6NzcsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn1dfQ== --> ReviewFindingsLow
Previous run (16)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo3NywiYWN0aW9uYWJsZSI6ZmFsc2V9XX0= --> ReviewFindingsLow
Previous run (17)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOltdfQ== --> Looks good to me Previous run (18)ReviewFindingsLow
Info
3 finding(s) below the Previous run (19)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL2hhcm5lc3MuZ28iLCJpZCI6ImZfZDU1MTcwZTZlNjgyMDZlZiIsImxpbmUiOjQ4OCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmXzA0ZGUzNTYyYTVmNDRkY2IiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctY29uZmlnIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9hMGNlYzUyMDQ1YTBiM2Y5IiwibGluZSI6OTAsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9lYzliNTM1Nzk4MGQxYTRjIiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzdhMjY2NjU2NmFiMTkwZDQiLCJsaW5lIjo5OCwiYWN0aW9uYWJsZSI6dHJ1ZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl9kNTUxNzBlNmU2ODIwNmVmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzA0ZGUzNTYyYTVmNDRkY2IiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYTBjZWM1MjA0NWEwYjNmOSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9lYzliNTM1Nzk4MGQxYTRjIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfN2EyNjY2NTY2YWIxOTBkNCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsLow
|
85a6f84 to
ead4c5e
Compare
|
🤖 Finished Review · ✅ Success · Started 10:34 PM UTC · Completed 10:43 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.32 |
ead4c5e to
5ab8af8
Compare
|
🤖 Finished Review · ✅ Success · Started 8:11 AM UTC · Completed 8:26 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.34 |
|
🤖 Finished Review · ✅ Success · Started 9:57 AM UTC · Completed 10:19 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.31 |
|
🤖 Finished Review · ✅ Success · Started 2:36 PM UTC · Completed 2:45 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.47 |
|
🤖 Finished Review · ✅ Success · Started 5:56 PM UTC · Completed 6:07 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.23 |
|
🤖 Finished Review · ❌ Failure (validation failed after 1 iteration(s)) · Started 11:30 PM UTC · Completed 11:53 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.50 |
|
🤖 Finished Review · ✅ Success · Started 3:43 AM UTC · Completed 3:57 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.39 |
|
🤖 Finished Review · ✅ Success · Started 11:39 AM UTC · Completed 11:48 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.71 |
…cision 1) The harness YAML is fullsend's most-edited cross-repository contract but carried no version: when a field's semantics change, harnesses in consumer repositories break silently or with unactionable errors, and migration tooling has no handle for knowing which schema a file was written against. - Add a top-level schema_version field on harness YAML; absent means version 1, so every existing harness remains valid unchanged. - Enforce version-aware loading: every parse entry point (Load, LoadRaw, LoadWithOpts, LoadWithBase, URL-fetched base content, local and remote discovery) rejects malformed, zero, negative, and unsupported versions at parse time, before fields are interpreted under version-1 semantics. - Guard base-layer composition: each raw base: layer's effective version is validated before merging, and mixed-version layers are rejected (only equal effective versions compose). - Reject with actionable errors naming schema_version, the offending value, the supported range, and the upgrade remedy. - Move schema_version from "Planned, not yet implemented" to the implemented contract in docs/contributing/harness-fields.md, docs/architecture.md, and docs/reference/harness-reference.md. BREAKING CHANGE: harness YAML declaring a malformed, zero, negative, or unsupported schema_version now fails to load at parse time; previously the field was ignored (absent semantics) and the harness loaded. Assisted-by: glm-5 Generated with AI assistance (glm-5) AI-Assisted: true Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…reference Reword the example comment to say the field "defaults to `1`" instead of "absent = 1", and state in the Malformed error-shape bullet that every float is rejected — including integral spellings such as `1.0`, not only fractional ones such as `1.5` — matching what UnmarshalYAML enforces. Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin and @fullsend-ai-review[bot]. AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Keep the ADR citation on the two property-definition declarations (MaxSupportedSchemaVersion, schemaVersionValue) where the contract is defined, and drop it from the helper comments below. Repeated ADR references on every schema_version-adjacent function train contributors to sprinkle the citation everywhere it is not needed. Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin. AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Rename schemaVersionsCompatible to schemaVersionsCompose and checkSchemaVersionCompatibility to checkSchemaVersionsCompose. The old names read as checks against the build's maximum supported version; the functions actually decide whether a base layer's effective schema version composes into the harness inheriting it. The predicate stays a separate function: it is the single extension point where a future cross-version composition rule will live (design D3), kept out of the pure merge so it can be tested directly. All references are unexported and contained to internal/harness: the two definitions, two call sites in compose.go (LoadWithBase, loadBaseChain), one merge-table comment, and the tracking tests. Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin. AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Format layerLabel with %q in the checkSchemaVersionsCompose error. The label is the harness author's base: reference (a path or URL), and docs/contributing/go-code.md requires %q for user-provided values in error messages; compose.go already quotes base references this way in its own errors. Update the two ErrorContains assertions that pinned the unquoted form. Addresses PR fullsend-ai#8877 review feedback from @fullsend-ai-review[bot]. AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Commit 8037305 renamed checkSchemaVersionCompatibility to checkSchemaVersionsCompose and renamed its direct-coverage test, but two doc comments in compose_test.go still referenced the pre-rename test name. Update both to TestCheckSchemaVersionsCompose_ConstructedMixedVersions. Found by the review-council advisory (divisor-testing). AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The merge previously copied the base's explicit schema_version onto an absent child. That inheritance went beyond ADR 0127 Decision 1, which spells an absent schema_version as version 1 and defers all cross-version behavior to an explicit compatibility rule; inheriting would relabel a v1-by-absence child as the base's version the moment such a rule exists. Equal effective versions still compose — that guard is unchanged — but the merged harness now keeps the child's own declaration: an absent child stays absent (version 1), and the reference doc no longer promises inheritance. Review: fullsend-ai#8877 AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style
The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The remedy clause restated the declared version the opening clause had
already named ("upgrade fullsend to a release that supports
schema_version N" for a message that opens "schema_version N is not
supported"). Drop the repetition in favor of "supports it", matching the
reference prose, which already phrases the remedy that way. The message
still names every element the spec requires: field, declared value,
maximum, and remedy.
Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin.
Review: fullsend-ai#8877
AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The schema_version section documented only the forward direction of the compatibility contract: an older binary meeting a newer file fails with an upgrade remedy. State the backward direction too: a build loads any declared version from 1 through its maximum supported version, and the maximum only grows across releases, so newer binaries read older files. Note that whether a future version may stop interpreting older-version field semantics is left to the cross-version policy ADR 0127 does not set. Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin. Review: fullsend-ai#8877 AI-Assisted: true Assisted-by: glm-5 Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
checkSchemaVersionsCompose and schemaVersionsCompose took (child, base) while mergeBaseIntoChild and the other merge helpers take (base, child), so the compose.go call sites flipped argument order on consecutive lines. Reorder both helpers and update the call sites and tests; no behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Both merge-rule tables classed schema_version under the generic scalar row, which says an absent value inherits from base. mergeBaseIntoChild deliberately does not inherit it: the merged harness keeps the child's own declaration, and composed layers must share one effective version. Add an explicit row to each table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
|
🤖 Finished Review · ✅ Success · Started 7:04 PM UTC · Completed 7:20 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.52 |
Summary
Implements issue #235 — schema versioning for harness definition files (ADR 0127 Decision 1, first sub-issue of epic #8720). Adds a
schema_versiontop-level scalar field on harness YAML where absent means version 1, so every existing harness in fullsend-ai/agents and consumer repositories remains valid unchanged. All parsing entry points reject malformed, zero, negative, and unsupported versions at load time with actionable errors, and base-layer composition enforces version compatibility across layers.Related Issue
Closes #235 — the harness YAML is fullsend's most-edited cross-repository contract but carried no version: when a field's semantics change, harnesses in consumer repositories break silently or with unactionable errors, and there is no handle for migration tooling. First sub-issue of epic #8720 (implement ADRs 0127, 0128, 0129).
Changes
schema_versionscalar field on harness YAML; absent means version 1 (internal/harness/schemaversion.go,internal/harness/harness.go)Load,LoadRaw,LoadWithOpts,LoadWithBase, URL-fetched base content, local and remote discovery) rejects malformed, zero, negative, and unsupported versions during parsing — a load failure, not a non-fatalLint()finding — with errors naming the field, the offending value, the supported range, and the upgrade remedyUnmarshalYAMLrejects float-tagged scalars (schema_version: 1.5), since yaml.v3 silently truncates fractional floats into int fieldsbase:layer's effective version is validated before every merge point; mixed-version layers are rejected (only equal effective versions compose), and the merged harness keeps the child's own declarationschema_versionmoves from "Planned, not yet implemented" to the implemented contract (docs/contributing/harness-fields.md,docs/architecture.md,docs/reference/harness-reference.md)Review advisories (non-blocking): spec review APPROVE WITH ADVISORIES (12 advisories, 3 MEDIUM); code review APPROVE WITH ADVISORIES (7 advisories, 1 MEDIUM, all documentation-level).
Testing
make lintpasses (stage changes first, then run)Tests added/updated for new or modified logic
go build ./... && go vet ./internal/harness/— cleango test ./internal/harness/ -run 'SchemaVersion|TestYAMLSemantics' -count=1— absent/null/tildeschema_versionloads as version 1;0,-1,2,"one",1.5rejected at parse with actionable errorsgo test ./internal/harness/ -run 'Compose|Base|SchemaVersion' -count=1— equal effective versions compose; aschema_version: 2base file is rejected at load time with the unsupported-version error before composition (the mixed-version composition error itself is exercised with directly constructed harnesses, since parse rejects the raw form first)go test ./internal/harness/ -run 'Discover' -count=1 && go test ./internal/cli/... ./internal/harnessdispatch/...— passFull
go test -race ./...— 75 packages ok; 4 packages fail with 16 pre-existing machine-environment failures verified identical at a baseline worktree of upstream/main (gitlab TLS x509, repos containment, runtime env-hygiene, scaffold PyYAML-in-subprocess) — none branch-causedPatch coverage 94.6% of changed Go statements (80% target / 75% floor met)
openspec validate harness-schema-versioning— validRelease note
Release note: Harnesses that declare
schema_versionrequire a fullsend build that includes this change. A zero, negative, non-integer, or unsupportedschema_versionnow fails to load (it was previously ignored), and abase:layer must declare the same effective version as the harness composing it.Checklist
!for breaking changes)This PR was generated by /uf.finale (AI-assisted).