Skip to content

feat(#235)!: implement harness schema_version (ADR 0127 Decision 1) - #8877

Merged
jflowers merged 12 commits into
fullsend-ai:mainfrom
jflowers:opsx/harness-schema-versioning
Nov 5, 2026
Merged

jflowers merged 12 commits into
fullsend-ai:mainfrom
jflowers:opsx/harness-schema-versioning

Conversation

@jflowers

@jflowers jflowers commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Implements issue #235 — schema versioning for harness definition files (ADR 0127 Decision 1, first sub-issue of epic #8720). Adds a schema_version top-level scalar field on harness YAML where absent means version 1, so every existing harness in fullsend-ai/agents and consumer repositories remains valid unchanged. All parsing entry points reject malformed, zero, negative, and unsupported versions at load time with actionable errors, and base-layer composition enforces version compatibility across layers.

Related Issue

Closes #235 — the harness YAML is fullsend's most-edited cross-repository contract but carried no version: when a field's semantics change, harnesses in consumer repositories break silently or with unactionable errors, and there is no handle for migration tooling. First sub-issue of epic #8720 (implement ADRs 0127, 0128, 0129).

Changes

  • Add a top-level schema_version scalar field on harness YAML; absent means version 1 (internal/harness/schemaversion.go, internal/harness/harness.go)
  • Version-aware loading: every parse entry point (Load, LoadRaw, LoadWithOpts, LoadWithBase, URL-fetched base content, local and remote discovery) rejects malformed, zero, negative, and unsupported versions during parsing — a load failure, not a non-fatal Lint() finding — with errors naming the field, the offending value, the supported range, and the upgrade remedy
  • Named-type UnmarshalYAML rejects float-tagged scalars (schema_version: 1.5), since yaml.v3 silently truncates fractional floats into int fields
  • Composition guard: each raw base: layer's effective version is validated before every merge point; mixed-version layers are rejected (only equal effective versions compose), and the merged harness keeps the child's own declaration
  • Docs: schema_version moves from "Planned, not yet implemented" to the implemented contract (docs/contributing/harness-fields.md, docs/architecture.md, docs/reference/harness-reference.md)

Review advisories (non-blocking): spec review APPROVE WITH ADVISORIES (12 advisories, 3 MEDIUM); code review APPROVE WITH ADVISORIES (7 advisories, 1 MEDIUM, all documentation-level).

Testing

  • make lint passes (stage changes first, then run)

  • Tests added/updated for new or modified logic

  • go build ./... && go vet ./internal/harness/ — clean

  • go test ./internal/harness/ -run 'SchemaVersion|TestYAMLSemantics' -count=1 — absent/null/tilde schema_version loads as version 1; 0, -1, 2, "one", 1.5 rejected at parse with actionable errors

  • go test ./internal/harness/ -run 'Compose|Base|SchemaVersion' -count=1 — equal effective versions compose; a schema_version: 2 base file is rejected at load time with the unsupported-version error before composition (the mixed-version composition error itself is exercised with directly constructed harnesses, since parse rejects the raw form first)

  • go test ./internal/harness/ -run 'Discover' -count=1 && go test ./internal/cli/... ./internal/harnessdispatch/... — pass

  • Full go test -race ./... — 75 packages ok; 4 packages fail with 16 pre-existing machine-environment failures verified identical at a baseline worktree of upstream/main (gitlab TLS x509, repos containment, runtime env-hygiene, scaffold PyYAML-in-subprocess) — none branch-caused

  • Patch coverage 94.6% of changed Go statements (80% target / 75% floor met)

  • openspec validate harness-schema-versioning — valid

Release note

Release note: Harnesses that declare schema_version require a fullsend build that includes this change. A zero, negative, non-integer, or unsupported schema_version now fails to load (it was previously ignored), and a base: layer must declare the same effective version as the harness composing it.

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Commits are signed off (DCO) — human and human-directed agent sessions only
  • I wrote this contribution myself and can explain all changes in it

I wrote this contribution with AI assistance and cannot explain all changes in it.

This PR was generated by /uf.finale (AI-assisted).

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Add parse-time harness schema versioning and base compatibility checks

✨ Enhancement 🧪 Tests 📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• Add an optional schema_version field that defaults to version 1, preserving existing harnesses.
• Reject invalid or unsupported versions during loading and prevent mixed-version base composition.
• Document the contract and test loading, composition, discovery, and dispatch behavior.
Diagram

graph TD
  Y["Harness YAML"] --> E["Load entry points"] --> P["Shared parser"] --> V{"Version valid"}
  V -- "yes" --> C{"Base layer"} -- "compatible" --> M["Merge layers"] --> R["Resolve harness"]
  V -- "invalid" --> X["Load failure"]
  C -- "mixed" --> X
  C -- "no base" --> R
Loading
High-Level Assessment

Keep the shared parse-time check and pre-merge compatibility guard: they preserve legacy harnesses while preventing newer schemas from being interpreted as version 1. A separate YAML pre-pass was considered but would duplicate parsing without improving coverage of the existing load paths.

Files changed (13) +729 / -39

Enhancement (3) +160 / -17
compose.goGuard base merges by effective schema version +36/-7

Guard base merges by effective schema version

• Checks compatibility before both base-chain and child-base merges, and carries an explicit base declaration into an absent child. Routes URL-fetched base content through the shared parser.

internal/harness/compose.go

harness.goExpose schema_version and validate it in shared parsing +25/-10

Expose schema_version and validate it in shared parsing

• Adds an optional top-level schema version field. Routes Load through parseRaw and validates the declaration there so raw and higher-level loaders share parse-time rejection.

internal/harness/harness.go

schemaversion.goImplement schema version decoding and compatibility +99/-0

Implement schema version decoding and compatibility

• Defines the supported version, effective-version default, validation errors, and equal-version composition rule. A custom YAML scalar decoder rejects fractional floats rather than allowing integer truncation.

internal/harness/schemaversion.go

Tests (7) +512 / -0
compose_test.goTest version-aware base composition +145/-0

Test version-aware base composition

• Covers equal effective versions, explicit-version inheritance, unsupported local bases, and constructed mixed-version pairs.

internal/harness/compose_test.go

discover_remote_test.goTest remote discovery with an unsupported version +23/-0

Test remote discovery with an unsupported version

• Verifies remote discovery reports the invalid file while still returning identity from a valid file.

internal/harness/discover_remote_test.go

discover_test.goTest local discovery with an unsupported version +22/-0

Test local discovery with an unsupported version

• Verifies local discovery aggregates the version error without discarding valid discovered agents.

internal/harness/discover_test.go

harness_test.goTest version handling across harness loaders +137/-0

Test version handling across harness loaders

• Checks accepted defaults and explicit version 1, malformed and out-of-range values, and rejection before forge resolution.

internal/harness/harness_test.go

schemaversion_test.goUnit-test schema version rules +112/-0

Unit-test schema version rules

• Tests valid defaults, unsupported and nonpositive versions, effective-version lookup, and compatibility diagnostics.

internal/harness/schemaversion_test.go

yaml_semantics_test.goPin absent and null YAML version semantics +21/-0

Pin absent and null YAML version semantics

• Confirms absent, null, and tilde declarations remain unset while an explicit integer declaration is retained.

internal/harness/yaml_semantics_test.go

enumerate_test.goTest dispatch reporting for unsupported harnesses +52/-0

Test dispatch reporting for unsupported harnesses

• Verifies enumeration skips a registered harness with an unsupported version and surfaces its load failure in both the returned error and annotation.

internal/harnessdispatch/enumerate_test.go

Documentation (3) +57 / -22
architecture.mdRecord schema versioning as implemented +13/-10

Record schema versioning as implemented

• Describes parse-time version rejection and pre-merge compatibility checks. Distinguishes these from the still-planned field-type linting.

docs/architecture.md

harness-fields.mdDefine the active schema version contract +15/-12

Define the active schema version contract

• Documents the top-level field, version-1 default, load failures, and equal-version base composition. Removes the field's planned status.

docs/contributing/harness-fields.md

harness-reference.mdAdd schema_version to the harness reference +29/-0

Add schema_version to the harness reference

• Adds the field to the example and documents accepted values, error categories, top-level scope, and base inheritance.

docs/reference/harness-reference.md

@qodo-code-review

qodo-code-review Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Users miss harness version guidance ✗ Dismissed
Description
The new schema_version configuration field is documented only in the harness reference, with no
matching entry in docs/cli/ or docs/guides/. When users look there for configuration behavior,
they cannot find the field's default, validation failures, or composition restrictions.


Informational

2. Planned checks lack a clear callout ✓ Resolved

Resolving commit: 45f8cbb

Resolution reason
N/A
Description
The architecture overview describes type-flagging as planned in ordinary paragraph text rather than
using the required > **Planned:** callout. Readers of the updated architecture documentation may
mistake the not-yet-implemented checks for current functionality, even though the issue link is
present.

Grey Divider

Context sources
✅ Compliance rules (platform): 95 rules
✅ Skills: 5 invoked
  writing-user-docs
  writing-adrs
  check-patch-coverage
  cutting-releases
  adr-corner
✅ Cross-repo context — repo relationships
  Explored: repo: fullsend-ai/agents (sha: 9f4c0eb3) — View relationship
  Explored: repo: fullsend-ai/mlflow-assessments (sha: 2fdb0120) — View relationship
Review mode: Auto: 🧠 Deep: Cross-cutting parsing, composition, discovery, and contract logic create multiple independent defect opportunities.

Grey Divider

Tip of the day
💡 Did you know, you can turn these tips off under Display > Comment parts

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread internal/harness/harness.go Resolved
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:35 PM UTC · Completed 9:50 PM UTC

Commit: 85a6f84 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.03

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://f3471104-site.fullsend-ai.workers.dev

Commit: 45f8cbb74a13f0f236927a9e8065dc93234e8dd7

@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/harness/compose.go 20.00% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 27, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped schema field change with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness without feature-flag rollback.

Previous run

Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped schema field change with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness without feature-flag rollback.

Previous run (2)

Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped schema field change with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness without feature-flag rollback.

Previous run (3)

Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness with no feature flag for rollback.

Previous run (4)

Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (5)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (6)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (7)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (8)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (9)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (10)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (11)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (12)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (13)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (14)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (15)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (16)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (17)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (18)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness.

Previous run (19)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk (score 2) is preserved from prior assessment for this well-scoped, backward-compatible schema field change with high test coverage (0.54) and zero protected path modifications, balancing active churn and multi-author history in internal/harness.

Previous run (20)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk (score 2) is preserved from prior assessment for this well-scoped, backward-compatible schema field change with high test coverage (0.54) and zero protected path modifications, balancing active churn and multi-author history in internal/harness.

Previous run (21)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness.

Previous run (22)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness.

Previous run (23)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk driven by active churn and change coupling in the harness module alongside a breaking validation change without feature-flag rollback, balanced by strong test coverage (>54% test ratio), zero protected or security-sensitive path changes, and direct alignment with issue #235.

Previous run (24)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk driven by active churn and change coupling in the harness module alongside a breaking validation change without feature-flag rollback, balanced by strong test coverage (>54% test ratio), zero protected or security-sensitive path changes, and direct alignment with issue #235.

Previous run (25)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness.

Previous run (26)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness.

Previous run (27)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness.

Previous run (28)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, preserved from prior assessment amid active churn and multi-author history in internal/harness.

Previous run (29)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

Previous run (30)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk: well-scoped backward-compatible schema field with high test coverage and zero protected path changes, balanced against active churn and multi-author history in internal/harness.

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Looks good to me

Previous run

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzE3NDlhZWExMzMzOWFhZDUiLCJsaW5lIjo4NCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jMzFhNjhiN2Y4YzI3YzViIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfYmU5MDkyM2Y0YTNlZGYwNCIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfODY2YzVkZjAwMzg2M2FlNSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzA0Yjc4NGZkYTJmMjk0YmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImFwaS1zaGFwZSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL2hhcm5lc3MuZ28iLCJpZCI6ImZfYzVmM2RjMzNmYjdmNDM4OCIsImxpbmUiOjM3NiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjJmZjU2MGIxMzU0NDlkMyIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl83OWNlMmYxM2ZjYjBiYjAyIiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzY4ODM5ZTU3NDA0ZWYyNmYiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3MvY29udHJpYnV0aW5nL2hhcm5lc3MtZmllbGRzLm1kIiwiaWQiOiJmXzliYmVkZDRlOTBlOTQyNmIiLCJsaW5lIjoxNTgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3MvcmVmZXJlbmNlL2hhcm5lc3MtcmVmZXJlbmNlLm1kIiwiaWQiOiJmX2M1ZTBkNDVkOWNlYmVjNGYiLCJsaW5lIjo1MzgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwYXR0ZXJuLWluY29uc2lzdGVuY3kiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2IxNDY3ZTc4Mjg0MTA1ODAiLCJsaW5lIjo4OSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2MzMWE2OGI3ZjhjMjdjNWIiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYmU5MDkyM2Y0YTNlZGYwNCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl82ODgzOWU1NzQwNGVmMjZmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl85YmJlZGQ0ZTkwZTk0MjZiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IxNDY3ZTc4Mjg0MTA1ODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Low

  • [breaking-schema] internal/harness/schemaversion.go:84 — schemaVersionsCompose requires baseVer == childVer, so mixed-version base composition is rejected. This cannot trigger today (MaxSupportedSchemaVersion is 1 and absent == 1), but whoever raises the maximum version must define and document the cross-version composition rule, since shared bases are referenced from other repos.
Previous run (2)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2MzMWE2OGI3ZjhjMjdjNWIiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9iZTkwOTIzZjRhM2VkZjA0IiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl84NjZjNWRmMDAzODYzYWU1IiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl82MmZmNTYwYjEzNTQ0OWQzIiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzc5Y2UyZjEzZmNiMGJiMDIiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjg4MzllNTc0MDRlZjI2ZiIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvaGFybmVzcy1maWVsZHMubWQiLCJpZCI6ImZfOWJiZWRkNGU5MGU5NDI2YiIsImxpbmUiOjE1OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9yZWZlcmVuY2UvaGFybmVzcy1yZWZlcmVuY2UubWQiLCJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsImxpbmUiOjUzOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfYjE0NjdlNzgyODQxMDU4MCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYzMxYTY4YjdmOGMyN2M1YiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9iZTkwOTIzZjRhM2VkZjA0Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfODY2YzVkZjAwMzg2M2FlNSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8wNGI3ODRmZGEyZjI5NGJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNjJmZjU2MGIxMzU0NDlkMyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl83OWNlMmYxM2ZjYjBiYjAyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzY4ODM5ZTU3NDA0ZWYyNmYiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzliYmVkZDRlOTBlOTQyNmIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9jNWUwZDQ1ZDljZWJlYzRmIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYjE0NjdlNzgyODQxMDU4MCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Low

  • [breaking-schema] internal/harness/schemaversion.go:82 — The PR adds a top-level schema_version key. Zero, negative, non-integer, or greater-than-1 values now fail to load, where they were previously ignored as unknown keys, and a base: layer whose effective version differs from the child is rejected at composition. This is intended and matches the ! in the PR title; impact is small because the key was undefined before.
    Remediation: No code change required. Make sure the release notes call out the breaking change and the ADR 0127 migration guidance covers harnesses carrying a stray schema_version key.
Previous run (3)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2MzMWE2OGI3ZjhjMjdjNWIiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9iZTkwOTIzZjRhM2VkZjA0IiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl84NjZjNWRmMDAzODYzYWU1IiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl82MmZmNTYwYjEzNTQ0OWQzIiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzc5Y2UyZjEzZmNiMGJiMDIiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjg4MzllNTc0MDRlZjI2ZiIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvaGFybmVzcy1maWVsZHMubWQiLCJpZCI6ImZfOWJiZWRkNGU5MGU5NDI2YiIsImxpbmUiOjE1OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9yZWZlcmVuY2UvaGFybmVzcy1yZWZlcmVuY2UubWQiLCJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsImxpbmUiOjUzOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfYjE0NjdlNzgyODQxMDU4MCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYmU5MDkyM2Y0YTNlZGYwNCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl82ODgzOWU1NzQwNGVmMjZmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl85YmJlZGQ0ZTkwZTk0MjZiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IxNDY3ZTc4Mjg0MTA1ODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Low

  • [breaking-schema] internal/harness/schemaversion.go:82 — Harness YAML that was previously accepted now fails to load: a malformed, zero, negative or greater-than-1 schema_version used to be ignored. The PR is marked ! with a BREAKING CHANGE footer, so this is intentional and disclosed. The new exported Harness.SchemaVersion field has an unexported type (*schemaVersionValue), so external Go consumers can read the version only through EffectiveSchemaVersion().
    Remediation: No change required. Optionally export the type or add a setter if external callers need to set the version; keep the release note explicit that previously ignored values are now rejected.
Previous run (4)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2JlOTA5MjNmNGEzZWRmMDQiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfZTJkYzkxYTE5YTFiMWMyYSIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8wNGI3ODRmZGEyZjI5NGJhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl82ODgzOWU1NzQwNGVmMjZmIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb3JyZWN0LWRvYyIsImZpbGUiOiJkb2NzL2NvbnRyaWJ1dGluZy9oYXJuZXNzLWZpZWxkcy5tZCIsImlkIjoiZl85YmJlZGQ0ZTkwZTk0MjZiIiwibGluZSI6MTU4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb3JyZWN0LWRvYyIsImZpbGUiOiJkb2NzL3JlZmVyZW5jZS9oYXJuZXNzLXJlZmVyZW5jZS5tZCIsImlkIjoiZl9jNWUwZDQ1ZDljZWJlYzRmIiwibGluZSI6NTM4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoicGF0dGVybi1pbmNvbnNpc3RlbmN5IiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9iMTQ2N2U3ODI4NDEwNTgwIiwibGluZSI6ODksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl85YmJlZGQ0ZTkwZTk0MjZiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IxNDY3ZTc4Mjg0MTA1ODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl82ODgzOWU1NzQwNGVmMjZmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifV19 -->

Review

Findings

Low

  • [breaking-schema] internal/harness/schemaversion.go:83 — Harness YAML that declares a zero, negative, non-integer, or above-maximum schema_version now fails to load, where the key was previously ignored. schemaVersionsCompose also requires equal base and child versions, so once a version 2 exists, a v2 child cannot extend a v1 base until a cross-version rule is added. The ! in the PR title flags both behaviours, and they are intentional under ADR 0127 and fail closed. Advisory only.
    Remediation: Mention the new rejections and the strict-equality composition rule in the release notes. Define the cross-version composition rule before version 2 ships.

Earlier findings

  • docs/contributing/harness-fields.md:158, incorrect-doc — resolved. The new schema_version row in the merge-rule table now states that the field is not inherited and keeps the child declaration.
  • docs/reference/harness-reference.md:538, incorrect-doc — resolved. The reference merge-rule table has a matching schema_version row.
  • internal/harness/schemaversion.go:89, pattern-inconsistency — resolved. checkSchemaVersionsCompose and schemaVersionsCompose now take (base, child), and the call sites and tests were updated to match.
Previous run (5)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvaGFybmVzcy1maWVsZHMubWQiLCJpZCI6ImZfOWJiZWRkNGU5MGU5NDI2YiIsImxpbmUiOjE1OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9yZWZlcmVuY2UvaGFybmVzcy1yZWZlcmVuY2UubWQiLCJpZCI6ImZfYzVlMGQ0NWQ5Y2ViZWM0ZiIsImxpbmUiOjUzOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfYjE0NjdlNzgyODQxMDU4MCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl84NjZjNWRmMDAzODYzYWU1IiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMDRiNzg0ZmRhMmYyOTRiYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl82MmZmNTYwYjEzNTQ0OWQzIiwibGluZSI6ODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzc5Y2UyZjEzZmNiMGJiMDIiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjg4MzllNTc0MDRlZjI2ZiIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfODY2YzVkZjAwMzg2M2FlNSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8wNGI3ODRmZGEyZjI5NGJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNjJmZjU2MGIxMzU0NDlkMyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl83OWNlMmYxM2ZjYjBiYjAyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNjg4MzllNTc0MDRlZjI2ZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJzdGF0dXMiOiJvcGVuIn1dfQ== -->

Review

Findings

Medium

  • [incorrect-doc] docs/contributing/harness-fields.md:158 — The "Merge and inheritance rules" table's generic "Scalar fields" row says an absent value is inherited from the top level or base. schema_version is classified as a scalar (line 98), but mergeBaseIntoChild deliberately does not inherit it, and it is not a ForgeConfig field.
    Remediation: Add a schema_version row, or a note that the generic Scalar row does not apply to it. The row should say it is top-level only, not inherited from base:, and that all composed layers must share one effective version.
  • [incorrect-doc] docs/reference/harness-reference.md:538 — The "Field merge rules (for base and overlays)" table lists only "Scalars ... child wins if non-empty". Other top-level-only, non-inherited fields have explicit rows there, but schema_version does not. The field's own section (around line 187) documents the real behavior.
    Remediation: Add a schema_version row to this table with the same semantics as above.

Low

  • [pattern-inconsistency] internal/harness/schemaversion.go:89 — checkSchemaVersionsCompose(child, base, ...) and schemaVersionsCompose(childVer, baseVer) take (child, base). The existing merge helpers in internal/harness (mergeBaseIntoChild and others) take (base, child), so the call sites in compose.go (lines 326/331 and 615/622) flip argument order on consecutive lines.
    Remediation: Reorder the parameters to (base, child).
  • [breaking-schema] internal/harness/schemaversion.go:82 — schema_version is a new top-level harness field, and newer builds reject values above 1 and mixed-version base composition. The ! marker is already on the title and commit. No code change is needed; release notes should say that harnesses declaring schema_version need a build containing this change.
  • [sub-agent-failure] N/A — The challenger sub-agent did not return findings: its adjudication was invalid because a merged finding was emitted at a severity (low) below its highest-severity input (medium). Using the pre-challenger finding set.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (6)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8wNGI3ODRmZGEyZjI5NGJhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzYyZmY1NjBiMTM1NDQ5ZDMiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzY4ODM5ZTU3NDA0ZWYyNmYiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl82MmZmNTYwYjEzNTQ0OWQzIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfNzljZTJmMTNmY2IwYmIwMiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmX2UyZGM5MWExOWExYjFjMmEiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl84NjZjNWRmMDAzODYzYWU1Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifV19 -->

Looks good to me

Earlier findings

  • internal/harness/harness.go:376, api-shape, reclassified to info — field type is package-internal and reads use EffectiveSchemaVersion().
  • internal/harness/schemaversion.go:82-83, breaking-schema, reclassified to info — declared breaking change; strict-equality composition is intentional with only version 1 supported.

No findings at or above low severity; 7 lower-severity finding(s) were not posted.

Previous run (7)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfNjJmZjU2MGIxMzU0NDlkMyIsImxpbmUiOjgzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzc5Y2UyZjEzZmNiMGJiMDIiLCJsaW5lIjo4MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfODY2YzVkZjAwMzg2M2FlNSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImluamVjdGlvbi12dWxuIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwibGluZSI6MzgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYzVmM2RjMzNmYjdmNDM4OCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9lMmRjOTFhMTlhMWIxYzJhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoib3BlbiJ9XX0= -->

Review

Findings

Low

  • [api-shape] internal/harness/harness.go:376 — The exported field Harness.SchemaVersion has the unexported type *schemaVersionValue. Packages outside internal/harness cannot name the type or set the field in a Harness literal. They can only read it through EffectiveSchemaVersion(). The design is documented in the code and no current caller is affected, so this is advisory.
    Remediation: Optionally export the type (for example type SchemaVersion int) if other packages need to build Harness values with an explicit version.
  • [breaking-schema] internal/harness/schemaversion.go:83 — schemaVersionsCompose requires equal effective versions, so layers with different schema_version values are rejected. MaxSupportedSchemaVersion is 1, so no mixed-version case can occur today. The rule becomes a compatibility constraint once version 2 exists.
    Remediation: No change is needed in this PR. Define the cross-version composition rule in the ADR before adding schema version 2.
  • [breaking-schema] internal/harness/schemaversion.go:83 — Duplicate of the finding above, kept so the earlier ledger entry stays tracked.
Previous run (8)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfZTJkYzkxYTE5YTFiMWMyYSIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfZTJkYzkxYTE5YTFiMWMyYSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl84NjZjNWRmMDAzODYzYWU1Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsInN0YXR1cyI6Im9wZW4ifV19 -->

Review

Findings

Low

  • [api-shape] internal/harness/harness.go:376 — SchemaVersion is an exported field on the exported Harness struct, but its type *schemaVersionValue is unexported, so callers outside package harness cannot name the type or build values directly (reads go through EffectiveSchemaVersion()). Nothing outside the package uses the field today.
    Remediation: Export the underlying type (e.g. SchemaVersionValue), or keep *int and validate float truncation in parseRaw.
  • [breaking-schema] internal/harness/schemaversion.go:82 — schemaVersionsCompose only accepts equal versions. Once version 2 ships, a base layer that omits the field (version 1) will fail to compose with a version-2 child. The PR documents this as deliberate, so it is a forward-compatibility note rather than a current defect.
    Remediation: Before introducing version 2, define an explicit cross-version composition rule or document the lockstep requirement.
Previous run (9)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfZTJkYzkxYTE5YTFiMWMyYSIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzg2NmM1ZGYwMDM4NjNhZTUiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoib3BlbiJ9XX0= -->

Review

Findings

Low

  • [api-shape] internal/harness/harness.go:376 — The exported field Harness.SchemaVersion has the unexported type *schemaVersionValue. Code outside package harness cannot name the type, so it cannot set the field in a struct literal and can only read the value through EffectiveSchemaVersion(). The package lives under internal/, so other modules cannot import it, and no other package in this module uses the field, so this is a style point rather than an API break.
    Remediation: Export the type (for example SchemaVersionValue), or keep it unexported and note in the field comment that it is read-only outside the package.
  • [breaking-schema] internal/harness/schemaversion.go:82 — schemaVersionsCompose requires equal versions, so a base layer with a different schema_version is rejected. Only version 1 exists today, so nothing breaks now. When version 2 ships, a v2 child cannot extend an unversioned (v1) base until a cross-version rule is added. The behavior is intentional and documented, and the PR is already marked breaking.
    Remediation: Relax schemaVersionsCompose when v2 is introduced.

1 finding(s) below the low severity threshold were not posted.

Previous run (10)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsImxpbmUiOjgyLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfYzVmM2RjMzNmYjdmNDM4OCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwic3RhdHVzIjoib3BlbiJ9XX0= -->

Review

Findings

Low

  • [api-shape] internal/harness/harness.go:376 — The exported field Harness.SchemaVersion has the unexported type *schemaVersionValue. Code outside the package can read and dereference it but cannot name the type to build values. The package is under internal/, so no current caller is affected, and EffectiveSchemaVersion() is the intended accessor. Advisory only.
    Remediation: Optional: export the type or add a constructor if code outside the package ever needs to set the field.
  • [breaking-schema] internal/harness/schemaversion.go:82 — Harnesses that declare schema_version 0, a negative value, a non-integer, or a value above 1 are now rejected at load time. schemaVersionsCompose also requires equal child and base versions, so once version 2 exists a v2 child cannot extend a v1 base until a cross-version rule is added. Both behaviours are intentional under ADR 0127 and flagged by the ! in the PR title. Advisory only.
    Remediation: Mention the new rejections and the strict-equality composition rule in the release notes.

Earlier findings

  • internal/harness/schemaversion.go:38, injection-vuln — reclassified to info: the !!float error text mirrors yaml.v3's own raw-value type error, so this PR adds no new injection path.

1 finding(s) below the low severity threshold were not posted.

Previous run (11)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo4MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9XX0= -->

Review

Findings

Low

  • [api-shape] internal/harness/harness.go:376 — The exported field Harness.SchemaVersion has the unexported type *schemaVersionValue. Code outside internal/harness cannot name the type or set the field in a struct literal. The impact is limited: the package is under internal/, the field's doc comment sends readers to EffectiveSchemaVersion(), and no caller outside the package needs to set it.
    Remediation: Optional. Export the type as SchemaVersionValue if outside callers ever need to build a versioned Harness. Otherwise state in the doc comment that the field is read-only by design.
  • [breaking-schema] internal/harness/schemaversion.go:82 — schemaVersionsCompose requires equal effective versions, so base-layer composition fails whenever child and base differ. This has no effect while only version 1 is supported. After a version 2 exists, a v2 consumer harness cannot compose a v1 base from agents. The comment and the error message already describe this as deliberate fail-closed behaviour.
    Remediation: Optional. Document the migration path (upgrade base and child together). Add an explicit cross-version rule when version 2 is introduced.

Earlier findings

  • internal/harness/schemaversion.go:38, injection-vuln — still present at info severity, below the posting threshold. The float diagnostic interpolates the raw scalar, as yaml.v3's own type errors do. The unescaped workflow-annotation sink is in internal/harnessdispatch/enumerate.go, outside this diff.

1 finding(s) below the low severity threshold were not posted.

Previous run (12)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6ODIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1zaGFwZSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL2hhcm5lc3MuZ28iLCJpZCI6ImZfYzVmM2RjMzNmYjdmNDM4OCIsImxpbmUiOjM3NiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9XX0= -->

Review

Findings

Low

  • [breaking-schema] internal/harness/schemaversion.go:82 — The new top-level schema_version key is a breaking schema change (title carries !). Harness content declaring it and used as a remote or base layer is rejected by older fullsend binaries. schemaVersionsCompose requires equal versions, so once a v2 exists any v1/v2 base composition fails, and the contract for version bumps is not yet defined. This is intentional and documented, and the check fails closed.
  • [api-shape] internal/harness/harness.go:376 — The exported field Harness.SchemaVersion uses the unexported type *schemaVersionValue. Other packages cannot name the type or set the field in Harness literals. They can still read the version through EffectiveSchemaVersion(). Consider exporting the type, or using *int with unmarshaling through an intermediate type.

1 finding(s) below the low severity threshold were not posted.

Previous run (13)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiaW5qZWN0aW9uLXZ1bG4iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJsaW5lIjozOCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJyZWFraW5nLXNjaGVtYSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsImxpbmUiOjc3LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4IiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zOGRlZTI3YjIxMjk4ZmZhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jNWYzZGMzM2ZiN2Y0Mzg4Iiwic3RhdHVzIjoib3BlbiJ9XX0= -->

Review

Findings

Low

  • [api-shape] internal/harness/harness.go:376 — Exported field Harness.SchemaVersion uses the unexported type *schemaVersionValue, so code outside package harness cannot name the type or set the field in a Harness literal. Impact is limited to in-module callers (the package is under internal/), none of which use the field today, and the choice is documented at harness.go:370-375. Reads can go through EffectiveSchemaVersion().
    Remediation: Optionally export the type as SchemaVersionValue before any in-module caller needs to construct the field.
  • [breaking-schema] internal/harness/schemaversion.go:77 — The harness YAML schema is now stricter: an explicit schema_version that is zero, negative, a float, or above MaxSupportedSchemaVersion (1) fails to load. The decoder does not enable strict field checking, so a custom harness that already used a schema_version key for its own purposes could now break. The PR marks this as breaking with !. Mixed-version base composition is rejected (schemaVersionsCompose requires equal versions); harmless while only version 1 exists, but a compatibility trap once version 2 ships.
    Remediation: Keep the breaking-change note in the release notes, and define the cross-version composition rule before introducing version 2.

Earlier findings

  • internal/harness/schemaversion.go:38, injection-vuln, reclassified to info — the float-scalar error copies yaml.v3's own type-error format (same unescaped value, same truncation), so it adds no exposure beyond what yaml.v3 already lets through; the ::error:: annotation sink in internal/harnessdispatch/enumerate.go is unchanged by this PR.

1 finding(s) below the low severity threshold were not posted.

Previous run (14)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM4LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6NzcsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmX2M1ZjNkYzMzZmI3ZjQzODgiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzM4ZGVlMjdiMjEyOThmZmEiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfY2ViODI2OTAwYzgzYzI4MCIsInN0YXR1cyI6Im9wZW4ifV19 -->

Review

Findings

Low

  • [injection-vuln] internal/harness/schemaversion.go:38 — The float-type diagnostic interpolates node.Value into the error text without escaping; a short explicitly !!float-tagged scalar containing a newline and ::error:: survives the 10-byte truncation. ListTriggeredHarnesses writes LoadWithBase errors into a ::error:: annotation unsanitized, so a forged annotation line is possible. The sink predates this PR, yaml.v3's native type errors echo scalar values the same way, and exploitation needs write access to harness content, so impact is limited to annotation spoofing.
    Remediation: Optional hardening — sanitize control characters centrally at the annotation sink and/or quote node.Value with %q.
  • [breaking-schema] internal/harness/schemaversion.go:77 — Loading now fails for harness content declaring schema_version with zero, negative or unsupported values, and for base compositions whose versions differ; previously the key was ignored. Intended and flagged by the ! marker in the PR title; a future version bump will need an explicit cross-version rule.
  • [api-shape] internal/harness/harness.go:376 — Exported field Harness.SchemaVersion has the unexported type *schemaVersionValue, so code outside the package can read it and call EffectiveSchemaVersion() but cannot name the type or build a value in a struct literal. The package is under internal/ and no other package constructs the field today, so impact is limited.
    Remediation: Optionally export the named type, or document the field as read-only via EffectiveSchemaVersion().
Previous run (15)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3NjaGVtYXZlcnNpb24uZ28iLCJpZCI6ImZfMzhkZWUyN2IyMTI5OGZmYSIsImxpbmUiOjM3LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9jZWI4MjY5MDBjODNjMjgwIiwibGluZSI6NzcsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJzdGF0dXMiOiJvcGVuIn1dfQ== -->

Review

Findings

Low

  • [injection-vuln] internal/harness/schemaversion.go:37 — The new !!float branch in schemaVersionValue.UnmarshalYAML interpolates node.Value into the error with %s, unescaped. A short tagged scalar (for example !!float "\n::error::") survives the 10-byte truncation with its newline intact. The error then reaches the unescaped ::error::harness dispatch: skipping agent %s: load failed: %v annotation in internal/harnessdispatch/enumerate.go. This is not new exposure: yaml.v3 type errors already embed raw scalars the same way, and the root cause is the existing unescaped annotation printf, which this PR does not touch. Optionally quote the value with %q here, and escape %, \r and \n at the annotation boundary in a follow-up.
    Remediation: Quote node.Value with %q in the new diagnostic; escape workflow-command metacharacters at the annotation boundary in enumerate.go.
  • [breaking-schema] internal/harness/schemaversion.go:77 — Still open. The PR deliberately makes harness YAML that declares schema_version fail to load when the value is below 1, above the maximum supported (1), or non-integer. It also rejects composing base: layers with different effective versions. The ! in the title acknowledges the break. Harnesses without the field are unaffected. Harness.SchemaVersion is exported but its type *schemaVersionValue is unexported, so external Go callers can read it but not construct one.
    Remediation: Call out the breaking behavior in the release notes; consider exporting the type or a constructor if external callers need to set a version.
Previous run (16)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJicmVha2luZy1zY2hlbWEiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmX2NlYjgyNjkwMGM4M2MyODAiLCJsaW5lIjo3NywiYWN0aW9uYWJsZSI6ZmFsc2V9XX0= -->

Review

Findings

Low

  • [breaking-schema] internal/harness/schemaversion.go:77 — A top-level schema_version key used to be silently ignored; now any value other than 1 (0, negative, 2+, float) fails the load, and mixed-version base composition is rejected. The PR title carries the ! marker, so the break is flagged.
    Remediation: Ensure release notes/migration docs state that schema_version values other than 1 are rejected at load time so downstream harness repos can audit their YAML.
Previous run (17)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOltdfQ== -->

Looks good to me

Previous run (18)

Review

Findings

Low

  • [logic-error] internal/harness/harness.go:488 — parseRaw decodes the whole document into the current Harness schema before validateSchemaVersion runs. An unsupported schema_version combined with a field representation the current schema cannot decode fails with the version-1 type error rather than the unsupported-version message and upgrade remedy. No effect today (only version 1 exists); matters at the first schema bump.
    Remediation: Decode a version-only envelope (or yaml.Node) and validate schema_version first, then decode the rest into Harness; add a regression test for the combination.

Info

  • [api-shape] internal/harness/harness.go:376 — Exported field Harness.SchemaVersion has the unexported type *schemaVersionValue; external packages cannot name the type or construct the field. Reads go through EffectiveSchemaVersion.
  • [breaking-config] internal/harness/schemaversion.go:90 — New schema_version key plus load-time rejection of non-integer, zero, negative, and unsupported values and of mixed-version base composition. Harnesses without the field are unaffected; the ! marker covers the change.
  • [sub-agent-failure] N/A — The docs-currency sub-agent timed out after 900s, so documentation outside the three docs files this PR updates was not checked.

3 finding(s) below the low severity threshold were not posted.

Previous run (19)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL2hhcm5lc3MuZ28iLCJpZCI6ImZfZDU1MTcwZTZlNjgyMDZlZiIsImxpbmUiOjQ4OCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9oYXJuZXNzLmdvIiwiaWQiOiJmXzA0ZGUzNTYyYTVmNDRkY2IiLCJsaW5lIjozNzYsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctY29uZmlnIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3Mvc2NoZW1hdmVyc2lvbi5nbyIsImlkIjoiZl9hMGNlYzUyMDQ1YTBiM2Y5IiwibGluZSI6OTAsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYnJlYWtpbmctc2NoZW1hIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvaGFybmVzcy5nbyIsImlkIjoiZl9lYzliNTM1Nzk4MGQxYTRjIiwibGluZSI6Mzc2LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9zY2hlbWF2ZXJzaW9uLmdvIiwiaWQiOiJmXzdhMjY2NjU2NmFiMTkwZDQiLCJsaW5lIjo5OCwiYWN0aW9uYWJsZSI6dHJ1ZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl9kNTUxNzBlNmU2ODIwNmVmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzA0ZGUzNTYyYTVmNDRkY2IiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYTBjZWM1MjA0NWEwYjNmOSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9lYzliNTM1Nzk4MGQxYTRjIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfN2EyNjY2NTY2YWIxOTBkNCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Low

  • [logic-error] internal/harness/harness.go:488 — parseRaw decodes the whole document into the current Harness struct before calling validateSchemaVersion. A document with schema_version: 2 whose other fields change shape fails inside yaml.Unmarshal first, so the user gets a field-type error instead of the unsupported-version diagnostic. The load still fails closed. What is lost is the actionable upgrade/pin guidance and the strict check-before-interpret ordering in ADR 0127.
    Remediation: Decode a minimal schema_version envelope or YAML node and validate it before decoding the full Harness. Add a regression test that combines an unsupported version with a field shape incompatible with version 1.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:34 PM UTC · Completed 10:43 PM UTC

Commit: ead4c5e · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.32

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the component/harness Agent harness, config, and skills loading label Oct 27, 2026
@jflowers
jflowers force-pushed the opsx/harness-schema-versioning branch from ead4c5e to 5ab8af8 Compare October 28, 2026 08:09
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:11 AM UTC · Completed 8:26 AM UTC

Commit: 5ab8af8 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.34

Comment thread docs/reference/harness-reference.md Resolved
Comment thread docs/reference/harness-reference.md Resolved
fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:57 AM UTC · Completed 10:19 AM UTC

Commit: 6738a29 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.31

fullsend-ai-review[bot]

This comment was marked as outdated.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:36 PM UTC · Completed 2:45 PM UTC

Commit: c1a6aa3 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.47

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:56 PM UTC · Completed 6:07 PM UTC

Commit: 8acb3a5 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.23

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure (validation failed after 1 iteration(s)) · Started 11:30 PM UTC · Completed 11:53 PM UTC

Commit: bcdcd14 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.50

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:43 AM UTC · Completed 3:57 AM UTC

Commit: 0b3f384 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.39

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:39 AM UTC · Completed 11:48 AM UTC

Commit: 57c169d · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.71

fullsend-ai-review[bot]

This comment was marked as outdated.

jflowers and others added 12 commits November 5, 2026 14:02
…cision 1)

The harness YAML is fullsend's most-edited cross-repository contract but
carried no version: when a field's semantics change, harnesses in consumer
repositories break silently or with unactionable errors, and migration
tooling has no handle for knowing which schema a file was written against.

- Add a top-level schema_version field on harness YAML; absent means
  version 1, so every existing harness remains valid unchanged.
- Enforce version-aware loading: every parse entry point (Load, LoadRaw,
  LoadWithOpts, LoadWithBase, URL-fetched base content, local and remote
  discovery) rejects malformed, zero, negative, and unsupported versions
  at parse time, before fields are interpreted under version-1 semantics.
- Guard base-layer composition: each raw base: layer's effective version
  is validated before merging, and mixed-version layers are rejected
  (only equal effective versions compose).
- Reject with actionable errors naming schema_version, the offending
  value, the supported range, and the upgrade remedy.
- Move schema_version from "Planned, not yet implemented" to the
  implemented contract in docs/contributing/harness-fields.md,
  docs/architecture.md, and docs/reference/harness-reference.md.

BREAKING CHANGE: harness YAML declaring a malformed, zero, negative, or
unsupported schema_version now fails to load at parse time; previously
the field was ignored (absent semantics) and the harness loaded.

Assisted-by: glm-5
Generated with AI assistance (glm-5)
AI-Assisted: true

Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…reference

Reword the example comment to say the field "defaults to `1`" instead of
"absent = 1", and state in the Malformed error-shape bullet that every
float is rejected — including integral spellings such as `1.0`, not only
fractional ones such as `1.5` — matching what UnmarshalYAML enforces.

Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin and
@fullsend-ai-review[bot].

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Keep the ADR citation on the two property-definition declarations
(MaxSupportedSchemaVersion, schemaVersionValue) where the contract is
defined, and drop it from the helper comments below. Repeated ADR
references on every schema_version-adjacent function train contributors
to sprinkle the citation everywhere it is not needed.

Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin.

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Rename schemaVersionsCompatible to schemaVersionsCompose and
checkSchemaVersionCompatibility to checkSchemaVersionsCompose. The old
names read as checks against the build's maximum supported version; the
functions actually decide whether a base layer's effective schema
version composes into the harness inheriting it. The predicate stays a
separate function: it is the single extension point where a future
cross-version composition rule will live (design D3), kept out of the
pure merge so it can be tested directly.

All references are unexported and contained to internal/harness: the
two definitions, two call sites in compose.go (LoadWithBase,
loadBaseChain), one merge-table comment, and the tracking tests.

Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin.

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Format layerLabel with %q in the checkSchemaVersionsCompose error. The
label is the harness author's base: reference (a path or URL), and
docs/contributing/go-code.md requires %q for user-provided values in
error messages; compose.go already quotes base references this way in
its own errors. Update the two ErrorContains assertions that pinned the
unquoted form.

Addresses PR fullsend-ai#8877 review feedback from @fullsend-ai-review[bot].

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Commit 8037305 renamed checkSchemaVersionCompatibility to
checkSchemaVersionsCompose and renamed its direct-coverage test, but two
doc comments in compose_test.go still referenced the pre-rename test
name. Update both to TestCheckSchemaVersionsCompose_ConstructedMixedVersions.

Found by the review-council advisory (divisor-testing).

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The merge previously copied the base's explicit schema_version onto an
absent child. That inheritance went beyond ADR 0127 Decision 1, which
spells an absent schema_version as version 1 and defers all cross-version
behavior to an explicit compatibility rule; inheriting would relabel a
v1-by-absence child as the base's version the moment such a rule exists.

Equal effective versions still compose — that guard is unchanged — but
the merged harness now keeps the child's own declaration: an absent child
stays absent (version 1), and the reference doc no longer promises
inheritance.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
…ble style

The row still carried the forge-rationale phrasing ("forge-agnostic",
"Top level only — not a ForgeConfig field ...") that fullsend-ai#8867 removed from
every other row of this table, and the conflict with main sits exactly
here. Shorten it to match the table's current style; the table heading
already notes that keys under forge:/overlays: are ignored.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The remedy clause restated the declared version the opening clause had
already named ("upgrade fullsend to a release that supports
schema_version N" for a message that opens "schema_version N is not
supported"). Drop the repetition in favor of "supports it", matching the
reference prose, which already phrases the remedy that way. The message
still names every element the spec requires: field, declared value,
maximum, and remedy.

Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
The schema_version section documented only the forward direction of the
compatibility contract: an older binary meeting a newer file fails with
an upgrade remedy. State the backward direction too: a build loads any
declared version from 1 through its maximum supported version, and the
maximum only grows across releases, so newer binaries read older files.
Note that whether a future version may stop interpreting older-version
field semantics is left to the cross-version policy ADR 0127 does not
set.

Addresses PR fullsend-ai#8877 review feedback from @rh-hemartin.

Review: fullsend-ai#8877

AI-Assisted: true
Assisted-by: glm-5
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
checkSchemaVersionsCompose and schemaVersionsCompose took (child, base)
while mergeBaseIntoChild and the other merge helpers take (base, child),
so the compose.go call sites flipped argument order on consecutive
lines. Reorder both helpers and update the call sites and tests; no
behavior change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
Both merge-rule tables classed schema_version under the generic scalar
row, which says an absent value inherits from base. mergeBaseIntoChild
deliberately does not inherit it: the merged harness keeps the child's
own declaration, and composed layers must share one effective version.
Add an explicit row to each table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:04 PM UTC · Completed 7:20 PM UTC

Commit: 45f8cbb · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.52

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — 45f8cbb7 Deployed Nov 5, 2026 by github-actions[bot]
dev — 45f8cbb7 Deployed Nov 5, 2026 by jflowers via behaviour #19005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/harness Agent harness, config, and skills loading ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema versioning for harness definition files

4 participants