Skip to content

feat(rulesets): require review on experiments main - #33

Merged
rh-hemartin merged 1 commit into
mainfrom
experiments-main-review
Oct 30, 2026
Merged

rh-hemartin merged 1 commit into
mainfrom
experiments-main-review

Conversation

@waynesun09

Copy link
Copy Markdown
Member

Summary

experiments main required 0 approvals and no code-owner review; fullsend and agents require 1 approval plus code-owner review. With #30, fullsend-writers gets write on experiments, so any writer could merge to main without review, workflow files included.

This aligns the experiments pull_request rule with the other two repos in the fullsend group:

  • required_approving_review_count: 0 → 1
  • require_code_owner_review: false → true (CODEOWNERS is * @fullsend-ai/core)
  • required_review_thread_resolution: false → true

Required status checks are left as is; they differ per repo.

Testing

  • python3 scripts/lint.py: passes.
  • safe-settings dry run on this PR should show only these three fields changing on the experiments main ruleset.

🤖 Generated with Claude Code

@waynesun09
waynesun09 requested a review from a team October 30, 2026 13:08
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Require reviews before merging to experiments main

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Require one approval, code-owner review, and resolved review threads for experiments main.
• Align its review requirements with fullsend and agents without changing repository-specific
 checks.
Diagram

graph TD
  A["Experiments config"] --> B["Safe-settings"] --> C{"Review requirements"} --> D["Main merges"]
Loading
High-Level Assessment

Changing the existing repository ruleset is the narrowest approach. An organization-wide rule would affect other repositories unnecessarily, while checks alone would not require human review.

Files changed (1) +3 / -3

Other (1) +3 / -3
experiments.ymlRequire reviewed pull requests for experiments main +3/-3

Require reviewed pull requests for experiments main

• Raises the approval requirement from zero to one and requires code-owner review and resolution of review threads. Other ruleset settings remain unchanged.

repos/experiments.yml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:10 PM UTC · Completed 1:14 PM UTC

Commit: 63a1e4e · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.54

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Oct 30, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Single-file configuration update touching 6 lines with zero protected paths, no CI or dependency changes, and low churn in git history.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 30, 2026
experiments required 0 approvals and no code-owner review, unlike
fullsend and agents. Once the fullsend repo-group teams (#30) grant
write on experiments, any writer could merge to main unreviewed,
workflow files included. Match the review rules of the other two repos
in the group: 1 approval, code-owner review, resolved threads.

Assisted-By: Claude Opus 5.5 (Claude Code)
Signed-off-by: Wayne Sun <gsun@redhat.com>
@rh-hemartin
rh-hemartin force-pushed the experiments-main-review branch from 63a1e4e to 4653625 Compare October 30, 2026 14:53
@fullsend-ai-review

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Ended 2:55 PM UTC

Commit: 4653625 · View workflow run →

Automated review did not complete for this commit. Check the latest review status before merging. If no review is queued or running, comment /fs-review to retry.

@rh-hemartin
rh-hemartin merged commit 6150d28 into main Oct 30, 2026
30 of 31 checks passed
@rh-hemartin
rh-hemartin deleted the experiments-main-review branch October 30, 2026 14:56
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ⏭️ Skipped (PR #33 is already merged) · Started 2:57 PM UTC · Completed 2:57 PM UTC

Commit: 4653625 · View workflow run →

Effort: high

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open PRs/MRs.

Posted by fullsend pre-review check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/low PR risk: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants