Repository navigation
feat(#1): add fullsend-triagers and fullsend-writers teams - #30
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Start segmenting triage/write access per repo group. Add fullsend-triagers (triage) and fullsend-writers (write) on fullsend, agents and experiments, seeded with the full current membership of triagers/writers so nobody's effective access changes on fullsend and agents. Drop the now-overlapping fullsend and agents grants from the old teams; they keep their remaining repos (and .fullsend for writers). experiments gains triage/write access for the group, as intended. Point the triage/write request issue templates (moved here from fullsend's discussion templates) at the new teams. Not changed: LADDER.md lives in fullsend-ai/fullsend, and notify-role-request-slack.yml still names triagers/writers (the agent cannot edit workflows). A maintainer must update both. scripts/lint.py passes. Peribolos dry run not run (needs a prow checkout and an org token); expected plan: two teams created with members and grants, four grant removals from triagers/writers. Closes #1 Assisted-By: Claude Opus 5.5(claude-code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 12:07 PM UTC · Completed 12:16 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.42 |
|
<!-- fullsend:risk-assessment --> DetailsSmall scoped change aligning with issue requirements, elevated to moderate risk due to touching protected paths and total-state peribolos.yaml which exhibits recent churn and regression history. |
ReviewFindingsMedium
|
waynesun09
left a comment
There was a problem hiding this comment.
Checked the member lists against main: fullsend-triagers and fullsend-writers copy triagers (18) and writers (9) exactly, ralphbean is the maintainer on both, and the old teams keep their remaining repos (.fullsend stays on writers). The diff matches #1.
Two things before merge:
1. The peribolos-dry-run failure comes from the new teams, not from a config error. In dry-run, CreateTeam does nothing, so the next call on fullsend-triagers returns 404 and the run stops (log). The plan it printed before that is right (2 creates, 4 RemoveTeamRepoBySlug), but fullsend-writers is never checked. The log also shows the old teams' grants are removed before the new teams get theirs. If the apply fails in between, current members lose fullsend/agents access until someone re-runs it. Suggest two PRs: this one adds the two teams only; a second removes the four old grants, and its dry run will pass and show exactly those removals.
2. Land the follow-ups in the same window. notify-role-request-slack.yml (needs a maintainer, the bot can't edit workflows) and LADDER.md in fullsend. LADDER says "the ladder is organization-wide" and points at triagers/writers; after this PR a role is per repo group, so the request templates probably need a repo-group choice too.
experiments required 0 approvals and no code-owner review, unlike fullsend and agents. Once the fullsend repo-group teams (#30) grant write on experiments, any writer could merge to main unreviewed, workflow files included. Match the review rules of the other two repos in the group: 1 approval, code-owner review, resolved threads. Assisted-By: Claude Opus 5.5 (Claude Code) Signed-off-by: Wayne Sun <gsun@redhat.com>
Summary
First step in splitting triage/write access by repo group, starting with the fullsend group (fullsend, agents, experiments).
peribolos.yamlfullsend-triagers(triage) andfullsend-writers(write) onfullsend,agentsandexperiments. Both areprivacy: closed, haveralphbeanas maintainer, and copy every current member oftriagers/writers.fullsendandagentsgrants fromtriagersandwriters. Both teams keep their other repos, andwriterskeeps.fullsend..github/ISSUE_TEMPLATE/triage-request.yml,write-request.yml: the maintainer approval steps now name the new teams. These templates were moved here from fullsend's discussion templates (fullsend-ai/fullsend@faefa73e), so this covers item 3 of the issue.Current members keep their access to
fullsendandagents.experimentsis newly open to the group, as the issue intends.Expected peribolos dry run
fullsend-triagersandfullsend-writers, with their members and their 3 repo grants each.fullsendandagentsfromtriagers, and the same two fromwriters.Testing
python3 scripts/lint.py: passes.Follow-ups (not in this PR)
LADDER.mdin fullsend-ai/fullsend: point the Triage and Write "How to check" sections at the new teams..github/workflows/notify-role-request-slack.ymlstill tells people to add requesters totriagers/writers. The agent cannot edit workflow files, so a maintainer needs to update it.🤖 Generated with Claude Code
Closes #1
Post-script verification
agent/1-fullsend-group-teams)71dbd7cd4210cd3ce1f99b58ff3a75850fd51e11..HEAD)