Repository navigation
Conversation
mjq
force-pushed
the
mjq/deprecated-attribute-accessor
branch
from
October 26, 2026 17:34
7a8f05b to
1ae03d8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve data transparency, we'd like to reduce the amount of attribute renaming we're doing in Relay.
The purpose of our attribute deprecation
BackfillandNormalizepolicies were for the benefit of data consumers: so that they could rely on data being present under the latest name in Sentry. The two main cases were:Case 2 has been covered for a long time by Snuba's automatic coalescing. There is no benefit to attribute backfilling or normalizing there.
Case 1 has been addressed in the Sentry frontend (getsentry/sentry#123321) and backend (getsentry/sentry#126640). The only place left is Relay itself.
To kick things off:
The idea is that all accesses by name would be replaced by these deprecation-aware accessors, at which point we could remove both
BackfillandNormalizehandling.(Note that
Transformwill continue to exist, as that can't be managed through simple coalescing. Nonetheless we'll be reducing the amount of data munging we do on users' data a lot.)See related Notion doc for some background. See EXP-1275.