Skip to content

fix(attributes): Use deprecation-aware getters in op/category inference - #6513

Draft
mjq wants to merge 1 commit into
masterfrom
mjq/deprecated-attribute-accessor
Draft

mjq wants to merge 1 commit into
masterfrom
mjq/deprecated-attribute-accessor

Conversation

@mjq

@mjq mjq commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

To improve data transparency, we'd like to reduce the amount of attribute renaming we're doing in Relay.

The purpose of our attribute deprecation Backfill and Normalize policies were for the benefit of data consumers: so that they could rely on data being present under the latest name in Sentry. The two main cases were:

  1. looking up a particular attribute by name inside the ingestion path or Sentry code
  2. when searching data in EAP

Case 2 has been covered for a long time by Snuba's automatic coalescing. There is no benefit to attribute backfilling or normalizing there.

Case 1 has been addressed in the Sentry frontend (getsentry/sentry#123321) and backend (getsentry/sentry#126640). The only place left is Relay itself.

To kick things off:

  • add a deprecation-aware attribute accessor. Given an attribute name, that attribute's entire deprecation chain is searched. Start at the current name, then by deprecation depth, then alphabetically at the same depth.
  • Use that accessor during op/category inference, just to help prove out the design.

The idea is that all accesses by name would be replaced by these deprecation-aware accessors, at which point we could remove both Backfill and Normalize handling.

(Note that Transform will continue to exist, as that can't be managed through simple coalescing. Nonetheless we'll be reducing the amount of data munging we do on users' data a lot.)

See related Notion doc for some background. See EXP-1275.

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

EXP-1275

@mjq
mjq force-pushed the mjq/deprecated-attribute-accessor branch from 7a8f05b to 1ae03d8 Compare October 26, 2026 17:34
@mjq
mjq added this pull request to stack #6561 October 26, 2026 17:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant