Skip to content

ref(performance): Replace legacy span attribute lookups - #123321

Merged
nsdeschenes merged 4 commits into
masterfrom
nd/chore-explore-replace-findspanattributevalue-uses
Sep 2, 2026
Merged

nsdeschenes merged 4 commits into
masterfrom
nd/chore-explore-replace-findspanattributevalue-uses

Conversation

@nsdeschenes

@nsdeschenes nsdeschenes commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • replace the remaining findSpanAttributeValue call sites with getAttributeValue
  • preserve runtime name/version family pairing while using deprecation-aware lookups
  • remove the unused findSpanAttributeValue helper and its supporting import

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 1, 2026
@nsdeschenes nsdeschenes changed the title ref(performance): replace legacy span attribute lookups ref(performance): Replace legacy span attribute lookups Sep 1, 2026
@nsdeschenes

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f1d44f2. Configure here.

@nsdeschenes
nsdeschenes marked this pull request as ready for review September 1, 2026 16:47
@nsdeschenes
nsdeschenes requested a review from a team as a code owner September 1, 2026 16:47

@mjq mjq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🙏

@nsdeschenes
nsdeschenes merged commit 2f06c9c into master Sep 2, 2026
79 checks passed
@nsdeschenes
nsdeschenes deleted the nd/chore-explore-replace-findspanattributevalue-uses branch September 2, 2026 12:42

This branch was successfully deployed

1 active deployment
Preview — f1d44f28 Deployed Sep 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants