[vaind]

• closes Embedded symbols/sources not found symbolic#750
• Depends on feat: PE embedded PPDB decompression to a custom writer symbolic#757 and a new symbolic release v11.1.0

If CLI finds a PE file with embedded PPDB, it extracts the file and uploads it separately. This way, we don't need on any custom handling in the symbolicator and symbolic-debuginfo (feature flags) and also we don't upload the PE file just for the sake of the .pdb.

The following shows DIF uploads for samples\Sentry.Samples.Console.Basic\Sentry.Samples.Console.Basic.csproj with <DebugType>embedded</DebugType>

[Swatinem]

code lgtm.
Though I do not fully understand the screenshot you posted.

Why do we suddenly get two files? Shouldn’t the portable pdb have everything in it? Or is it rather that sentry-cli creates a separate sourcebundle because you used --include-sources and it was collecting all the local files referenced from the portable pdb?

[vaind]

Why do we suddenly get two files? Shouldn’t the portable pdb have everything in it? Or is it rather that sentry-cli creates a separate sourcebundle because you used --include-sources and it was collecting all the local files referenced from the portable pdb?

Yes, that run was without "embedded sources" (<EmbedAllSoruces> flag in the project) so the CLI looked for sources manually and created a source bundle

[Swatinem]

Perfect, that makes sense! Will it do the same when you actually have embedded sources though?

[vaind]

Perfect, that makes sense! Will it do the same when you actually have embedded sources though?

No, it's just a single file. I was trying to find my yesterday's attempt but there were too many so wasn't sure which one, so ran it again now:

BTW it doesn't show that it includes sources, because Sentry isn't updated with the lastest symbolic v11 - getsentry/sentry#43832