Repository navigation
feat: PE embedded PPDB decompression to a custom writer - #757
Merged
Merged
Conversation
|
This was referenced Feb 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 73.88% 73.89% +0.01%
==========================================
Files 69 69
Lines 14951 14949 -2
==========================================
+ Hits 11046 11047 +1
+ Misses 3905 3902 -3 |
vaind
marked this pull request as ready for review
February 7, 2023 13:10
Swatinem
approved these changes
Feb 7, 2023
Swatinem
left a comment
Swatinem
left a comment
Contributor
There was a problem hiding this comment.
I would say its up to you if you want to keep the convenience methods.
Usually its the callers responsibility what kind of Write they want to provide, if they want to use a BufWriter at all, etc.
vaind
changed the title
vaind
changed the title
vaind
force-pushed
the
feat/pe-decompress-to-file
branch
from
February 7, 2023 14:02
630a347 to
737376b
Compare
vaind
enabled auto-merge (squash)
February 7, 2023 14:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #750