Skip to content

fix(tests): Fix two midnight UTC flakes - #127341

Merged
wedamija merged 1 commit into
masterfrom
danf/midnight-utc-test-flakes
Oct 14, 2026
Merged

wedamija merged 1 commit into
masterfrom
danf/midnight-utc-test-flakes

Conversation

@wedamija

Copy link
Copy Markdown
Member

Two test groups fail only in the first minutes after midnight UTC. Found while looking at #127333.

  • TagStorageTest generic issue tests (master runs 33696769930, 34292318033, 35288544029): the fixture stores its event at today 00:01 UTC. From 00:00:00 to 00:00:59 that's in the future, and snuba.query defaults end to now + 1s, so the event is excluded. Store it at before_now(minutes=1) instead.
  • test_handle_nans_from_snuba_top_n (master run 33696769930): the last 1d bucket ends at today's midnight, and incomplete_reason flags it as incomplete until 90s after that, but the expected series hardcodes incomplete: False. Freeze time at today noon for the request.

- tagstore generic issue fixture stored its event at today 00:01 UTC, which
  is in the future for the first minute after midnight, so snuba.query's
  default end (now + 1s) excluded it.
- test_handle_nans_from_snuba_top_n's last 1d bucket ends at today's
  midnight and comes back incomplete for 90s after it. Freeze time at noon.
@wedamija
wedamija requested review from a team as code owners October 13, 2026 23:50
@wedamija
wedamija requested a review from a team October 13, 2026 23:52
@wedamija
wedamija merged commit ae1ac06 into master Oct 14, 2026
65 checks passed
@wedamija
wedamija deleted the danf/midnight-utc-test-flakes branch October 14, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants