Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from django.urls import reverse
from sentry_protos.snuba.v1.trace_item_attribute_pb2 import ExtrapolationMode

from sentry.testutils.helpers.datetime import before_now
from sentry.testutils.helpers.datetime import before_now, freeze_time
from sentry.utils.snuba_rpc import _make_rpc_requests
from tests.snuba.api.endpoints.test_organization_events import OrganizationEventsEndpointTestBase
from tests.snuba.api.endpoints.test_organization_events_span_indexed import KNOWN_PREFLIGHT_ID
Expand Down Expand Up @@ -218,21 +218,27 @@ def test_handle_nans_from_snuba_top_n(self) -> None:
)
seven_days_ago = self.two_days_ago - timedelta(days=5)

response = self._do_request(
data={
"groupBy": ["span.description", "p50(measurements.lcp)", "avg(measurements.lcp)"],
"yAxis": ["p50(measurements.lcp)", "avg(measurements.lcp)"],
"project": self.project.id,
"dataset": "spans",
"excludeOther": 0,
"topEvents": 1,
"per_page": 50,
"interval": "1d",
"start": seven_days_ago,
"end": self.end,
"orderby": "-avg(measurements.lcp)",
},
)
# The last 1d bucket ends at today's midnight; just after it, the bucket is incomplete.
with freeze_time(self.day_ago + timedelta(days=1, hours=2)):
response = self._do_request(
data={
"groupBy": [
"span.description",
"p50(measurements.lcp)",
"avg(measurements.lcp)",
],
"yAxis": ["p50(measurements.lcp)", "avg(measurements.lcp)"],
"project": self.project.id,
"dataset": "spans",
"excludeOther": 0,
"topEvents": 1,
"per_page": 50,
"interval": "1d",
"start": seven_days_ago,
"end": self.end,
"orderby": "-avg(measurements.lcp)",
},
)
interval = 24 * 60 * 60 * 1000
assert response.status_code == 200, response.content

Expand Down
2 changes: 1 addition & 1 deletion tests/snuba/tagstore/test_tagstore_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def generic_group_and_env(self):
self.user.id,
[f"{ProfileFileIOGroupType.type_id}-group1"],
env.name,
timezone.now().replace(hour=0, minute=0, second=0) + timedelta(minutes=1),
before_now(minutes=1),
[("foo", "bar"), ("biz", "baz")],
"releaseme",
)
Expand Down
Loading