Skip to content

chore(releases): drop the release new_id column - #127461

Merged
ldelvoye merged 2 commits into
masterfrom
ldelvoye/chore/drop-release-new-id
Oct 15, 2026
Merged

ldelvoye merged 2 commits into
masterfrom
ldelvoye/chore/drop-release-new-id

Conversation

@ldelvoye

Copy link
Copy Markdown
Member

resolves INFRENG-673

Drops the old int4 new_id column from sentry_release, the last step of widening release.id to int8. 1211 already moved it to pending, so nothing in the app reads or writes it. Please hold the merge until #127438 has finished deploying everywhere.

@ldelvoye
ldelvoye requested a review from a team as a code owner October 14, 2026 22:33
@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

INFRENG-673

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/1212_release_drop_new_id.py

for 1212_release_drop_new_id in sentry

--
-- Remove field new_id from release
--
ALTER TABLE "sentry_release" DROP COLUMN "new_id" CASCADE;

@ldelvoye
ldelvoye force-pushed the ldelvoye/chore/drop-release-new-id branch from fbfe0b1 to 5aa5bd1 Compare October 15, 2026 17:04
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/1214_release_drop_new_id.py

for 1214_release_drop_new_id in sentry

--
-- Remove field new_id from release
--
ALTER TABLE "sentry_release" DROP COLUMN "new_id" CASCADE;

@ldelvoye
ldelvoye merged commit c00967e into master Oct 15, 2026
89 checks passed
@ldelvoye
ldelvoye deleted the ldelvoye/chore/drop-release-new-id branch October 15, 2026 17:32
ldelvoye added a commit that referenced this pull request Nov 10, 2026
resolves INFRENG-784

Drops the old int4 `new_release_id` column from `sentry_grouprelease`,
the last step of widening `release_id` to int8. 1253 (#130158) moved it
to pending and has finished deploying everywhere, so its swap guard has
passed in every region.

It also deletes the 1252 and 1253 migration tests. Both migrate back to
1251, and reversing this drop re-adds the column with a new attnum, so
1252's unswap guard sees the table as already unswapped and does
nothing. #127461 removed the release swap test for the same reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants