Repository navigation
chore(releases): drop the grouprelease new_release_id column - #130639
Merged
ldelvoye merged 2 commits intoNov 10, 2026
Merged
Conversation
Removes the old int4 column that 1253 moved to pending. Also deletes the 1252 and 1253 migration tests: reversing the drop re-adds the column with a new attnum, so 1252's unswap guard no-ops and both tests fail.
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Remove field new_release_id from grouprelease
--
ALTER TABLE "sentry_grouprelease" DROP COLUMN "new_release_id" CASCADE; |
ldelvoye
marked this pull request as ready for review
November 10, 2026 18:15
wedamija
approved these changes
Nov 10, 2026
…-grouprelease-new-release-id
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves INFRENG-784
Drops the old int4
new_release_idcolumn fromsentry_grouprelease, the last step of wideningrelease_idto int8. 1253 (#130158) moved it to pending and has finished deploying everywhere, so its swap guard has passed in every region.It also deletes the 1252 and 1253 migration tests. Both migrate back to 1251, and reversing this drop re-adds the column with a new attnum, so 1252's unswap guard sees the table as already unswapped and does nothing. #127461 removed the release swap test for the same reason.