Skip to content

ref(debug files): Add legacy WASM code/debug ID columns - #127508

Merged
loewenheim merged 3 commits into
masterfrom
sebastian/debugfile-wasm-legacy-columns
Oct 15, 2026
Merged

loewenheim merged 3 commits into
masterfrom
sebastian/debugfile-wasm-legacy-columns

Conversation

@loewenheim

@loewenheim loewenheim commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

This adds columns wasm_legacy_code_id and wasm_legacy_debug_id to the ProjectDebugFile model. These columns are nullable and will not be backfilled for any existing files.

They exist so that when we fix the way we read code/debug IDs from WASM files, WASM files can still be looked up by the incorrect ("legacy") IDs.

Both columns are also indexed in a separate migration.

Implements INGEST-1290.
Implements INGEST-1291.

@loewenheim
loewenheim requested review from a team as code owners October 15, 2026 07:59
@linear-code

linear-code Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

INGEST-1290

INGEST-1291

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 15, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 37229a5. Configure here.

This adds columns `legacy_wasm_code_id` and `legacy_wasm_debug_id` to
the `ProjectDebugFile` model. These columns are nullable and will not
be backfilled for any existing files.

They exist so that when we fix the way we read code/debug IDs from WASM
files, WASM files can still be looked up by the incorrect ("legacy") IDs.

Both columns also have indexes.
@loewenheim
loewenheim force-pushed the sebastian/debugfile-wasm-legacy-columns branch from 37229a5 to d4c702a Compare October 15, 2026 08:03
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/1212_projectdebugfile_add_wasm_legacy_columns.py src/sentry/migrations/1213_projectdebugfile_index_wasm_legacy_columns.py

for 1212_projectdebugfile_add_wasm_legacy_columns in sentry

--
-- Add field wasm_legacy_code_id to projectdebugfile
--
ALTER TABLE "sentry_projectdsymfile" ADD COLUMN "wasm_legacy_code_id" varchar(64) NULL;
--
-- Add field wasm_legacy_debug_id to projectdebugfile
--
ALTER TABLE "sentry_projectdsymfile" ADD COLUMN "wasm_legacy_debug_id" varchar(64) NULL;

for 1213_projectdebugfile_index_wasm_legacy_columns in sentry

--
-- Create index sentry_proj_project_6d1283_idx on field(s) project_id, wasm_legacy_debug_id of model projectdebugfile
--
CREATE INDEX CONCURRENTLY "sentry_proj_project_6d1283_idx" ON "sentry_projectdsymfile" ("project_id", "wasm_legacy_debug_id");
--
-- Create index sentry_proj_project_7b6c05_idx on field(s) project_id, wasm_legacy_code_id of model projectdebugfile
--
CREATE INDEX CONCURRENTLY "sentry_proj_project_7b6c05_idx" ON "sentry_projectdsymfile" ("project_id", "wasm_legacy_code_id");

@loewenheim
loewenheim requested a review from a team October 15, 2026 08:44
@loewenheim
loewenheim merged commit c0675b8 into master Oct 15, 2026
95 checks passed
@loewenheim
loewenheim deleted the sebastian/debugfile-wasm-legacy-columns branch October 15, 2026 09:14
loewenheim added a commit that referenced this pull request Oct 21, 2026
This updates `symbolic` to `14.0.0a4` for
getsentry/symbolic#1093.

The values that are written as the code and debug ID for WASM files are
now correct, but we also reproduce the previous incorrect logic and
write the results into the "legacy" fields introduced in
#127508. We do this so that
symbolication requests coming in with "legacy" IDs can still find their
files.

As such, this PR should only be merged and deployed together with
#127577.

Implements INGEST-1292.
loewenheim added a commit that referenced this pull request Oct 27, 2026
Second try of #127557, which was
reverted in
a58aad2.

This updates symbolic to 14.0.0a4 for
getsentry/symbolic#1093.

The values that are written as the code and debug ID for WASM files are
now correct, but we also reproduce the previous incorrect logic and
write the results into the "legacy" fields introduced in
#127508. We do this so that
symbolication requests coming in with "legacy" IDs can still find their
files.

As such, this PR should only be merged and deployed together with
#128494.

Implements INGEST-1292.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants