Repository navigation
ref(debug files): Add legacy WASM code/debug ID columns - #127508
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 37229a5. Configure here.
This adds columns `legacy_wasm_code_id` and `legacy_wasm_debug_id` to
the `ProjectDebugFile` model. These columns are nullable and will not
be backfilled for any existing files.
They exist so that when we fix the way we read code/debug IDs from WASM
files, WASM files can still be looked up by the incorrect ("legacy") IDs.
Both columns also have indexes.
loewenheim
force-pushed
the
sebastian/debugfile-wasm-legacy-columns
branch
from
October 15, 2026 08:03
37229a5 to
d4c702a
Compare
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Add field wasm_legacy_code_id to projectdebugfile
--
ALTER TABLE "sentry_projectdsymfile" ADD COLUMN "wasm_legacy_code_id" varchar(64) NULL;
--
-- Add field wasm_legacy_debug_id to projectdebugfile
--
ALTER TABLE "sentry_projectdsymfile" ADD COLUMN "wasm_legacy_debug_id" varchar(64) NULL;for --
-- Create index sentry_proj_project_6d1283_idx on field(s) project_id, wasm_legacy_debug_id of model projectdebugfile
--
CREATE INDEX CONCURRENTLY "sentry_proj_project_6d1283_idx" ON "sentry_projectdsymfile" ("project_id", "wasm_legacy_debug_id");
--
-- Create index sentry_proj_project_7b6c05_idx on field(s) project_id, wasm_legacy_code_id of model projectdebugfile
--
CREATE INDEX CONCURRENTLY "sentry_proj_project_7b6c05_idx" ON "sentry_projectdsymfile" ("project_id", "wasm_legacy_code_id"); |
vgrozdanic
approved these changes
Oct 15, 2026
jjbayer
approved these changes
Oct 15, 2026
3 tasks done
loewenheim
added a commit
that referenced
this pull request
Oct 21, 2026
This updates `symbolic` to `14.0.0a4` for getsentry/symbolic#1093. The values that are written as the code and debug ID for WASM files are now correct, but we also reproduce the previous incorrect logic and write the results into the "legacy" fields introduced in #127508. We do this so that symbolication requests coming in with "legacy" IDs can still find their files. As such, this PR should only be merged and deployed together with #127577. Implements INGEST-1292.
loewenheim
added a commit
that referenced
this pull request
Oct 27, 2026
Second try of #127557, which was reverted in a58aad2. This updates symbolic to 14.0.0a4 for getsentry/symbolic#1093. The values that are written as the code and debug ID for WASM files are now correct, but we also reproduce the previous incorrect logic and write the results into the "legacy" fields introduced in #127508. We do this so that symbolication requests coming in with "legacy" IDs can still find their files. As such, this PR should only be merged and deployed together with #128494. Implements INGEST-1292.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds columns
wasm_legacy_code_idandwasm_legacy_debug_idto theProjectDebugFilemodel. These columns are nullable and will not be backfilled for any existing files.They exist so that when we fix the way we read code/debug IDs from WASM files, WASM files can still be looked up by the incorrect ("legacy") IDs.
Both columns are also indexed in a separate migration.
Implements INGEST-1290.
Implements INGEST-1291.