Repository navigation
fix(debug files): Correctly read WASM IDs - #128493
Merged
Merged
Conversation
jjbayer
approved these changes
Oct 22, 2026
Dav1dde
approved these changes
Oct 22, 2026
loewenheim
force-pushed
the
sebastian/correctly-read-wasm-ids-2
branch
from
October 27, 2026 11:54
75f8e51 to
a7cb1d9
Compare
loewenheim
force-pushed
the
sebastian/correctly-read-wasm-ids-2
branch
from
October 27, 2026 13:38
a7cb1d9 to
f12653d
Compare
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second try of #127557, which was reverted in a58aad2.
This updates symbolic to 14.0.0a4 for getsentry/symbolic#1093.
The values that are written as the code and debug ID for WASM files are now correct, but we also reproduce the previous incorrect logic and write the results into the "legacy" fields introduced in #127508. We do this so that symbolication requests coming in with "legacy" IDs can still find their files.
As such, this PR should only be merged and deployed together with #128494.
Implements INGEST-1292.