Skip to content

ui: Open model details in a drawer without leaving the page - #31176

Merged
ggerganov merged 3 commits into
masterfrom
allozaur/fix/ui-model-info-drawer
Oct 27, 2026
Merged

ggerganov merged 3 commits into
masterfrom
allozaur/fix/ui-model-info-drawer

Conversation

@allozaur

@allozaur allozaur commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Improved UX for model information drawer.

Screen.Recording.2026-10-26.at.10.55.32.mov

Requirements

The model info actions in the selector used to navigate to the models page
to open its details pane, and a phone opened a separate dialog instead. The
drawer now lives outside the models table, driven by uiStore, so the info
icon opens it over whatever page is showing.

The models dropdown and the phone picker stay open under the drawer's
backdrop, and keep focus while the drawer opens and closes, so the trigger's
tooltip no longer pops over the drawer.

Assisted-by: Claude (Opus 5.5 Medium)
Dragging the drawer down wrote vaul's own open state, which the one-way open prop then kept closed, so the info action could not open it again until a refresh. Bind open both ways through the store instead.

Assisted-by: Claude (Opus 5.5 Medium)
@allozaur
allozaur force-pushed the allozaur/fix/ui-model-info-drawer branch from a367eb7 to 810c046 Compare October 26, 2026 09:40
@allozaur
allozaur marked this pull request as ready for review October 26, 2026 09:54
@allozaur
allozaur requested a review from a team as a code owner October 26, 2026 09:54
Copilot AI balanced review requested due to automatic review settings October 26, 2026 09:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@allozaur allozaur added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Oct 26, 2026
@ggerganov
ggerganov merged commit bc262f3 into master Oct 27, 2026
8 checks passed
jiangchuanso added a commit to jiangchuanso/llama.cpp-zh-el8 that referenced this pull request Oct 27, 2026
Conflicts (all in tools/ui, from ui: conversation compaction ggml-org#27401, model
details drawer ggml-org#31176, shared delete dialog ggml-org#31187, reasoning toggle ggml-org#31212):
- import unions; follow upstream restructures (openModelDetails, view-based
  tabs, CollapsibleContentBlock rewrite, use-stick-to-bottom hook rename)
- drop imports upstream made unused (MessageRole, deviceStore, ROUTES,
  RouterService, use-auto-scroll)
- keep the fork t() text layer on every reworked block
- DialogModelInformation deleted upstream: accept deletion (no refs left)
- window.confirm replaced by DialogConversationDelete in sidebar + search

i18n: translate new UI (model drawer title/description, compaction labels,
sidebar resize tooltip) and add the rewritten auto-scroll help; 866 keys,
0 missing, 0 duplicate.
auRose94 pushed a commit to auRose94/llama.cpp that referenced this pull request Oct 28, 2026
…#31176)

* ui: open model details in a global drawer without leaving the page

The model info actions in the selector used to navigate to the models page
to open its details pane, and a phone opened a separate dialog instead. The
drawer now lives outside the models table, driven by uiStore, so the info
icon opens it over whatever page is showing.

The models dropdown and the phone picker stay open under the drawer's
backdrop, and keep focus while the drawer opens and closes, so the trigger's
tooltip no longer pops over the drawer.

Assisted-by: Claude (Opus 5.5 Medium)

* ui: let the model details drawer reopen after a drag to dismiss

Dragging the drawer down wrote vaul's own open state, which the one-way open prop then kept closed, so the info action could not open it again until a refresh. Bind open both ways through the store instead.

Assisted-by: Claude (Opus 5.5 Medium)

* ui: close the models selector from the details drawer chat actions

Assisted-by: Claude (Opus 5.5 Medium)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. server/ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants