Repository navigation
ui: Open model details in a drawer without leaving the page - #31176
Merged
Merged
Conversation
The model info actions in the selector used to navigate to the models page to open its details pane, and a phone opened a separate dialog instead. The drawer now lives outside the models table, driven by uiStore, so the info icon opens it over whatever page is showing. The models dropdown and the phone picker stay open under the drawer's backdrop, and keep focus while the drawer opens and closes, so the trigger's tooltip no longer pops over the drawer. Assisted-by: Claude (Opus 5.5 Medium)
Dragging the drawer down wrote vaul's own open state, which the one-way open prop then kept closed, so the info action could not open it again until a refresh. Bind open both ways through the store instead. Assisted-by: Claude (Opus 5.5 Medium)
Assisted-by: Claude (Opus 5.5 Medium)
allozaur
force-pushed
the
allozaur/fix/ui-model-info-drawer
branch
from
October 26, 2026 09:40
a367eb7 to
810c046
Compare
allozaur
marked this pull request as ready for review
October 26, 2026 09:54
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
ServeurpersoCom
approved these changes
Oct 26, 2026
jiangchuanso
added a commit
to jiangchuanso/llama.cpp-zh-el8
that referenced
this pull request
Oct 27, 2026
Conflicts (all in tools/ui, from ui: conversation compaction ggml-org#27401, model details drawer ggml-org#31176, shared delete dialog ggml-org#31187, reasoning toggle ggml-org#31212): - import unions; follow upstream restructures (openModelDetails, view-based tabs, CollapsibleContentBlock rewrite, use-stick-to-bottom hook rename) - drop imports upstream made unused (MessageRole, deviceStore, ROUTES, RouterService, use-auto-scroll) - keep the fork t() text layer on every reworked block - DialogModelInformation deleted upstream: accept deletion (no refs left) - window.confirm replaced by DialogConversationDelete in sidebar + search i18n: translate new UI (model drawer title/description, compaction labels, sidebar resize tooltip) and add the rewritten auto-scroll help; 866 keys, 0 missing, 0 duplicate.
auRose94
pushed a commit
to auRose94/llama.cpp
that referenced
this pull request
Oct 28, 2026
…#31176) * ui: open model details in a global drawer without leaving the page The model info actions in the selector used to navigate to the models page to open its details pane, and a phone opened a separate dialog instead. The drawer now lives outside the models table, driven by uiStore, so the info icon opens it over whatever page is showing. The models dropdown and the phone picker stay open under the drawer's backdrop, and keep focus while the drawer opens and closes, so the trigger's tooltip no longer pops over the drawer. Assisted-by: Claude (Opus 5.5 Medium) * ui: let the model details drawer reopen after a drag to dismiss Dragging the drawer down wrote vaul's own open state, which the one-way open prop then kept closed, so the info action could not open it again until a refresh. Bind open both ways through the store instead. Assisted-by: Claude (Opus 5.5 Medium) * ui: close the models selector from the details drawer chat actions Assisted-by: Claude (Opus 5.5 Medium)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improved UX for model information drawer.
Screen.Recording.2026-10-26.at.10.55.32.mov
Requirements
Claude (Opus 5.5 Medium)