Skip to content

ui: Highlight reasoning toggle on hover and align it with model selector - #31212

Merged
ggerganov merged 1 commit into
masterfrom
allozaur/fix/reasoning-toggle-hover
Oct 27, 2026
Merged

ggerganov merged 1 commit into
masterfrom
allozaur/fix/reasoning-toggle-hover

Conversation

@allozaur

@allozaur allozaur commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Proper UI for Thinking panel toggle.

Screen.Recording.2026-10-26.at.19.13.22.mov

Requirements

On desktop, the reasoning effort toggle now gets a muted background on
hover and while its menu is open, matches the model selector's 24px
height, uses a 13px icon and sits 5px from the selector.

Assisted-by: Claude (Opus 5.5 Medium)
@allozaur
allozaur requested a review from a team as a code owner October 26, 2026 18:14
Copilot AI balanced review requested due to automatic review settings October 26, 2026 18:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@allozaur allozaur added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Oct 26, 2026
@ggerganov
ggerganov merged commit 823df7d into master Oct 27, 2026
7 checks passed
jiangchuanso added a commit to jiangchuanso/llama.cpp-zh-el8 that referenced this pull request Oct 27, 2026
Conflicts (all in tools/ui, from ui: conversation compaction ggml-org#27401, model
details drawer ggml-org#31176, shared delete dialog ggml-org#31187, reasoning toggle ggml-org#31212):
- import unions; follow upstream restructures (openModelDetails, view-based
  tabs, CollapsibleContentBlock rewrite, use-stick-to-bottom hook rename)
- drop imports upstream made unused (MessageRole, deviceStore, ROUTES,
  RouterService, use-auto-scroll)
- keep the fork t() text layer on every reworked block
- DialogModelInformation deleted upstream: accept deletion (no refs left)
- window.confirm replaced by DialogConversationDelete in sidebar + search

i18n: translate new UI (model drawer title/description, compaction labels,
sidebar resize tooltip) and add the rewritten auto-scroll help; 866 keys,
0 missing, 0 duplicate.
auRose94 pushed a commit to auRose94/llama.cpp that referenced this pull request Oct 28, 2026
…tor (ggml-org#31212)

On desktop, the reasoning effort toggle now gets a muted background on
hover and while its menu is open, matches the model selector's 24px
height, uses a 13px icon and sits 5px from the selector.

Assisted-by: Claude (Opus 5.5 Medium)
edwardyoon pushed a commit to edwardyoon/focus-llama that referenced this pull request Oct 30, 2026
…tor (ggml-org#31212)

On desktop, the reasoning effort toggle now gets a muted background on
hover and while its menu is open, matches the model selector's 24px
height, uses a 13px icon and sits 5px from the selector.

Assisted-by: Claude (Opus 5.5 Medium)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. server/ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants