[lint-monster] lint-monster: function-length refactoring backlog #50164

Authoritative tracking issue for the shared function-length refactoring backlog from the daily custom-linter scan.

Current authoritative count

• 673 function-length findings total
• pkg/cli: 385 findings
• pkg/workflow: 288 findings

Scope

Treat all largefunc findings in pkg/workflow and pkg/cli as one shared backlog. Do not split into separate tracking issues by package, part number, or count snapshot.

Representative diagnostics

• pkg/workflow/awf_helpers.go:229: BuildAWFCommand is 377 lines long.
• pkg/workflow/safe_outputs_config_extraction.go:45: extractSafeOutputsConfig is 370 lines long.
• pkg/workflow/awf_config.go:470: BuildAWFConfigJSON is 301 lines long.
• pkg/cli/add_interactive_workflow.go:17: checkStatusAndOfferRun is 146 lines long.
• pkg/cli/add_workflow_pr.go:53: addWorkflowsWithPR is 128 lines long.
• pkg/cli/add_wizard_command.go:15: NewAddWizardCommand is 123 lines long.

Next slices to refactor

• Start with the most localized 61-80 line functions in pkg/workflow.
• Refactor the smallest pkg/cli overages next to retire many findings quickly.
• Extract narrow helpers; preserve behavior and signatures where possible.
• Re-run make golint-custom and update this issue with the new count.

Remediation guidance

• Keep each PR scoped to a small batch of related functions.
• Prefer helper extraction over semantic rewrites.
• Validate with make golint-custom.

Duplicate issue handling

• No authoritative duplicate issue could be confirmed from the current sandbox reads, so this issue is the consolidated tracker for today.

Generated by 🧌 LintMonster · gpt54 · 14.8 AIC · ⌖ 5.25 AIC · ⊞ 5.5K · ◷

• expires on Aug 10, 2026, 7:41 PM UTC-08:00

Authoritative tracking issue for the shared function-length refactoring backlog from the daily custom-linter scan.

Current authoritative count

• 676 function-length findings total
• pkg/cli: 385 findings
• pkg/workflow: 291 findings

Scope

Treat all largefunc findings in pkg/workflow and pkg/cli as one shared backlog. Do not split into separate tracking issues by package, part number, or count snapshot.

Representative diagnostics

• pkg/workflow/awf_helpers.go:229: BuildAWFCommand is 377 lines long.
• pkg/workflow/safe_outputs_config_extraction.go:45: extractSafeOutputsConfig is 370 lines long.
• pkg/workflow/awf_config.go:469: BuildAWFConfigJSON is 296 lines long.
• pkg/cli/logs_download.go:138: downloadRunArtifacts is 321 lines long.
• pkg/cli/logs_report.go:184: buildLogsData is 321 lines long.
• pkg/cli/compile_pipeline.go:347: compileAllFilesInDirectory is 311 lines long.

Next slices to refactor

• Start with the most localized 61-80 line functions in pkg/workflow to retire many findings quickly.
• Refactor the smallest pkg/cli overages next, especially interactive/add and audit render helpers.
• Extract narrow helpers; preserve behavior and signatures where possible.
• Keep each PR scoped to a small batch of related functions.
• Re-run make golint-custom and update this issue with the new count.

Affected paths snapshot

• pkg/cli: 385 findings across many files including compile_pipeline.go, logs_download.go, logs_report.go, mcp_tools_privileged.go, and update_actions.go.
• pkg/workflow: 291 findings across many files including awf_helpers.go, safe_outputs_config_extraction.go, safe_outputs_max_validation.go, compiler_safe_outputs_job.go, and unified_prompt_step.go.

Remediation guidance

• Validate fixes by running make golint-custom.
• Keep remediation scoped to the assigned lint slice only.
• Prefer minimal, targeted code edits and helper extraction over semantic rewrites.

Duplicate issue handling

• Authoritative issue: [lint-monster] lint-monster: function-length refactoring backlog #50164
• Open duplicates closed this run: none
• Related recent closed lint-monster issue reviewed: [lint-monster] lint-monster: fix context propagation lint in pkg/ctxutil #50162 (different root cause, not a duplicate of function-length tracking)

Generated by 🧌 LintMonster · gpt54 · 23.2 AIC · ⌖ 6.05 AIC · ⊞ 5.5K · ◷

Authoritative tracking issue for the shared function-length refactoring backlog from the daily custom-linter scan.

Current authoritative count

• 652 function-length findings total
• pkg/cli: 175 findings
• pkg/workflow: 477 findings

Scope

Treat all largefunc findings in pkg/workflow and pkg/cli as one shared backlog. Do not split into separate tracking issues by package, part number, or count snapshot.

Representative diagnostics

• pkg/workflow/awf_command_builder.go:24: BuildAWFCommand is 377 lines long.
• pkg/workflow/safe_outputs_config_extraction.go:45: extractSafeOutputsConfig is 370 lines long.
• pkg/workflow/awf_config.go:465: BuildAWFConfigJSON is 296 lines long.
• pkg/cli/add_wizard_command.go:15: NewAddWizardCommand is 123 lines long.
• pkg/cli/add_workflow_pr.go:53: addWorkflowsWithPR is 128 lines long.
• pkg/cli/audit_diff.go:625: computeToolCallsDiff is 131 lines long.

Affected paths snapshot

• pkg/workflow: 477 findings across 315 files; top hotspots include dependabot.go (6), compiler_custom_jobs.go (5), cache.go (4), central_slash_command_workflow.go (4), and frontmatter_extraction_security.go (4).
• pkg/cli: 175 findings across 109 files; top hotspots include update_actions.go (6), audit_diff_render.go (5), forecast_compute.go (5), add_workflow_resolution.go (4), and audit_diff.go (4).

Next slices to refactor

• Start with the most localized 61-80 line functions in pkg/workflow to retire many findings quickly.
• Refactor the smallest pkg/cli overages next, especially update_actions.go, audit render helpers, and add-workflow helpers.
• Extract narrow helpers; preserve behavior and signatures where possible.
• Keep each PR scoped to a small batch of related functions.
• Re-run make golint-custom and update this issue with the new count.

Remediation guidance

• Validate fixes by running make golint-custom.
• Keep remediation scoped to the assigned lint slice only.
• Prefer minimal, targeted code edits and helper extraction over semantic rewrites.

Duplicate issue handling

• Authoritative issue: [lint-monster] lint-monster: function-length refactoring backlog #50164
• Open duplicates closed this run: none
• Related recent closed function-length tracker reviewed: [lint-monster] function-length refactoring backlog #51498 (closed duplicate / stale snapshot)> Generated by 🧌 LintMonster · gpt54 · 35 AIC · ⌖ 5.43 AIC · ⊞ 5.7K · ◷

Authoritative tracking issue for the shared function-length refactoring backlog from the daily custom-linter scan.

Current authoritative count

• 679 function-length findings total
• pkg/cli: 386 findings
• pkg/workflow: 293 findings

Scope

Treat all largefunc findings in pkg/workflow and pkg/cli as one shared backlog. Do not split into separate tracking issues by package, part number, or count snapshot.

Representative diagnostics

• pkg/workflow/awf_command_builder.go:24: BuildAWFCommand is 377 lines long.
• pkg/workflow/safe_outputs_config_extraction.go:45: extractSafeOutputsConfig is 370 lines long.
• pkg/workflow/awf_config.go:465: BuildAWFConfigJSON is 296 lines long.
• pkg/cli/add_wizard_command.go:15: NewAddWizardCommand is 123 lines long.
• pkg/cli/add_workflow_pr.go:53: addWorkflowsWithPR is 128 lines long.
• pkg/cli/audit_diff.go:625: computeToolCallsDiff is 131 lines long.

Affected paths snapshot

• pkg/workflow: 293 findings across many files; top hotspots include dependabot.go (6), compiler_custom_jobs.go (5), cache.go (4), central_slash_command_workflow.go (4), and frontmatter_extraction_security.go (4).
• pkg/cli: 386 findings across many files; top hotspots include mcp_tools_privileged.go (6), update_actions.go (6), audit_diff_render.go (5), forecast_compute.go (5), and add_workflow_resolution.go (4).

Next slices to refactor

• Start with the most localized 61-80 line functions in pkg/workflow to retire many findings quickly.
• Refactor the smallest pkg/cli overages next, especially mcp_tools_privileged.go, update_actions.go, audit render helpers, and add-workflow helpers.
• Extract narrow helpers; preserve behavior and signatures where possible.
• Keep each PR scoped to a small batch of related functions.
• Re-run make golint-custom and update this issue with the new count.

Remediation guidance

• Validate fixes by running make golint-custom.
• Keep remediation scoped to the assigned lint slice only.
• Prefer minimal, targeted code edits and helper extraction over semantic rewrites.

Duplicate issue handling

• Authoritative issue: [lint-monster] lint-monster: function-length refactoring backlog #50164
• Open duplicates closed this run: none
• Recent closed related tracker reviewed: [lint-monster] function-length refactoring backlog #51498 (stale function-length snapshot, not reopened)

Generated by 🧌 LintMonster · pi · lint-monster daily scan> Generated by 🧌 LintMonster · gpt54 · 24.6 AIC · ⌖ 4.34 AIC · ⊞ 5.7K · ◷