[safe-output-integrator] Daily Safe Output Integrator: add missing steer test coverage by github-actions[bot] · Pull Request #62220 · github/gh-aw

github-actions · 2026-09-20T18:58:00Z

Daily Safe Output Integrator

Overview

Audited every YAML key in SafeOutputsConfig (pkg/workflow/safe_outputs_config_types.go) against:

pkg/cli/workflows/test-*.md fixtures
pkg/workflow/compiler_safe_outputs_config_test.go table-driven cases

Key Metrics

61 safe-output types extracted (excluding config-only keys: jobs, github-app, env, github-token, allowed-domains, allowed-github-references, staged, threat-detection).
Fixture coverage: 61/61 — every type already has at least one pkg/cli/workflows/test-*.md file covering it. No new fixtures needed.
Go test coverage: 1 gap found — the global steer boolean flag had no case in TestAddHandlerManagerConfigEnvVar.

Change

Added a steer config table-test case to compiler_safe_outputs_config_test.go, following the existing pattern (paired with CreateIssues so the handler-config JSON is non-empty and assertable), verified with:

go test ./pkg/workflow/ -run TestAddHandlerManagerConfigEnvVar -v

All 66 subtests pass, including the new steer_config case.

Coverage detail

No missing fixture types were found — this run required no new test-copilot-*.md files. Only the Go-side gap for steer needed a new case.

Next Actions

None — coverage is now complete for both fixtures and Go compiler tests across all supported safe-output types.

Warning

Firewall blocked 3 domains

The following domains were blocked by the firewall during workflow execution:

go.uber.org
go.yaml.in
storage.googleapis.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "go.uber.org"
    - "go.yaml.in"
    - "storage.googleapis.com"

See Network Configuration for more information.

Generated by 🔧 Daily Safe Output Integrator · copilot · auto · 180.6 AIC · ⌖ 10.7 AIC · ⊞ 7.5K · ◷

expires on Sep 23, 2026, 10:57 AM UTC-08:00

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 47.9 AIC · ⊞ 9.6K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 34.4 AIC · ⊞ 9.6K · ◷
_{Comment /souschef to run again}

✨ PR Review Safe Output Test - Run 35547324855

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

clients2.google.com
update.googleapis.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "clients2.google.com"
    - "update.googleapis.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · claude · sonnet46 · 65.4 AIC · ⌖ 17.8 AIC · ⊞ 7.9K · ◷
_{Comment /smoke-claude to run again}

Run: https://github.com/github/gh-aw/actions/runs/35562335069

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 20.5 AIC · ⊞ 9.6K · ◷
_{Comment /souschef to run again}

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 17.8 AIC · ⊞ 9.1K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 34 AIC · ⊞ 9.1K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/35607531481

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 26.5 AIC · ⊞ 9.6K · ◷
_{Comment /souschef to run again}

All safe-output types already have pkg/cli/workflows/test-*.md fixtures. This adds the one missing Go compiler-test case: the global 'steer' boolean flag in SafeOutputsConfig, following the existing table-driven pattern in compiler_safe_outputs_config_test.go. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

gh-aw-bot · 2026-09-20T19:23:01Z

@copilot This PR still needs forward progress before a maintainer can merge it.

Please refresh the branch if needed, verify the added safe-output steer test coverage, update the branch if GitHub allows it, and run the pr-finisher skill before handing the PR back to maintainers.

Run: https://github.com/github/gh-aw/actions/runs/35531716641

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 47.9 AIC · ⊞ 9.6K · ◷
_{Comment /souschef to run again}

Copilot · 2026-09-20T19:36:53Z

@copilot This PR still needs forward progress before a maintainer can merge it.

Please refresh the branch if needed, verify the added safe-output steer test coverage, update the branch if GitHub allo...

Verified commit ceed0c2: the branch is already based on the current main, the targeted TestAddHandlerManagerConfigEnvVar test passes with steer_config, and make fmt, make lint, make test-unit, make test, and make recompile all pass. I also completed the pr-finisher review; no additional branch update was needed.

gh-aw-bot · 2026-09-20T21:01:09Z

@copilot This PR still needs forward progress before a maintainer can merge it.

Please refresh the branch if needed, address any remaining review feedback or failed checks, update the branch if GitHub allows it, and run the pr-finisher skill before handing the PR back to maintainers.

Run: https://github.com/github/gh-aw/actions/runs/35537069559

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 18.8 AIC · ⊞ 9.6K · ◷
_{Comment /souschef to run again}

Copilot · 2026-09-20T21:14:29Z

@copilot This PR still needs forward progress before a maintainer can merge it.

Please refresh the branch if needed, address any remaining review feedback or failed checks, update the branch if GitHu...

Rechecked commit ceed0c2: the branch is current with main, there are no review threads or failed CI jobs, and the latest Sous Chef run succeeded in all 10 jobs. The steer-specific test plus make fmt, make lint, make test-unit, make test, and make recompile all pass. No branch update or code change was needed.

github-actions

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

clients2.google.com
update.googleapis.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "clients2.google.com"
    - "update.googleapis.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · claude · sonnet46 · 65.4 AIC · ⌖ 17.8 AIC · ⊞ 7.9K
_{Comment /smoke-claude to run again}

gh-aw-bot · 2026-09-21T04:57:27Z

@copilot This PR still needs forward progress before a maintainer can merge it.

Please refresh the branch if needed, review any remaining checks or feedback, update the branch if GitHub allows it, and run the pr-finisher skill before handing the PR back to maintainers.

Run: https://github.com/github/gh-aw/actions/runs/35562335069

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 20.5 AIC · ⊞ 9.6K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-09-21T05:10:54Z

@copilot This PR still needs forward progress before a maintainer can merge it.

Please refresh the branch if needed, review any remaining checks or feedback, update the branch if GitHub allows it, an...

Pushed fa00565 to address the remaining review feedback: enabled and disabled steer cases now explicitly verify that the global option is absent from handler-manager JSON, while retaining the env-var assertion. Targeted tests, make fmt, make lint, make test-unit, make test, make recompile, and final validation pass; the branch was already current with main.

gh-aw-bot · 2026-09-21T07:53:51Z

@copilot This PR looks ready for another pass. Please refresh the branch if needed, review current checks, and run the pr-finisher skill to move it toward merge.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

github.com
registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"
    - "registry.npmjs.org"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11.7 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

Copilot · 2026-09-21T08:07:35Z

@copilot This PR looks ready for another pass. Please refresh the branch if needed, review current checks, and run the pr-finisher skill to move it toward merge.

[!WARNING]...

Re-ran the finisher pass on fa00565: the branch is current with main, the latest Sous Chef run passed all 10 jobs, current-head action_required runs have no failed jobs, and the targeted test plus make fmt, make lint, make test-unit, make test, and make recompile pass. Both review threads are addressed and replied to; their remaining resolution toggles require maintainer action because GitHub CLI and browser authentication are unavailable here.

gh-aw-bot · 2026-09-21T08:41:12Z

@copilot This PR still needs forward progress before a maintainer can merge it.

Please refresh the branch if needed, review any remaining checks or feedback, update the branch if GitHub allows it, and run the pr-finisher skill before handing the PR back to maintainers.

Run: https://github.com/github/gh-aw/actions/runs/35578515677

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 10.3 AIC · ⊞ 9.6K · ◷
_{Comment /souschef to run again}

Copilot · 2026-09-21T08:55:52Z

@copilot This PR still needs forward progress before a maintainer can merge it.

Please refresh the branch if needed, review any remaining checks or feedback, update the branch if GitHub allows it, an...

Re-ran the finisher pass on fa00565: the branch is current with main, the latest Sous Chef run passed all 10 jobs, current-head action_required runs have no failed jobs, and the targeted test plus make fmt, make lint, make test-unit, make test, and make recompile pass. No code or branch update is needed; maintainer action remains to resolve the already-addressed review threads and approve gated checks.

github-actions · 2026-09-23T04:52:33Z

🎉 This pull request is included in a new release.

Release: v0.89.20

github-actions Bot added automation safe-outputs testing labels Sep 20, 2026

github-actions Bot mentioned this pull request Sep 20, 2026

[WIP] Daily Safe Output Integrator: work in progress #62217

Closed

github-actions Bot mentioned this pull request Sep 20, 2026

[pr-sous-chef] PR Sous Chef run summary #62080

Closed

Copilot started work on behalf of gh-aw-bot September 20, 2026 19:23 View session

Copilot finished work on behalf of gh-aw-bot September 20, 2026 19:37

Copilot AI requested a review from gh-aw-bot September 20, 2026 19:37

github-actions Bot mentioned this pull request Sep 20, 2026

[Contribution Check Report] Contribution Check — 2026-09-20 #62086

Closed

Copilot started work on behalf of gh-aw-bot September 20, 2026 21:01 View session

Copilot finished work on behalf of gh-aw-bot September 20, 2026 21:14

This was referenced Sep 21, 2026

[pr-sous-chef] PR Sous Chef run report #62242

Closed

Smoke Test: Claude - 35547324855 #62262

Closed

github-actions Bot commented Sep 21, 2026

View reviewed changes

Comment thread pkg/workflow/compiler_safe_outputs_config_test.go Outdated

Comment thread pkg/workflow/compiler_safe_outputs_config_test.go

This was referenced Sep 21, 2026

Smoke Test: Copilot - 35548662262 #62271

Closed

[Contribution Check Report] Contribution Check — 2026-09-21 #62280

Closed

Copilot started work on behalf of gh-aw-bot September 21, 2026 04:57 View session

test: verify steer stays out of handler config

fa00565

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot September 21, 2026 05:11

github-actions Bot mentioned this pull request Sep 21, 2026

[pr-review] Daily PR Code Quality Review — 35565851309 #62321

Closed

Copilot started work on behalf of gh-aw-bot September 21, 2026 07:54 View session

Copilot finished work on behalf of gh-aw-bot September 21, 2026 08:08

Copilot started work on behalf of gh-aw-bot September 21, 2026 08:41 View session

Copilot finished work on behalf of gh-aw-bot September 21, 2026 08:57

pelikhan merged commit a427d19 into main Sep 21, 2026
2 checks passed

pelikhan deleted the daily-safe-output-integrator-20260920-c0f8c5a4505fbc9e branch September 21, 2026 14:09

Conversation

github-actions Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Daily Safe Output Integrator

Overview

Key Metrics

Change

Next Actions

Uh oh!

gh-aw-bot commented Sep 20, 2026

Uh oh!

Copilot AI commented Sep 20, 2026

Uh oh!

gh-aw-bot commented Sep 20, 2026

Uh oh!

Copilot AI commented Sep 20, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gh-aw-bot commented Sep 21, 2026

Uh oh!

Copilot AI commented Sep 21, 2026

Uh oh!

gh-aw-bot commented Sep 21, 2026

Uh oh!

Copilot AI commented Sep 21, 2026

Uh oh!

gh-aw-bot commented Sep 21, 2026

Uh oh!

Copilot AI commented Sep 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Sep 20, 2026 •

edited

Loading