Skip to content

[safe-output-integrator] Daily Safe Output Integrator: add missing steer test coverage #62220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Sep 21, 2026
Merged

[safe-output-integrator] Daily Safe Output Integrator: add missing steer test coverage #62220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceed0c2
test: add steer coverage to safe-outputs handler config test
github-actions[bot] Sep 20, 2026
fa00565
test: verify steer stays out of handler config
Copilot Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions pkg/workflow/compiler_safe_outputs_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func TestAddHandlerManagerConfigEnvVar(t *testing.T) {
checkContains []string
checkJSON bool
expectedKeys []string
absentKeys []string
}{
{
name: "create issue config",
Expand Down Expand Up @@ -912,6 +913,40 @@ func TestAddHandlerManagerConfigEnvVar(t *testing.T) {
checkJSON: true,
expectedKeys: []string{"replace_label"},
},
{
name: "steer enabled config",
safeOutputs: &SafeOutputsConfig{
Steer: true,
CreateIssues: &CreateIssuesConfig{
BaseSafeOutputConfig: BaseSafeOutputConfig{
Max: strPtr("1"),
},
},
},
checkContains: []string{
"GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG",
},
checkJSON: true,
expectedKeys: []string{"create_issue"},
Comment thread
github-actions[bot] marked this conversation as resolved.
absentKeys: []string{"steer"},
},
{
name: "steer disabled config",
safeOutputs: &SafeOutputsConfig{
Steer: false,
CreateIssues: &CreateIssuesConfig{
BaseSafeOutputConfig: BaseSafeOutputConfig{
Max: strPtr("1"),
},
},
},
checkContains: []string{
"GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG",
},
checkJSON: true,
expectedKeys: []string{"create_issue"},
absentKeys: []string{"steer"},
},
{
name: "mentions config",
safeOutputs: &SafeOutputsConfig{
Expand Down Expand Up @@ -1202,6 +1237,9 @@ func TestAddHandlerManagerConfigEnvVar(t *testing.T) {
for _, key := range tt.expectedKeys {
assert.Contains(t, config, key, "Expected config key: "+key)
}
for _, key := range tt.absentKeys {
assert.NotContains(t, config, key, "Unexpected config key: "+key)
}
}
}
}
Expand Down