Skip to content

feat(editor): add EOF legacy shortcut profile - #53

Merged
byrongamatos merged 1 commit into
fix/chord-sustain-resizefrom
feat/eof-legacy-hotkeys
Jul 5, 2026
Merged

feat(editor): add EOF legacy shortcut profile#53
byrongamatos merged 1 commit into
fix/chord-sustain-resizefrom
feat/eof-legacy-hotkeys

Conversation

@ChrisBeWithYou

Copy link
Copy Markdown
Contributor

Summary

  • add an editor shortcut profile selector with persisted FeedBack/EOF Legacy modes
  • map high-frequency EOF timeline, snap, sustain, import, save, and technique shortcuts to existing editor commands
  • add status messaging for EOF shortcuts whose editor command does not exist yet
  • add pure shortcut mapping coverage

Testing

  • node --check screen.js
  • node tests/eof_shortcuts.test.js
  • all tests/*.test.js via node

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ed0abbe2-f20e-4d1e-826f-47c64e003657

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/eof-legacy-hotkeys

Comment @coderabbitai help to get the list of available commands.

@byrongamatos

Copy link
Copy Markdown
Collaborator

Review pass (Claude Code). Clean, additive (0 deletions). The EOF profile is correctly gated — _editorDispatchEofShortcut only fires when editorShortcutProfile === 'eof' and the target isn't a typing field, and falls through (return false) when no command matches, so it never disturbs the default FeedBack profile. Claiming browser chords (Ctrl+S/Ctrl+F/Ctrl+T) is the intended point of an EOF-emulation profile the user explicitly opted into; modifier matching is strict (exact plain/ctrl/shift/alt combos). Mapped-but-unimplemented commands surface a status message rather than silently no-op'ing. node --check + all JS tests green (5 shortcut tests). No change needed. (Codex unavailable this session — rate limit — manual + test-backed.)

Signed-off-by: ChrisBeWithYou <chris@rifflarr.local>
@byrongamatos
byrongamatos force-pushed the fix/chord-sustain-resize branch from 91409dc to 738247c Compare July 5, 2026 12:24
@byrongamatos
byrongamatos force-pushed the feat/eof-legacy-hotkeys branch from 5ee923b to 232ae49 Compare July 5, 2026 12:24
@byrongamatos
byrongamatos merged commit f84d411 into fix/chord-sustain-resize Jul 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants