editor: snap-grid upgrade wired through the shortcut-profile system (supersedes #46)

[ChrisBeWithYou]

Re-does #46 (editor-snap-navigation) on top of the shortcut-profile stack (#53→#54→#55→#56), resolving the Alt+Arrow collision between them.

The conflict

#46 hardcoded Alt+Arrow → anchor-jump in a profile-agnostic onKeyDown switch. #55's FeedBack Native profile binds Alt+Arrow → note-jump (anchor moves to Ctrl+Alt+Arrow). Two independent modern schemes for one key — not legacy-vs-modern (EOF Legacy never uses Alt+Arrow; it uses Alt+PageUp/Dn for anchors). Merged as-is they'd silently shadow each other (note in the Native profile, anchor in EOF). Resolution: the profile system owns all key bindings; #46 contributes only its engine.

Kept from #46

• Expanded snap grid — SNAP_OPTIONS with straight + triplet divisions and a split-out S.snapEnabled on/off toggle (button + JS-populated select + persistence); snapTime() rewritten onto the pure _snapTimeToGrid.
• Interval-aware grid math — _editorJumpGrid now uses _nextGridTime (the grid point in the beat interval containing the cursor, correct across tempo changes) instead of a fixed step add, seeking via _editorSeekToTime so playback follows like every other jump.

Dropped from #46

• The hardcoded Alt/Shift/Ctrl+Arrow onKeyDown block — Alt+Arrow now resolves per active profile via the command-ID tables.
• Its redundant stateful jump engine (_navigateTimeline/_jumpCursorTo/_maxScrollX/_currentNoteTimes/_currentAnchorTimes) — the profile's _editorJump* already own beat/note/anchor.

Also fixes a guaranteed integration break

#46 removed SNAP_VALUES, but the stack's _editorSnapStepSeconds (which also powers sustain-resize) and the snapUp command still read it — both migrated to SNAP_OPTIONS[idx].step + S.snapEnabled.

Testing

All 20 editor test suites pass — snap_navigation 8/8, eof_shortcuts 11/11, node --check screen.js.

Supersedes #46 (please close it in favor of this). Stacked on #56.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 70b7219b-57e6-4580-af3e-bbf6a50cffc4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/snap-grid-on-profile-stack

---

_{Comment @coderabbitai help to get the list of available commands.}

[ChrisBeWithYou]

Integration note — from a full-queue dry-run that merged every open org PR into a next-version test build.

This PR can't be merged alongside #55/#56, which already ship a full snap-to-grid system on main: schema {value, subdivisions} via SNAP_OPTIONS/SNAP_VALUES, _editorSnapStepSeconds/_editorToggleSnapEnabled, the editor-snap-enabled checkbox, prevGrid/nextGrid shortcut cases, and a passing snap_options.test.js. This PR reimplements the same subsystem with an incompatible {step} schema and a different UI (editor-snap-toggle button + updateSnapUI/_persistSnapPrefs/localStorage). They collide hard — redeclared const SNAP_OPTIONS (SyntaxError), duplicate window.editorSetSnap, conflicting screen.html markup — on all 8 conflict hunks.

Recommend: close this and re-submit just the delta — the triplet divisions (1/3T, 1/6T, 1/12T, 1/48T, 1/96T) added as entries in the existing SNAP_OPTIONS. That's the only user-facing gain here over what's already on main, and it's a ~5-line change against the shipped system instead of a competing rewrite.

[byrongamatos]

Heads-up @ChrisBeWithYou — the rest of the editor stack (#47–#69) and #45 are now merged to main. This PR was auto-closed when its base branch got cleaned up during the merge; I've reopened it and retargeted it to main, so its work is preserved.

It now needs a decision. #62 reworks the snap grid via the shortcut-profile system ("supersedes #46"), but the linear line that merged already includes #57 (expand snap grid options) + #58 (snap enable toggle) — effectively a second snap-grid implementation. The two touch the same screen.html / screen.js regions and conflict, which is why this now shows CONFLICTING against main.

Two paths, your call:

1. editor: snap-grid upgrade wired through the shortcut-profile system (supersedes #46) #62 supersedes feat(editor): expand snap grid options #57/feat(editor): add snap enable toggle #58 too — then we revert feat(editor): expand snap grid options #57/feat(editor): add snap enable toggle #58 from main and rebase editor: snap-grid upgrade wired through the shortcut-profile system (supersedes #46) #62 on top. (feat(editor): clamp timeline scroll bounds #59+ were built on feat(editor): expand snap grid options #57/feat(editor): add snap enable toggle #58, so that path needs a re-check.)
2. feat(editor): expand snap grid options #57/feat(editor): add snap enable toggle #58 stand — then editor: snap-grid upgrade wired through the shortcut-profile system (supersedes #46) #62 is redundant and can be closed, or trimmed to only what it adds beyond them.

Not merging either way until you confirm which snap-grid approach is the keeper.

[ChrisBeWithYou]

Decision: closing #62 in favor of the merged #57/#58 standalone snap-grid options.

#57/#58 are already on main, tested, and carry the fine triplet subdivisions (1/12–1/96). Adopting #62's shortcut-profile {step} model would mean reworking a working, merged subsystem for little net gain.

The one thing #62 adds that main lacks — the coarse triplet steps 1/3T (quarter-note triplet) and 1/6T — will be ported as a tiny follow-up onto the merged {value, subdivisions} options (plus optional T labels on the existing triplet entries).

Your work here isn't lost — it's preserved on feat/snap-grid-on-profile-stack. Thanks for the clean reconciliation; the profile-stack approach is on record if we revisit unifying snap with the hotkey system later.