Skip to content

feat(editor): add loop region playback toggle - #60

Merged
byrongamatos merged 1 commit into
feat/editor-scroll-boundsfrom
feat/editor-loop-region-selector
Jul 5, 2026
Merged

feat(editor): add loop region playback toggle#60
byrongamatos merged 1 commit into
feat/editor-scroll-boundsfrom
feat/editor-loop-region-selector

Conversation

@ChrisBeWithYou

Copy link
Copy Markdown
Contributor

Summary

  • add a toolbar Loop toggle for the selected timeline region
  • keep loop controls synchronized with selected-region create, resize, clear, and disabled states
  • restart editor playback at the region start when active playback reaches the selected end
  • extend loop-region helper tests for normalization and playback restart behavior

Testing

  • node --check screen.js
  • node tests/loop_region.test.js
  • node tests/pending_view.test.js
  • node tests/eof_shortcuts.test.js
  • node tests/scroll_bounds.test.js
  • node tests/snap_options.test.js
  • all tests/*.test.js via node

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 69b62d92-8303-4fd0-a532-f39d80ea5abb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/editor-loop-region-selector

Comment @coderabbitai help to get the list of available commands.

@byrongamatos

Copy link
Copy Markdown
Collaborator

Review pass (Claude Code) — stacked on #59; extends (doesn't conflict with) #47's loop-region strip, which is in its stack base. Clean: _normalizeLoopRegionPure swaps end<start, clamps to duration, enforces a min gap; _loopPlaybackRestartTimePure returns the region start once the cursor reaches the end; playbackTick seeks there via _restartPlaybackAt (and is suppressed while recording, so a take isn't disturbed); _updateLoopRegionControls auto-disables the loop when the region is cleared. node --check + all JS tests green (6 loop tests). No bug.

Note: only inherits the stack-wide items already flagged (built on the draft #47 loop strip + the pre-fix #55 drum-shortcut base). Nothing #60-specific. (Codex rate-limited until ~1 AM — manual + test-backed.)

@byrongamatos
byrongamatos force-pushed the feat/editor-scroll-bounds branch from 15d607c to ee4b88d Compare July 5, 2026 12:25
@byrongamatos
byrongamatos force-pushed the feat/editor-loop-region-selector branch from 351f989 to e9fc8ca Compare July 5, 2026 12:25
@byrongamatos
byrongamatos merged commit 95e33b1 into feat/editor-scroll-bounds Jul 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants