Skip to content

feat(editor): add tempo signature denominator control - #61

Merged
byrongamatos merged 1 commit into
feat/editor-loop-region-selectorfrom
feat/editor-tempo-signature-denominator
Jul 5, 2026
Merged

feat(editor): add tempo signature denominator control#61
byrongamatos merged 1 commit into
feat/editor-loop-region-selectorfrom
feat/editor-tempo-signature-denominator

Conversation

@ChrisBeWithYou

Copy link
Copy Markdown
Contributor

Summary

  • add a Tempo Map denominator selector for selected-measure signatures
  • display selected measures as numerator/denominator labels on the tempo grid
  • keep numerator edits using the selected denominator in status feedback
  • add unit coverage for denominator normalization and downbeat-only edits

Testing

  • node --check screen.js
  • node tests/tempo_map_timesig.test.js
  • node tests/tempo_map_bpm.test.js
  • all tests/*.test.js via node

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c202a1b5-bbfc-4f8d-bc40-e1cab38ab078

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/editor-tempo-signature-denominator

Comment @coderabbitai help to get the list of available commands.

@byrongamatos

Copy link
Copy Markdown
Collaborator

Review pass (Claude Code) — stacked on #60; extends #50's numerator work (in its base). Own logic is correct: _tempoNormalizeDenominatorPure clamps to {2,4,8,16} (default 4), _tempoSetDenominatorOnBeatsPure stores beat.den on the downbeat via the undoable TempoGridCmd (doesn't touch beat times), and the grid label + numerator status message read it back consistently. node --check + all JS tests green (6 timesig tests).

Note (scope, not a bug): beat.den is display-only — it isn't serialized to the manifest, so a denominator change is lost on save/reload. That matches #50's own note ('denominator support needs the later song timeline/time_signatures model integration'), so it's the intended incremental split; the model/persistence side is the follow-up. Only other flags are stack-inherited (built on the draft #50 tempo work + the pre-fix #55 drum-shortcut base). (Codex rate-limited until ~1 AM — manual + test-backed.)

@byrongamatos
byrongamatos force-pushed the feat/editor-loop-region-selector branch from 351f989 to e9fc8ca Compare July 5, 2026 12:25
@byrongamatos
byrongamatos force-pushed the feat/editor-tempo-signature-denominator branch from ac18e2f to cc11270 Compare July 5, 2026 12:25
@byrongamatos
byrongamatos merged commit adf8527 into feat/editor-loop-region-selector Jul 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants